strongduanmu commented on code in PR #19287:
URL: https://github.com/apache/shardingsphere/pull/19287#discussion_r925116958
##########
shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/dml/select-special-function.xml:
##########
@@ -211,4 +211,92 @@
<simple-table name="t_order" start-index="29" stop-index="35" />
</from>
</select>
+
+ <select sql-case-id="select_ifnull">
Review Comment:
This PR should not change the SQL parsing, so there is no need to add
additional SQL Parser test cases.
##########
shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/select/projection/engine/ProjectionEngine.java:
##########
@@ -125,8 +128,16 @@ private ColumnProjection createProjection(final
ColumnProjectionSegment projecti
return new ColumnProjection(owner,
projectionSegment.getColumn().getIdentifier().getValue(),
projectionSegment.getAlias().orElse(null));
}
- private ExpressionProjection createProjection(final
ExpressionProjectionSegment projectionSegment) {
- return new ExpressionProjection(projectionSegment.getText(),
projectionSegment.getAlias().orElse(null));
+ private ExpressionProjection createProjection(final TableSegment table,
final ExpressionProjectionSegment projectionSegment) {
Review Comment:
We need add unit test and integration test to cover these new logics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
