TeslaCN commented on code in PR #19371:
URL: https://github.com/apache/shardingsphere/pull/19371#discussion_r925104825
##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/distsql/ral/queryable/ConvertYamlConfigurationHandler.java:
##########
@@ -67,61 +64,75 @@ protected Collection<LocalDataQueryResultRow> getRows(final
ContextManager conte
} catch (final IOException ex) {
throw new ShardingSphereException(ex);
}
- String convertedDistSQL = generateConvertedDistSQL(yamlConfig);
- return Collections.singleton(new
LocalDataQueryResultRow(convertedDistSQL));
+ Preconditions.checkNotNull(yamlConfig, String.format("Invalid yaml
file `%s`", file.getName()));
Review Comment:
Consider replacing String.format with Preconditions' method with template.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
