terrymanu opened a new issue, #19252: URL: https://github.com/apache/shardingsphere/issues/19252
ShardingSphereDataSourceFactoryTest.assertCreateDataSourceWithDatabaseName() contains multiple calls of `ShardingSphereDataSourceFactory.createDataSource()`. It is better to split them into different test cases. Please make one test case just assert one scenario. The method should be split to: - [ ] assertCreateDataSourceWithModeConfiguration - [ ] assertCreateDataSourceWithDatabaseNameAndModeConfiguration - [ ] assertCreateDataSourceWithAllParametersForMultipleDataSourcesWithDefaultDatabaseName - [ ] assertCreateDataSourceWithAllParametersForMultipleDataSources - [ ] assertCreateDataSourceWithAllParametersForSingleDataSourceWithDefaultDatabaseName - [ ] assertCreateDataSourceWithAllParametersForSingleDataSource - [ ] assertCreateDataSourceWithDefaultModeConfigurationForMultipleDataSources - [ ] assertCreateDataSourceWithDatabaseNameAndDefaultModeConfigurationForMultipleDataSources - [ ] assertCreateDataSourceWithDefaultModeConfigurationForSingleDataSource - [ ] assertCreateDataSourceWithDatabaseNameAndDefaultModeConfigurationForSingleDataSource -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
