TeslaCN commented on code in PR #18859:
URL: https://github.com/apache/shardingsphere/pull/18859#discussion_r914506924
##########
shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/text/admin/mysql/executor/MySQLSetCharsetExecutor.java:
##########
@@ -60,7 +61,13 @@ private Charset parseCharset(final String value) {
case "utf8mb4":
return StandardCharsets.UTF_8;
default:
- return Charset.forName(value);
+ try {
+ return Charset.forName(value);
+ // CHECKSTYLE:OFF
+ } catch (Exception ex) {
Review Comment:
Why does it need the check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
