yx9o commented on code in PR #17928: URL: https://github.com/apache/shardingsphere/pull/17928#discussion_r881266478
########## shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-optimizer/src/test/java/org/apache/shardingsphere/infra/federation/optimizer/context/parser/dialect/OptimizerSQLDialectBuilderFactoryTest.java: ########## @@ -0,0 +1,26 @@ +package org.apache.shardingsphere.infra.federation.optimizer.context.parser.dialect; + +import java.util.Properties; +import org.apache.shardingsphere.infra.database.type.DatabaseType; +import org.apache.shardingsphere.infra.database.type.DatabaseTypeFactory; +import org.apache.shardingsphere.infra.federation.optimizer.context.parser.dialect.impl.MySQLOptimizerBuilder; +import org.apache.shardingsphere.infra.federation.optimizer.context.parser.fixture.OptimizerSQLDialectBuilderFixture; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.mockito.junit.MockitoJUnitRunner; + +import static org.junit.Assert.assertEquals; + +@RunWith(MockitoJUnitRunner.class) +public class OptimizerSQLDialectBuilderFactoryTest { + + @Test + public void assertCreateOptimizerSQLDialectBuilder() { + DatabaseType databaseType = DatabaseTypeFactory.getInstance("MySQL"); + OptimizerSQLDialectBuilder optimizerSQLDialectBuilder = new OptimizerSQLDialectBuilderFixture(databaseType); + assertEquals(optimizerSQLDialectBuilder.getClass(), MySQLOptimizerBuilder.class); + Properties properties = optimizerSQLDialectBuilder.build(); + assertEquals(properties, new Properties()); + Review Comment: Please remove unnecessary blank lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org