[GitHub] [shardingsphere] zhaoguhong commented on a diff in pull request #17603: Support encrypt config queryWithCipherColumn with column levels

[GitBox]

zhaoguhong commented on code in PR #17603:
URL: https://github.com/apache/shardingsphere/pull/17603#discussion_r876839812


##########
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rule/EncryptTable.java:
##########
@@ -48,7 +48,7 @@ public EncryptTable(final EncryptTableRuleConfiguration 
config, final Map<String
             columns.put(each.getLogicColumn(), new 
EncryptColumn(getEncryptColumnDataType(each.getLogicDataType(), dataTypes), 
each.getCipherColumn(),
                     getEncryptColumnDataType(each.getCipherDataType(), 
dataTypes), each.getAssistedQueryColumn(), 
getEncryptColumnDataType(each.getAssistedQueryDataType(),
                             dataTypes),
-                    each.getPlainColumn(), 
getEncryptColumnDataType(each.getPlainDataType(), dataTypes), 
each.getEncryptorName()));
+                    each.getPlainColumn(), 
getEncryptColumnDataType(each.getPlainDataType(), dataTypes), 
each.getEncryptorName(), each.getQueryWithCipherColumn()));

Review Comment:
   I added some test cases for `isQueryWithCipherColumn`.
   What do you recommend for performance testing?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org