[GitHub] [shardingsphere] cheese8 commented on a diff in pull request #17516: refactor TableExtractor to merge two extractTablesFromInsert methods

[GitBox]

cheese8 commented on code in PR #17516:
URL: https://github.com/apache/shardingsphere/pull/17516#discussion_r873145258


##########
shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/InsertStatementContext.java:
##########
@@ -62,38 +63,51 @@ public final class InsertStatementContext extends 
CommonSQLStatementContext<Inse
     
     private final List<String> columnNames;
     
+    private final Map<Integer, List<String>> columnNamesMap = new 
LinkedHashMap<>();
+    
     private final Map<String, ShardingSphereMetaData> metaDataMap;
     
     private final String defaultDatabaseName;
     
     private final List<String> insertColumnNames;
     
-    private final List<List<ExpressionSegment>> valueExpressions;
+    private final Map<Integer, List<List<ExpressionSegment>>> valueExpressions 
= new LinkedHashMap<>();
     
     private List<InsertValueContext> insertValueContexts;
     
+    private Map<Integer, List<InsertValueContext>> insertValueContextsMap = 
new LinkedHashMap<>();
+    
     private InsertSelectContext insertSelectContext;
     
     private OnDuplicateUpdateContext onDuplicateKeyUpdateValueContext;
     
-    private GeneratedKeyContext generatedKeyContext;
+    private Map<Integer, GeneratedKeyContext> generatedKeyContexts = new 
LinkedHashMap<>();
     
     public InsertStatementContext(final Map<String, ShardingSphereMetaData> 
metaDataMap, final List<Object> parameters,
                                   final InsertStatement sqlStatement, final 
String defaultDatabaseName) {
         super(sqlStatement);
         this.metaDataMap = metaDataMap;
         this.defaultDatabaseName = defaultDatabaseName;
         insertColumnNames = getInsertColumnNames();
-        valueExpressions = getAllValueExpressions(sqlStatement);
-        AtomicInteger parametersOffset = new AtomicInteger(0);
-        insertValueContexts = getInsertValueContexts(parameters, 
parametersOffset, valueExpressions);
-        insertSelectContext = getInsertSelectContext(metaDataMap, parameters, 
parametersOffset, defaultDatabaseName).orElse(null);
-        onDuplicateKeyUpdateValueContext = 
getOnDuplicateKeyUpdateValueContext(parameters, parametersOffset).orElse(null);
+        
         tablesContext = new TablesContext(getAllSimpleTableSegments(), 
getDatabaseType());
         ShardingSphereSchema schema = getSchema(metaDataMap, 
defaultDatabaseName);
-        columnNames = useDefaultColumns() ? 
schema.getAllColumnNames(sqlStatement.getTable().getTableName().getIdentifier().getValue())
 : insertColumnNames;
-        generatedKeyContext = new GeneratedKeyContextEngine(sqlStatement, 
schema)
-                .createGenerateKeyContext(insertColumnNames, 
getAllValueExpressions(sqlStatement), parameters).orElse(null);
+        
+        AtomicInteger parametersOffset = new AtomicInteger(0);

Review Comment:
   This PR based on #17432 , already updated in it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org