terrymanu opened a new issue, #17537: URL: https://github.com/apache/shardingsphere/issues/17537
The steps of add test case of SPI factories: 1. Create or reuse a SPI fixture, name as `XXXFixture` in test folder and do not forget put them into META-INF/services; 2. Add test case for XXXFactory's `newInstance`, `findInstance`, `getInstance`, `getInstances`, `getAllInstances` and so on; 3.Please reference `ClusterPersistRepositoryFactoryTest` or `ScalingEntryFactoryTest` as samples. The SPI factories need to be tested are: - [ ] SQLExecutionUnitBuilderFactory - [ ] DatabaseTypeFactory - [ ] PipelineDataSourceCreatorFactory - [ ] RALUpdaterFactory - [ ] SQLVisitorFacadeFactory - [ ] OptimizerSQLDialectBuilderFactory - [ ] TransactionConfigurationFileGeneratorFactory - [ ] PositionInitializerFactory - [ ] DialectDDLGenerator - [ ] OKProxyStateFactory - [ ] PipelineSQLBuilderFactory - [ ] DriverStateFactory - [ ] PersistRepositoryConfigurationYamlSwapperFactory - [ ] DatetimeLoadingSQLProviderFactory - [ ] DataSourceCheckerFactory - [ ] StoragePrivilegeHandlerFactory - [ ] RuleDefinitionAlterPreprocessorFactory - [ ] SaneQueryResultEngineFactory - [ ] RuleDefinitionUpdaterFactory - [ ] MetaDataRefresherFactory - [ ] StatementMemoryStrictlyFetchSizeSetterFactory - [ ] ReplicaLoadBalanceAlgorithmFactory - [ ] DatetimeServiceFactory - [ ] RowBasedJobLockFactory - [ ] RuleBasedJobLockFactory - [ ] KeyGenerateAlgorithmFactory - [ ] RuleAlteredJobConfigurationPreparerFactory - [ ] TrafficLoadBalanceAlgorithmFactory - [ ] ResultProcessEngineFactory - [ ] SQLRouterFactory - [ ] SQLCheckerFactory - [ ] RuleBasedSchemaMetaDataBuilderFactory - [ ] ExecutionPrepareDecoratorFactory - [ ] SQLRewriteContextDecoratorFactory - [ ] DataNodeBuilderFactory - [ ] SchemaRuleBuilderFactory - [ ] GlobalRuleBuilderFactory - [ ] DefaultGlobalRuleConfigurationBuilderFactory - [ ] DefaultSchemaRuleConfigurationBuilderFactory The SPI factories need to add more test cases are: - [ ] XAConnectionWrapperFactoryTest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
