rfscouto commented on a change in pull request #11964:
URL: https://github.com/apache/shardingsphere/pull/11964#discussion_r694574013
##########
File path:
shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/resultset/DatabaseMetaDataResultSet.java
##########
@@ -358,10 +350,27 @@ public Object getObject(final String columnLabel) throws
SQLException {
@Override
public int findColumn(final String columnLabel) throws SQLException {
checkClosed();
- if (!columnLabelIndexMap.containsKey(columnLabel)) {
- throw new SQLException(String.format("Can not find columnLabel
%s", columnLabel));
+
+ Integer columnIndex = columnLabelIndexMap.get(columnLabel);
Review comment:
That is completely fine by me. It is exactly what I had initial though
about, but then read https://github.com/apache/shardingsphere/issues/5432 and
thought we wanted to be aligned with the implementation of one of the big ones
(and I made it aligned with PostgreSQL).
Converted to TreeMap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
