tristaZero commented on a change in pull request #10462:
URL: https://github.com/apache/shardingsphere/pull/10462#discussion_r638698045
##########
File path:
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/refresher/type/AlterTableStatementSchemaRefresher.java
##########
@@ -42,11 +46,30 @@
public void refresh(final ShardingSphereSchema schema, final
Collection<String> routeDataSourceNames,
final AlterTableStatement sqlStatement, final
SchemaBuilderMaterials materials) throws SQLException {
String tableName =
sqlStatement.getTable().getTableName().getIdentifier().getValue();
+ Optional<SimpleTableSegment> renameTable =
Optional.ofNullable(sqlStatement.getRenameTable());
Review comment:
Is it better to enable `sqlStatement` return
`Optional<SimpleTableSegment>` for `renameTable`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]