[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #10148: Implement OraclePrivilegeHandler and add unit test

[GitBox]

Liangda-w commented on a change in pull request #10148:
URL: https://github.com/apache/shardingsphere/pull/10148#discussion_r619396617



##########
File path: 
shardingsphere-infra/shardingsphere-infra-authority/shardingsphere-infra-authority-common/src/main/java/org/apache/shardingsphere/authority/provider/natived/builder/dialect/OraclePrivilegeHandler.java
##########
@@ -151,12 +174,12 @@ private void collectSysPrivileges(final 
Map<ShardingSphereUser, List<PrivilegeTy
     }
     
     private String getSysPrivilegesSQL(final Collection<ShardingSphereUser> 
users) {
-        String userList = users.stream().map(each -> String.format("'%s'", 
each.getGrantee().getUsername())).collect(Collectors.joining(", "));
+        String userList = users.stream().map(each -> String.format("%s", 
each.getGrantee().getUsername())).collect(Collectors.joining(", "));

Review comment:
       yes, I agree! Thank you for pointing out the mistakes😄  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org