This is an automated email from the ASF dual-hosted git repository.

zhangyonglun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new e309a57  Refactor CommonSQLStatementContext (#9558)
e309a57 is described below

commit e309a576d676bbc171539dfdba1206de19dd4201
Author: Liang Zhang <[email protected]>
AuthorDate: Tue Mar 2 11:19:45 2021 +0800

    Refactor CommonSQLStatementContext (#9558)
    
    * Refactor CommonSQLStatementContext
    
    * Refactor CommonSQLStatementContext
---
 .../statement/CommonSQLStatementContext.java       | 29 ++++++++++++----------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git 
a/shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/CommonSQLStatementContext.java
 
b/shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/CommonSQLStatementContext.java
index 0d0726b..ed8fffe 100644
--- 
a/shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/CommonSQLStatementContext.java
+++ 
b/shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/CommonSQLStatementContext.java
@@ -46,23 +46,26 @@ public class CommonSQLStatementContext<T extends 
SQLStatement> implements SQLSta
     
     public CommonSQLStatementContext(final T sqlStatement) {
         this.sqlStatement = sqlStatement;
-        databaseType = initDatabaseType(sqlStatement);
         tablesContext = new TablesContext(Collections.emptyList());
+        databaseType = getDatabaseType(sqlStatement);
     }
     
-    private DatabaseType initDatabaseType(final SQLStatement sqlStatement) {
-        DatabaseType databaseType = null;
+    private DatabaseType getDatabaseType(final SQLStatement sqlStatement) {
         if (sqlStatement instanceof MySQLStatement) {
-            databaseType = DatabaseTypeRegistry.getActualDatabaseType("MySQL");
-        } else if (sqlStatement instanceof PostgreSQLStatement) {
-            databaseType = 
DatabaseTypeRegistry.getActualDatabaseType("PostgreSQL");
-        } else if (sqlStatement instanceof OracleStatement) {
-            databaseType = 
DatabaseTypeRegistry.getActualDatabaseType("Oracle");
-        } else if (sqlStatement instanceof SQLServerStatement) {
-            databaseType = 
DatabaseTypeRegistry.getActualDatabaseType("SQLServer");
-        } else if (sqlStatement instanceof SQL92Statement) {
-            databaseType = DatabaseTypeRegistry.getActualDatabaseType("SQL92");
+            return DatabaseTypeRegistry.getActualDatabaseType("MySQL");
         }
-        return databaseType;
+        if (sqlStatement instanceof PostgreSQLStatement) {
+            return DatabaseTypeRegistry.getActualDatabaseType("PostgreSQL");
+        }
+        if (sqlStatement instanceof OracleStatement) {
+            return DatabaseTypeRegistry.getActualDatabaseType("Oracle");
+        }
+        if (sqlStatement instanceof SQLServerStatement) {
+            return DatabaseTypeRegistry.getActualDatabaseType("SQLServer");
+        }
+        if (sqlStatement instanceof SQL92Statement) {
+            return DatabaseTypeRegistry.getActualDatabaseType("SQL92");
+        }
+        throw new 
UnsupportedOperationException(sqlStatement.getClass().getName());
     }
 }

Reply via email to