This is an automated email from the ASF dual-hosted git repository.

menghaoran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new dd27694  Remove useless json type in IT (#9423)
dd27694 is described below

commit dd27694079c09cf8eb73c4459335e75373b9cee8
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Feb 18 13:29:58 2021 +0800

    Remove useless json type in IT (#9423)
---
 .../integration/cases/assertion/IntegrationTestCaseAssertion.java   | 6 ------
 .../shardingsphere/test/integration/cases/value/SQLValue.java       | 2 +-
 2 files changed, 1 insertion(+), 7 deletions(-)

diff --git 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/cases/assertion/IntegrationTestCaseAssertion.java
 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/cases/assertion/IntegrationTestCaseAssertion.java
index 3711304..5c99db5 100644
--- 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/cases/assertion/IntegrationTestCaseAssertion.java
+++ 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/cases/assertion/IntegrationTestCaseAssertion.java
@@ -62,12 +62,6 @@ public final class IntegrationTestCaseAssertion {
         Collection<SQLValue> result = new LinkedList<>();
         int count = 0;
         for (String each : 
Splitter.on(",").trimResults().splitToList(parameters)) {
-            // TODO improve the implement way
-            if (each.startsWith("'")) {
-                String value = each.substring(each.indexOf('\'') + 1, 
each.lastIndexOf('\''));
-                result.add(new SQLValue(value, "json", ++count));
-                continue;
-            }
             List<String> parameterPair = 
Splitter.on(":").trimResults().splitToList(each);
             result.add(new SQLValue(parameterPair.get(0), 
parameterPair.get(1), ++count));
         }
diff --git 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/cases/value/SQLValue.java
 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/cases/value/SQLValue.java
index ba2e8aa..c8bf8c3 100644
--- 
a/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/cases/value/SQLValue.java
+++ 
b/shardingsphere-test/shardingsphere-integration-test/shardingsphere-integration-test-suite/src/test/java/org/apache/shardingsphere/test/integration/cases/value/SQLValue.java
@@ -39,7 +39,7 @@ public final class SQLValue {
     }
     
     private Object getValue(final String value, final String type) throws 
ParseException {
-        if (null == type || "varchar".equals(type) || "char".equals(type) || 
"String".equals(type) || "json".equals(type)) {
+        if (null == type || "varchar".equals(type) || "char".equals(type) || 
"String".equals(type)) {
             return value;
         }
         if ("int".equals(type)) {

Reply via email to