menghaoranss commented on a change in pull request #8905:
URL: https://github.com/apache/shardingsphere/pull/8905#discussion_r552388298
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/job/ScalingJob.java
##########
@@ -41,7 +41,7 @@
private long jobId;
- private int shardingItem;
+ private Integer shardingItem;
Review comment:
maybe int is better?
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-core/src/test/java/org/apache/shardingsphere/scaling/core/fixture/FixtureH2DataSourceChecker.java
##########
@@ -35,4 +35,9 @@ public void checkPrivilege(final Collection<? extends
DataSource> dataSources) {
@Override
public void checkVariable(final Collection<? extends DataSource>
dataSources) {
}
+
+ @Override
+ public void checkTargetTable(final Collection<? extends DataSource>
dataSources, final Collection<String> tableNames) {
+
Review comment:
useless empty line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
