kfwang90 commented on issue #8736: URL: https://github.com/apache/shardingsphere/issues/8736#issuecomment-754306075
> @kfwang90, > > Hi your issue needs a little improvement. Would you like to fix it and raise a PR? No worries, If you have no interests, we will post it to the community. > > Here are some points for you. > > 1. Modify `pattern` in `PostgreSQLDataSourceMetaData` to support the this url `"jdbc:postgresql://node1,node2,node3/accounting?targetServerType=master"`. > 2. You can refer to `pattern` in `MySQLDataSourceMetaData` > 3. Since `pattern` is just a regular expression, it is easy to fix. > 4. Please add unit test in `PostgreSQLDataSourceMetaDataTest`. OK. I will try to fix it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
