This is an automated email from the ASF dual-hosted git repository.

menghaoran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new ffa10ce  refactor agent code. (#8746)
ffa10ce is described below

commit ffa10ce43276144486835d3e167f35ac4a060e04
Author: xiaoyu <[email protected]>
AuthorDate: Thu Dec 24 11:58:47 2020 +0800

    refactor agent code. (#8746)
---
 .../core/plugin/definition/PluginDefinition.java   | 27 +--------
 .../core/plugin/loader/AgentPluginLoader.java      | 68 +++++++++++-----------
 .../agent/core/plugin/service/BootService.java     |  3 +-
 .../api/definition/MetricsPluginDefinition.java    |  4 +-
 .../pom.xml                                        |  8 +++
 ...ngsphere.agent.core.plugin.service.BootService} |  0
 ...sphere.agent.metrics.api.MetricsRegisterFactory | 17 ++++++
 .../jaeger/definition/JaegerPluginDefinition.java  |  2 +-
 .../jaeger/service/JaegerTracingBootService.java   |  4 --
 ...ngsphere.agent.core.plugin.service.BootService} |  0
 .../zipkin/definition/ZipkinPluginDefinition.java  |  2 +-
 .../zipkin/service/ZipkinTracingBootService.java   |  8 +--
 ...ngsphere.agent.core.plugin.service.BootService} |  0
 13 files changed, 70 insertions(+), 73 deletions(-)

diff --git 
a/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/definition/PluginDefinition.java
 
b/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/definition/PluginDefinition.java
index de474eb..d1e180d 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/definition/PluginDefinition.java
+++ 
b/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/definition/PluginDefinition.java
@@ -17,16 +17,13 @@
 
 package org.apache.shardingsphere.agent.core.plugin.definition;
 
-import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
-
 import java.util.List;
 import java.util.Map;
 import java.util.stream.Collectors;
 import lombok.Getter;
 import lombok.RequiredArgsConstructor;
 import 
org.apache.shardingsphere.agent.core.plugin.point.PluginInterceptorPoint;
-import org.apache.shardingsphere.agent.core.plugin.service.BootService;
 
 /**
  * Plugin definition.
@@ -36,12 +33,10 @@ public abstract class PluginDefinition {
     
     private final Map<String, PluginInterceptorPoint.Builder> 
interceptorPointMap = Maps.newHashMap();
     
-    private final List<Class<? extends BootService>> bootServices = 
Lists.newArrayList();
-    
     @Getter
     private final String pluginName;
     
-    protected abstract void define();
+    protected abstract void definition();
     
     protected PluginInterceptorPoint.Builder intercept(final String 
classNameOfTarget) {
         if (interceptorPointMap.containsKey(classNameOfTarget)) {
@@ -53,30 +48,12 @@ public abstract class PluginDefinition {
     }
     
     /**
-     * Register boot service to agent.
-     *
-     * @param service the class of Service
-     */
-    protected void registerService(final Class<? extends BootService> service) 
{
-        bootServices.add(service);
-    }
-    
-    /**
      * Build collection of pluginInterceptorPoint.
      *
      * @return Collection of pluginInterceptorPoint
      */
     public final List<PluginInterceptorPoint> build() {
-        define();
+        definition();
         return 
interceptorPointMap.values().stream().map(PluginInterceptorPoint.Builder::install).collect(Collectors.toList());
     }
-    
-    /**
-     * To get all boot services.
-     *
-     * @return all boot services
-     */
-    public List<Class<? extends BootService>> getAllServices() {
-        return bootServices;
-    }
 }
diff --git 
a/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/loader/AgentPluginLoader.java
 
b/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/loader/AgentPluginLoader.java
index 5b500c5..3aec8f3 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/loader/AgentPluginLoader.java
+++ 
b/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/loader/AgentPluginLoader.java
@@ -22,18 +22,6 @@ import com.google.common.collect.ImmutableMap;
 import com.google.common.collect.Lists;
 import com.google.common.collect.Maps;
 import com.google.common.io.ByteStreams;
-import lombok.RequiredArgsConstructor;
-import lombok.SneakyThrows;
-import lombok.extern.slf4j.Slf4j;
-import net.bytebuddy.description.type.TypeDescription;
-import net.bytebuddy.matcher.ElementMatcher;
-import net.bytebuddy.matcher.ElementMatcher.Junction;
-import org.apache.shardingsphere.agent.core.path.AgentPathBuilder;
-import org.apache.shardingsphere.agent.core.config.AgentConfiguration;
-import 
org.apache.shardingsphere.agent.core.plugin.point.PluginInterceptorPoint;
-import org.apache.shardingsphere.agent.core.plugin.definition.PluginDefinition;
-import org.apache.shardingsphere.agent.core.cache.AgentObjectPool;
-
 import java.io.ByteArrayOutputStream;
 import java.io.Closeable;
 import java.io.File;
@@ -52,6 +40,17 @@ import java.util.jar.Attributes;
 import java.util.jar.JarEntry;
 import java.util.jar.JarFile;
 import java.util.zip.ZipEntry;
+import lombok.RequiredArgsConstructor;
+import lombok.SneakyThrows;
+import lombok.extern.slf4j.Slf4j;
+import net.bytebuddy.description.type.TypeDescription;
+import net.bytebuddy.matcher.ElementMatcher;
+import net.bytebuddy.matcher.ElementMatcher.Junction;
+import org.apache.shardingsphere.agent.core.cache.AgentObjectPool;
+import org.apache.shardingsphere.agent.core.config.AgentConfiguration;
+import org.apache.shardingsphere.agent.core.path.AgentPathBuilder;
+import org.apache.shardingsphere.agent.core.plugin.definition.PluginDefinition;
+import 
org.apache.shardingsphere.agent.core.plugin.point.PluginInterceptorPoint;
 
 /**
  * Agent plugin loader.
@@ -104,30 +103,31 @@ public final class AgentPluginLoader extends ClassLoader 
implements Closeable {
             return;
         }
         Map<String, PluginInterceptorPoint> pointMap = Maps.newHashMap();
-        Set<String> activatedPlugins = 
AgentObjectPool.INSTANCE.get(AgentConfiguration.class).getIgnorePlugins();
-        ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
-        for (File jarFile : jarFiles) {
-            outputStream.reset();
-            JarFile jar = new JarFile(jarFile, true);
-            jars.add(new PluginJar(jar, jarFile));
-            log.info("Loaded jar {}.", jarFile.getName());
-            Attributes attributes = jar.getManifest().getMainAttributes();
-            String entrypoint = attributes.getValue("Entrypoint");
-            if (Strings.isNullOrEmpty(entrypoint)) {
-                log.warn("Entrypoint is not setting in {}.", 
jarFile.getName());
-                continue;
-            }
-            
ByteStreams.copy(jar.getInputStream(jar.getEntry(classNameToPath(entrypoint))), 
outputStream);
-            try {
-                PluginDefinition pluginDefinition = (PluginDefinition) 
defineClass(entrypoint, outputStream.toByteArray(), 0, 
outputStream.size()).newInstance();
-                if (!activatedPlugins.isEmpty() && 
!activatedPlugins.contains(pluginDefinition.getPluginName())) {
+        Set<String> ignorePlugins = 
AgentObjectPool.INSTANCE.get(AgentConfiguration.class).getIgnorePlugins();
+        try (ByteArrayOutputStream outputStream = new ByteArrayOutputStream()) 
{
+            for (File jarFile : jarFiles) {
+                outputStream.reset();
+                JarFile jar = new JarFile(jarFile, true);
+                jars.add(new PluginJar(jar, jarFile));
+                log.info("Loaded jar {}.", jarFile.getName());
+                Attributes attributes = jar.getManifest().getMainAttributes();
+                String entrypoint = attributes.getValue("Entrypoint");
+                if (Strings.isNullOrEmpty(entrypoint)) {
+                    log.warn("Entrypoint is not setting in {}.", 
jarFile.getName());
                     continue;
                 }
-                buildPluginInterceptorPointMap(pluginDefinition, pointMap);
-                // CHECKSTYLE:OFF
-            } catch (final Throwable ex) {
-                // CHECKSTYLE:ON
-                log.error("Failed to load plugin definition, {}.", entrypoint, 
ex);
+                try {
+                    
ByteStreams.copy(jar.getInputStream(jar.getEntry(classNameToPath(entrypoint))), 
outputStream);
+                    PluginDefinition pluginDefinition = (PluginDefinition) 
defineClass(entrypoint, outputStream.toByteArray(), 0, 
outputStream.size()).newInstance();
+                    if (!ignorePlugins.isEmpty() && 
ignorePlugins.contains(pluginDefinition.getPluginName())) {
+                        continue;
+                    }
+                    buildPluginInterceptorPointMap(pluginDefinition, pointMap);
+                    // CHECKSTYLE:OFF
+                } catch (final Throwable ex) {
+                    // CHECKSTYLE:ON
+                    log.error("Failed to load plugin definition, {}.", 
entrypoint, ex);
+                }
             }
         }
         interceptorPointMap = ImmutableMap.<String, 
PluginInterceptorPoint>builder().putAll(pointMap).build();
diff --git 
a/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/service/BootService.java
 
b/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/service/BootService.java
index a958cfd..1f2e254 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/service/BootService.java
+++ 
b/shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/service/BootService.java
@@ -45,5 +45,6 @@ public interface BootService<T extends PluginConfiguration> 
extends AgentTypedSP
     /**
      * Cleanup the boot service.
      */
-    void cleanup();
+    default void cleanup() {
+    }
 }
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/definition/MetricsPluginDefinition.java
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/definition/MetricsPluginDefinition.java
index a2aa42e..d5e5acc 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/definition/MetricsPluginDefinition.java
+++ 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-api/src/main/java/org/apache/shardingsphere/agent/metrics/api/definition/MetricsPluginDefinition.java
@@ -19,7 +19,6 @@ package 
org.apache.shardingsphere.agent.metrics.api.definition;
 
 import net.bytebuddy.matcher.ElementMatchers;
 import org.apache.shardingsphere.agent.core.plugin.definition.PluginDefinition;
-import org.apache.shardingsphere.agent.metrics.api.provider.MetricsProvider;
 import org.apache.shardingsphere.agent.metrics.api.constant.MethodNameConstant;
 
 /**
@@ -48,7 +47,7 @@ public final class MetricsPluginDefinition extends 
PluginDefinition {
     }
     
     @Override
-    protected void define() {
+    protected void definition() {
         intercept(COMMAND_EXECUTOR_TASK_ENHANCE_CLASS)
                 
.aroundInstanceMethod(ElementMatchers.named(MethodNameConstant.COMMAND_EXECUTOR_RUN))
                 .implement(COMMAND_EXECUTOR_TASK_ADVICE_CLASS)
@@ -66,6 +65,5 @@ public final class MetricsPluginDefinition extends 
PluginDefinition {
                 
.aroundInstanceMethod(ElementMatchers.named(MethodNameConstant.COMMIT).or(ElementMatchers.named(MethodNameConstant.ROLL_BACK)))
                 .implement(TRANSACTION_ADVICE_CLASS)
                 .build();
-        MetricsProvider.INSTANCE.newInstance();
     }
 }
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/pom.xml
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/pom.xml
index 94836ed..7325475 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/pom.xml
+++ 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/pom.xml
@@ -32,6 +32,7 @@
     <properties>
         <prometheus.version>0.6.0</prometheus.version>
         <prometheus.jmx.version>0.10</prometheus.jmx.version>
+        
<entrypoint.class>org.apache.shardingsphere.agent.metrics.api.definition.MetricsPluginDefinition</entrypoint.class>
     </properties>
     
     <dependencies>
@@ -68,6 +69,13 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
+                <configuration>
+                    <archive>
+                        <manifestEntries>
+                            <Entrypoint>${entrypoint.class}</Entrypoint>
+                        </manifestEntries>
+                    </archive>
+                </configuration>
             </plugin>
             <plugin>
                 <artifactId>maven-shade-plugin</artifactId>
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.bootService
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.BootService
similarity index 100%
rename from 
shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.bootService
rename to 
shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.BootService
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.metrics.api.MetricsRegisterFactory
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.metrics.api.MetricsRegisterFactory
index 2d4063d..025aaea 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.metrics.api.MetricsRegisterFactory
+++ 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-metrics/shardingsphere-agent-metrics-prometheus/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.metrics.api.MetricsRegisterFactory
@@ -15,4 +15,21 @@
 # limitations under the License.
 #
 
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
 
org.apache.shardingsphere.agent.metrics.prometheus.register.PrometheusMetricsRegisterFactory
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/jaeger/definition/JaegerPluginDefinition.java
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/jaeger/definition/JaegerPluginDefinition.java
index 7e8f703..05d86d4 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/jaeger/definition/JaegerPluginDefinition.java
+++ 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/jaeger/definition/JaegerPluginDefinition.java
@@ -51,7 +51,7 @@ public final class JaegerPluginDefinition extends 
PluginDefinition {
     }
     
     @Override
-    protected void define() {
+    protected void definition() {
         intercept(COMMAND_EXECUTOR_TASK_ENHANCE_CLASS)
                 
.aroundInstanceMethod(ElementMatchers.named(COMMAND_EXECUTOR_METHOD_NAME))
                 .implement(COMMAND_EXECUTOR_TASK_ADVICE_CLASS)
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/jaeger/service/JaegerTracingBootService.java
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/jaeger/service/JaegerTracingBootService.java
index f1b1c70..b5dd7d9 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/jaeger/service/JaegerTracingBootService.java
+++ 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/jaeger/service/JaegerTracingBootService.java
@@ -45,10 +45,6 @@ public final class JaegerTracingBootService implements 
BootService<JaegerPluginC
     }
     
     @Override
-    public void cleanup() {
-    }
-    
-    @Override
     public String getType() {
         return AgentConstant.PLUGIN_NAME_JAEGER;
     }
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.bootService
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.BootService
similarity index 100%
rename from 
shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.bootService
rename to 
shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-jaeger/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.BootService
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/zipkin/definition/ZipkinPluginDefinition.java
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/zipkin/definition/ZipkinPluginDefinition.java
index bebdfa1..308d6fd 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/zipkin/definition/ZipkinPluginDefinition.java
+++ 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/zipkin/definition/ZipkinPluginDefinition.java
@@ -51,7 +51,7 @@ public final class ZipkinPluginDefinition extends 
PluginDefinition {
     }
     
     @Override
-    protected void define() {
+    protected void definition() {
         intercept(COMMAND_EXECUTOR_TASK_ENHANCE_CLASS)
                 
.aroundInstanceMethod(ElementMatchers.named(COMMAND_EXECUTOR_METHOD_NAME))
                 .implement(COMMAND_EXECUTOR_TASK_ADVICE_CLASS)
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/zipkin/service/ZipkinTracingBootService.java
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/zipkin/service/ZipkinTracingBootService.java
index 33d0b34..f7f43f7 100644
--- 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/zipkin/service/ZipkinTracingBootService.java
+++ 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/zipkin/service/ZipkinTracingBootService.java
@@ -53,12 +53,12 @@ public final class ZipkinTracingBootService implements 
BootService<ZipkinPluginC
         sender.close();
     }
     
-    private String buildHttpPath(final ZipkinPluginConfiguration 
configuration) {
-        return "http://"; + configuration.getHost() + ":" + 
configuration.getPort();
-    }
-    
     @Override
     public String getType() {
         return AgentConstant.PLUGIN_NAME_ZIPKIN;
     }
+    
+    private String buildHttpPath(final ZipkinPluginConfiguration 
configuration) {
+        return "http://"; + configuration.getHost() + ":" + 
configuration.getPort();
+    }
 }
diff --git 
a/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.bootService
 
b/shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.BootService
similarity index 100%
rename from 
shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.bootService
rename to 
shardingsphere-agent/shardingsphere-agent-plugins/shardingsphere-agent-plugin-tracing/shardingsphere-agent-tracing-zipkin/src/main/resources/META-INF/services/org.apache.shardingsphere.agent.core.plugin.service.BootService

Reply via email to