terrymanu commented on a change in pull request #8448:
URL: https://github.com/apache/shardingsphere/pull/8448#discussion_r533324279
##########
File path:
shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/PluginAdviceDefine.java
##########
@@ -59,6 +60,14 @@ private PluginAdviceDefine(final String classNameOfTarget,
this.classStaticMethodPoints = classStaticMethodPoints;
}
+ /**
+ * Create default plugin advice define.
Review comment:
Please keep empty line between java doc content and @return
##########
File path:
shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/PluginAdviceDefine.java
##########
@@ -59,6 +60,14 @@ private PluginAdviceDefine(final String classNameOfTarget,
this.classStaticMethodPoints = classStaticMethodPoints;
}
+ /**
+ * Create default plugin advice define.
Review comment:
define should be definition
##########
File path:
shardingsphere-agent/shardingsphere-agent-core/src/main/java/org/apache/shardingsphere/agent/core/plugin/PluginLoader.java
##########
@@ -172,10 +171,7 @@ public boolean containsType(final TypeDescription
typeDescription) {
* @return the plugin definition configurations.
Review comment:
Please remove last `.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
