taojintianxia commented on a change in pull request #7236:
URL: https://github.com/apache/shardingsphere/pull/7236#discussion_r482866605
##########
File path:
shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/metadata/MetaDataManager.java
##########
@@ -43,9 +43,20 @@
* @return table meta data
*/
public TableMetaData getTableMetaData(final String tableName) {
+ return getTableMetaData(tableName, "");
Review comment:
my origin though is replace `getTableMetaData(final String tableName) `
with `getTableMetaData(final String tableName, final String databaseType) ` one
by one , and drop `getTableMetaData(final String tableName) ` at last . since
we don't support Oracle . enn , I see
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
