linghengqian commented on code in PR #2491:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/2491#discussion_r2653053919
##########
pom.xml:
##########
@@ -552,6 +560,33 @@
</plugins>
</pluginManagement>
<plugins>
+ <!-- Maven CI-Friendly Version Management -->
+ <plugin>
Review Comment:
TLDR, I personally won't agree to merge this PR. First, the next version of
elasticjob is 3.1.0, so the master branch is naturally 3.1.0-SNAPSHOT, which is
in line with the ASF Infra convention. If you need to compile elasticjob-ui,
you have to compile elasticjob first, which will automatically publish the
artifacts to the local Maven repository, and elasticjob-ui will extract the JAR
from the local repository. Second, shardingsphere itself doesn't use
flatten-maven-plugin, and it's strange that its sub-projects need to do so.
There are dedicated Maven plugins that can update version numbers in batches.
Third, you haven't applied the checkstyle rules of elasticjob for formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
