Ada-Church-Closure commented on PR #37377: URL: https://github.com/apache/shardingsphere/pull/37377#issuecomment-3682106331
@terrymanu I am currently working on supporting parameter markers for Oracle's `HierarchicalQueryClause` (CONNECT BY / START WITH). I've encountered a dilemma regarding the implementation approach and would like your advice. **Current Situation:** I need to extract parameter markers (`?`) from the `HierarchicalQueryClause`. **Option 1: Standard Visitor Pattern (Ideal but blocked)** I tried using `visit(ctx.hierarchicalQueryClause())` to follow the standard visitor pattern. However, this leads to an **NPE / Infinite Recursion** because the underlying visitor logic for `HierarchicalQueryClause` seems incomplete or not fully supported in the current `OracleDMLStatementVisitor`. **Option 2: Raw Text Scanning (Workaround)** I implemented a workaround that scans the raw text of the clause to find `?` and register parameters. * **Pros:** It works and passes the tests. * **Cons:** It's a temporary workaround and might incorrectly identify `?` inside strings or comments. **My Question:** Should I proceed with **Option 2 (the workaround)** to fix the immediate issue for this PR? Or is it required to refactor the entire `HierarchicalQueryClause` visitor logic (Option 1) to get this merged? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
