Copilot commented on code in PR #37390:
URL: https://github.com/apache/shardingsphere/pull/37390#discussion_r2620337310
##########
test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml:
##########
@@ -65,4 +65,5 @@
<sql-case id="create_procedure_with_begin_do" value="create procedure
t_sysdate() begin select sysdate() into @a; do sleep(2); end;"
db-types="MySQL"/>
<sql-case id="create_procedure_with_describe_table" value="create
procedure p1() begin describe t1; end;" db-types="MySQL"/>
<sql-case id="create_procedure_with_explain_table" value="create procedure
p1() begin explain t1; end;" db-types="MySQL"/>
+ <sql-case id="create_procedure_with_analyzeTable" value="CREATE PROCEDURE
p() ANALYZE TABLE v UPDATE HISTOGRAM ON w;" db-types="MySQL"/>
Review Comment:
The test case ID uses inconsistent naming convention. Other test case IDs
use snake_case (e.g., 'create_procedure_with_describe_table'), but this one
uses camelCase for 'analyzeTable'. It should be
'create_procedure_with_analyze_table' to match the existing pattern.
```suggestion
<sql-case id="create_procedure_with_analyze_table" value="CREATE
PROCEDURE p() ANALYZE TABLE v UPDATE HISTOGRAM ON w;" db-types="MySQL"/>
```
##########
test/it/parser/src/main/resources/case/ddl/create-procedure.xml:
##########
@@ -169,4 +169,10 @@
<sql-statement start-index="28" stop-index="38"
statement-class-simple-name="MySQLDescribeStatement" />
</sql-statements>
</create-procedure>
+ <create-procedure sql-case-id="create_procedure_with_analyzeTable">
Review Comment:
The sql-case-id reference uses camelCase 'analyzeTable', which is
inconsistent with the snake_case convention used in other test cases. This
should be 'create_procedure_with_analyze_table' to maintain consistency.
```suggestion
<create-procedure sql-case-id="create_procedure_with_analyze_table">
```
##########
test/it/parser/src/main/resources/sql/supported/ddl/create-procedure.xml:
##########
@@ -65,4 +65,5 @@
<sql-case id="create_procedure_with_begin_do" value="create procedure
t_sysdate() begin select sysdate() into @a; do sleep(2); end;"
db-types="MySQL"/>
<sql-case id="create_procedure_with_describe_table" value="create
procedure p1() begin describe t1; end;" db-types="MySQL"/>
<sql-case id="create_procedure_with_explain_table" value="create procedure
p1() begin explain t1; end;" db-types="MySQL"/>
+ <sql-case id="create_procedure_with_analyzeTable" value="CREATE PROCEDURE
p() ANALYZE TABLE v UPDATE HISTOGRAM ON w;" db-types="MySQL"/>
Review Comment:
The test case includes 'UPDATE HISTOGRAM ON w' which adds complexity, but
there is no corresponding test case for a simpler 'ANALYZE TABLE' statement
without the histogram clause. Consider adding a basic test case like 'CREATE
PROCEDURE p() BEGIN ANALYZE TABLE v; END;' to ensure the fundamental
functionality works independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
