Ada-Church-Closure opened a new pull request, #37391:
URL: https://github.com/apache/shardingsphere/pull/37391
Fixes #37276.
- Root cause: when not using a database and executing no-FROM
multi-expression SELECT, query is routed to admin branch;
UnicastResourceShowExecutor rebuilds headers and rows from
different sources, causing column-count mismatch and
IndexOutOfBoundsException in
DatabaseAdminQueryProxyBackendHandler.
- Fix: routing-only. For normal no-FROM multi-expression SELECTs
(non-sysvar, non-special functions), return Optional.empty() to use the
standard pipeline; keep sysvar/special functions/no-resource
behavior unchanged. No silent truncate/padding, aligned with maintainer’s
suggestion.
- Tests: add a test to assert skipping admin for multi-expression
no-FROM; add a regression test to assert multi sysvars still use
MySQLSystemVariableQueryExecutor.
- Impact: minimal, routing only; no behavior change for existing
admin executors.
- Many thanks for the helpful feedback. Please let me know if anything
else is required or the code is improper.
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
