This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 73c7a13dcfa Refactor JoinTableConverter (#37343)
73c7a13dcfa is described below
commit 73c7a13dcfa92c1a3587ec9deee092316859fd9f
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Dec 11 14:42:55 2025 +0800
Refactor JoinTableConverter (#37343)
---
.../sql/ast/converter/segment/from/impl/JoinTableConverter.java | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/from/impl/JoinTableConverter.java
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/from/impl/JoinTableConverter.java
index 4a2f2909bef..f887ea4d62b 100644
---
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/from/impl/JoinTableConverter.java
+++
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/from/impl/JoinTableConverter.java
@@ -43,10 +43,10 @@ import java.util.Optional;
public final class JoinTableConverter {
/**
- * Convert join table segment to sql node.
+ * Convert join table segment to SQL node.
*
* @param segment join table segment
- * @return sql node
+ * @return SQL node
*/
public static Optional<SqlNode> convert(final JoinTableSegment segment) {
SqlNode left =
TableConverter.convert(segment.getLeft()).orElseThrow(IllegalStateException::new);
@@ -58,10 +58,11 @@ public final class JoinTableConverter {
}
private static SqlLiteral convertJoinType(final JoinTableSegment segment) {
- if (JoinType.INNER.name().equals(segment.getJoinType()) &&
!segment.isNatural() && null == segment.getCondition() &&
segment.getUsing().isEmpty()) {
+ String joinTypeName = null == segment.getJoinType() ?
JoinType.INNER.name() : segment.getJoinType();
+ if (JoinType.INNER.name().equals(joinTypeName) && !segment.isNatural()
&& null == segment.getCondition() && segment.getUsing().isEmpty()) {
return JoinType.COMMA.symbol(SqlParserPos.ZERO);
}
- return
JoinType.valueOf(segment.getJoinType()).symbol(SqlParserPos.ZERO);
+ return JoinType.valueOf(joinTypeName).symbol(SqlParserPos.ZERO);
}
private static SqlLiteral convertConditionType(final JoinTableSegment
segment) {
