This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new cbee7056d95 Rename DataTypeExpressionConverter (#37338)
cbee7056d95 is described below
commit cbee7056d9577a1c88d6d52e3c468c5734a9c391
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Dec 11 09:48:54 2025 +0800
Rename DataTypeExpressionConverter (#37338)
---
.../converter/segment/expression/ExpressionConverter.java | 8 ++++----
.../impl/DataTypeExpressionConverter.java} | 13 +++++++------
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/ExpressionConverter.java
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/ExpressionConverter.java
index 59cb8451573..d7ee6d04121 100644
---
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/ExpressionConverter.java
+++
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/ExpressionConverter.java
@@ -51,6 +51,7 @@ import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segmen
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.CaseWhenExpressionConverter;
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.CollateExpressionConverter;
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.ColumnConverter;
+import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.DataTypeExpressionConverter;
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.ExistsSubqueryExpressionConverter;
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.ExtractArgExpressionConverter;
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.FunctionConverter;
@@ -68,7 +69,6 @@ import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segmen
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.UnaryOperationExpressionConverter;
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl.VariableSegmentConverter;
import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.projection.impl.AggregationProjectionConverter;
-import
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.projection.impl.DataTypeConverter;
import java.util.Optional;
@@ -79,10 +79,10 @@ import java.util.Optional;
public final class ExpressionConverter {
/**
- * Convert expression segment to sql node.
+ * Convert expression segment to SQL node.
*
* @param segment expression segment
- * @return sql node
+ * @return SQL node
* @throws UnsupportedSQLOperationException unsupported SQL operation
exception
*/
public static Optional<SqlNode> convert(final ExpressionSegment segment) {
@@ -127,7 +127,7 @@ public final class ExpressionConverter {
return
AggregationProjectionConverter.convert((AggregationProjectionSegment) segment);
}
if (segment instanceof DataTypeSegment) {
- return DataTypeConverter.convert((DataTypeSegment) segment);
+ return DataTypeExpressionConverter.convert((DataTypeSegment)
segment);
}
if (segment instanceof CaseWhenExpression) {
return CaseWhenExpressionConverter.convert((CaseWhenExpression)
segment);
diff --git
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/projection/impl/DataTypeConverter.java
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/impl/DataTypeExpressionConverter.java
similarity index 84%
rename from
kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/projection/impl/DataTypeConverter.java
rename to
kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/impl/DataTypeExpressionConverter.java
index 6e2d2bdfcb9..90f01f14802 100644
---
a/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/projection/impl/DataTypeConverter.java
+++
b/kernel/sql-federation/compiler/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/sql/ast/converter/segment/expression/impl/DataTypeExpressionConverter.java
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.projection.impl;
+package
org.apache.shardingsphere.sqlfederation.compiler.sql.ast.converter.segment.expression.impl;
import lombok.AccessLevel;
import lombok.NoArgsConstructor;
@@ -30,16 +30,16 @@ import java.util.Objects;
import java.util.Optional;
/**
- * Data type converter.
+ * Data type expression converter.
*/
@NoArgsConstructor(access = AccessLevel.PRIVATE)
-public final class DataTypeConverter {
+public final class DataTypeExpressionConverter {
/**
- * Convert data type segment to sql node.
+ * Convert data type segment to SQL node.
*
* @param segment data type segment
- * @return sql node
+ * @return SQL node
*/
public static Optional<SqlNode> convert(final DataTypeSegment segment) {
if (null == segment) {
@@ -50,7 +50,8 @@ public final class DataTypeConverter {
private static SqlBasicTypeNameSpec getSqlBasicTypeNameSpec(final
DataTypeSegment segment) {
SqlTypeName sqlTypeName =
Objects.requireNonNull(SqlTypeName.get(segment.getDataTypeName().toUpperCase()));
- return segment.getDataTypeLength().isPresent() ? new
SqlBasicTypeNameSpec(sqlTypeName, segment.getDataLength().getPrecision(),
SqlParserPos.ZERO)
+ return segment.getDataTypeLength().isPresent()
+ ? new SqlBasicTypeNameSpec(sqlTypeName,
segment.getDataLength().getPrecision(), SqlParserPos.ZERO)
: new SqlBasicTypeNameSpec(sqlTypeName, SqlParserPos.ZERO);
}
}
