This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new d11ee38ab61 Refactor SQLFederationResultSetMetaDataTest (#37302)
d11ee38ab61 is described below

commit d11ee38ab6160163b3c0a46b3b87988459b3f7bd
Author: Liang Zhang <[email protected]>
AuthorDate: Mon Dec 8 21:25:18 2025 +0800

    Refactor SQLFederationResultSetMetaDataTest (#37302)
---
 .../resultset/SQLFederationResultSetMetaDataTest.java  | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git 
a/kernel/sql-federation/core/src/test/java/org/apache/shardingsphere/sqlfederation/resultset/SQLFederationResultSetMetaDataTest.java
 
b/kernel/sql-federation/core/src/test/java/org/apache/shardingsphere/sqlfederation/resultset/SQLFederationResultSetMetaDataTest.java
index 9f8bd3fa017..919f9060b0e 100644
--- 
a/kernel/sql-federation/core/src/test/java/org/apache/shardingsphere/sqlfederation/resultset/SQLFederationResultSetMetaDataTest.java
+++ 
b/kernel/sql-federation/core/src/test/java/org/apache/shardingsphere/sqlfederation/resultset/SQLFederationResultSetMetaDataTest.java
@@ -103,7 +103,8 @@ class SQLFederationResultSetMetaDataTest {
     
     @Test
     void assertIsNullableWhenTableNullable() {
-        Schema schema = createSchemaWithTable("foo_tbl", createRowType(true, 
0, 0));
+        RelDataType rowType = createRowType(true, 0, 0);
+        Schema schema = createSchemaWithTable("foo_tbl", rowType);
         SQLFederationResultSetMetaData metaData = new 
SQLFederationResultSetMetaData(schema, Collections.singletonList(new 
ColumnProjection("foo_tbl", "foo_col", null, databaseType)),
                 databaseType, createResultType(new String[]{"foo_col"}, 
mock(RelDataType.class)), Collections.singletonMap(1, "foo_label"), mock());
         assertThat(metaData.isNullable(1), 
is(ResultSetMetaData.columnNullable));
@@ -129,7 +130,8 @@ class SQLFederationResultSetMetaDataTest {
     
     @Test
     void assertGetColumnDisplaySizeWithTable() {
-        Schema schema = createSchemaWithTable("foo_tbl", createRowType(false, 
8, 0));
+        RelDataType rowType = createRowType(false, 8, 0);
+        Schema schema = createSchemaWithTable("foo_tbl", rowType);
         SQLFederationResultSetMetaData metaData = new 
SQLFederationResultSetMetaData(schema, Collections.singletonList(new 
ColumnProjection("foo_tbl", "foo_col", null, databaseType)),
                 databaseType, createResultType(new String[]{"foo_col"}, 
mock(RelDataType.class)), Collections.singletonMap(1, "foo_label"), mock());
         assertThat(metaData.getColumnDisplaySize(1), is(8));
@@ -206,7 +208,8 @@ class SQLFederationResultSetMetaDataTest {
     
     @Test
     void assertGetPrecisionWithTable() {
-        Schema schema = createSchemaWithTable("foo_tbl", createRowType(false, 
12, 0));
+        RelDataType rowType = createRowType(false, 12, 0);
+        Schema schema = createSchemaWithTable("foo_tbl", rowType);
         SQLFederationResultSetMetaData metaData = new 
SQLFederationResultSetMetaData(schema, Collections.singletonList(new 
ColumnProjection("foo_tbl", "foo_col", null, databaseType)),
                 databaseType, createResultType(new String[]{"foo_col"}, 
mock(RelDataType.class)), Collections.singletonMap(1, "foo_label"), mock());
         assertThat(metaData.getPrecision(1), is(12));
@@ -214,7 +217,8 @@ class SQLFederationResultSetMetaDataTest {
     
     @Test
     void assertGetPrecisionNotSpecified() {
-        Schema schema = createSchemaWithTable("foo_tbl", createRowType(false, 
RelDataType.PRECISION_NOT_SPECIFIED, 0));
+        RelDataType rowType = createRowType(false, 
RelDataType.PRECISION_NOT_SPECIFIED, 0);
+        Schema schema = createSchemaWithTable("foo_tbl", rowType);
         SQLFederationResultSetMetaData metaData = new 
SQLFederationResultSetMetaData(schema, Collections.singletonList(new 
ColumnProjection("foo_tbl", "foo_col", null, databaseType)),
                 databaseType, createResultType(new String[]{"foo_col"}, 
mock(RelDataType.class)), Collections.singletonMap(1, "foo_label"), mock());
         assertThat(metaData.getPrecision(1), is(0));
@@ -237,7 +241,8 @@ class SQLFederationResultSetMetaDataTest {
     
     @Test
     void assertGetScaleWithTable() {
-        Schema schema = createSchemaWithTable("foo_tbl", createRowType(false, 
0, 4));
+        RelDataType rowType = createRowType(false, 0, 4);
+        Schema schema = createSchemaWithTable("foo_tbl", rowType);
         SQLFederationResultSetMetaData metaData = new 
SQLFederationResultSetMetaData(schema, Collections.singletonList(new 
ColumnProjection("foo_tbl", "foo_col", null, databaseType)),
                 databaseType, createResultType(new String[]{"foo_col"}, 
mock(RelDataType.class)), Collections.singletonMap(1, "foo_label"), mock());
         assertThat(metaData.getScale(1), is(4));
@@ -245,7 +250,8 @@ class SQLFederationResultSetMetaDataTest {
     
     @Test
     void assertGetScaleNotSpecified() {
-        Schema schema = createSchemaWithTable("foo_tbl", createRowType(false, 
0, RelDataType.SCALE_NOT_SPECIFIED));
+        RelDataType rowType = createRowType(false, 0, 
RelDataType.SCALE_NOT_SPECIFIED);
+        Schema schema = createSchemaWithTable("foo_tbl", rowType);
         SQLFederationResultSetMetaData metaData = new 
SQLFederationResultSetMetaData(schema, Collections.singletonList(new 
ColumnProjection("foo_tbl", "foo_col", null, databaseType)),
                 databaseType, createResultType(new String[]{"foo_col"}, 
mock(RelDataType.class)), Collections.singletonMap(1, "foo_label"), mock());
         assertThat(metaData.getScale(1), is(0));

Reply via email to