This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new aec9d93f8db Refactor test assertions to simplify argument matching in
AlterViewPushDownMetaDataRefresherTest and
LocalConfigurationMetaDataContextsInitFactoryTest (#37245)
aec9d93f8db is described below
commit aec9d93f8dbc1edf67f597aab0b9677bdb585aaf
Author: Liang Zhang <[email protected]>
AuthorDate: Mon Dec 1 22:37:11 2025 +0800
Refactor test assertions to simplify argument matching in
AlterViewPushDownMetaDataRefresherTest and
LocalConfigurationMetaDataContextsInitFactoryTest (#37245)
---
.../init/type/LocalConfigurationMetaDataContextsInitFactoryTest.java | 2 +-
.../pushdown/type/view/AlterViewPushDownMetaDataRefresherTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/factory/init/type/LocalConfigurationMetaDataContextsInitFactoryTest.java
b/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/factory/init/type/LocalConfigurationMetaDataContextsInitFactoryTest.java
index d90fe60c029..38234fa0a51 100644
---
a/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/factory/init/type/LocalConfigurationMetaDataContextsInitFactoryTest.java
+++
b/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/factory/init/type/LocalConfigurationMetaDataContextsInitFactoryTest.java
@@ -101,7 +101,7 @@ class LocalConfigurationMetaDataContextsInitFactoryTest {
MetaDataContexts actual =
factory.create(createContextManagerBuilderParameter(databaseConfigs, new
Properties()));
assertThat(actual, is(notNullValue()));
MetaDataPersistFacade persistFacade =
persistFacadeMocked.constructed().get(0);
-
verify(persistFacade).persistGlobalRuleConfiguration(eq(Collections.emptyList()),
eq(new Properties()));
+
verify(persistFacade).persistGlobalRuleConfiguration(Collections.emptyList(),
new Properties());
verify(persistFacade).persistConfigurations(eq("foo_db"),
eq(databaseConfigs.get("foo_db")),
argThat(dataSources ->
storageUnits.get("foo_ds").getDataSource().equals(dataSources.get("foo_ds"))),
anyCollection());
verify(persistFacade.getDatabaseMetaDataFacade().getSchema()).add("foo_db",
"empty_schema");
diff --git
a/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresherTest.java
b/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresherTest.java
index 28e46f366c3..0acf1b7a80e 100644
---
a/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresherTest.java
+++
b/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/refresher/pushdown/type/view/AlterViewPushDownMetaDataRefresherTest.java
@@ -89,7 +89,7 @@ class AlterViewPushDownMetaDataRefresherTest {
ShardingSphereView existingView = new ShardingSphereView("foo_view",
"SELECT 1");
ShardingSphereDatabase database = new ShardingSphereDatabase("foo_db",
databaseType, new ResourceMetaData(Collections.emptyMap()), new
RuleMetaData(Collections.singleton(rule)),
Collections.singleton(new ShardingSphereSchema("foo_schema",
Collections.emptyList(), Collections.singleton(existingView))));
- when(TableRefreshUtils.isSingleTable(eq("bar_view"),
eq(database))).thenReturn(true);
+ when(TableRefreshUtils.isSingleTable("bar_view",
database)).thenReturn(true);
ShardingSphereTable renamedTable = new ShardingSphereTable("bar_view",
Collections.emptyList(), Collections.emptyList(), Collections.emptyList());
Map<String, ShardingSphereSchema> schemas =
Collections.singletonMap("foo_schema", new ShardingSphereSchema("foo_schema",
Collections.singleton(renamedTable), Collections.emptyList()));
when(GenericSchemaBuilder.build(eq(Collections.singletonList("bar_view")),
eq(database.getProtocolType()), any())).thenReturn(schemas);