terrymanu commented on PR #34859: URL: https://github.com/apache/shardingsphere/pull/34859#issuecomment-3592366880
Thanks a lot for the contribution and for sharing this helper script. We really appreciate the intention to improve local development experience. However, after reviewing the PR in detail, we are unable to merge it at this time, mainly for the following reasons: 1. The script duplicates existing build & Docker logic Most of the steps in this script (building the proxy Docker image, obtaining the project version, running the container, mounting configuration directories) already exist in our current Maven profiles and Docker setup. Introducing a separate root-level script creates parallel logic that will need to be maintained independently. 2. Strong assumptions about environment The script assumes: Bash availability, Linux container support, Specific terminal programs (gnome-terminal / konsole), PostgreSQL client (psql), Hard-coded ports and user names. These assumptions do not hold for many contributors (e.g., Windows users, non-PSQL users), so the script cannot serve as a general-purpose development tool. 3. Tight coupling to repository structure The script directly depends on current directory layout (distribution/proxy) and image-building conventions. Any future structural changes would silently break it, adding maintenance burden. 4. Not aligned with the project’s tooling direction We try to keep ad-hoc developer scripts out of the repository root unless they are: cross-platform, integrated with existing tooling, supported long-term. This script is very helpful for personal/local use, but not yet suitable as an official tool shipped in the repository. ### Summary The idea is valuable, and we do want to improve development workflows, but this specific script cannot be merged in its current form due to maintainability, portability, and duplication issues. If you are interested, we are happy to discuss integrating this into a unified tooling module (e.g., tools/ or a docker-compose based workflow) where we can design something reusable and cross-platform. Thanks again for the proposal and for contributing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
