This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 93368d31762 Refactor inner classes to remove final modifier for
improved flexibility (#37175)
93368d31762 is described below
commit 93368d3176270dd33a75697a1d4da181504e3772
Author: Liang Zhang <[email protected]>
AuthorDate: Tue Nov 25 15:21:07 2025 +0800
Refactor inner classes to remove final modifier for improved flexibility
(#37175)
---
.../query/calculator/AbstractStreamingTableInventoryCalculator.java | 4 ++--
.../data/pipeline/core/task/runner/TransmissionTasksRunner.java | 2 +-
.../data/pipeline/core/util/PipelineDistributedBarrier.java | 3 +--
.../pipeline/mysql/ingest/incremental/client/MySQLBinlogClient.java | 4 ++--
.../main/java/org/apache/shardingsphere/data/pipeline/cdc/CDCJob.java | 2 +-
.../scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java | 4 ++--
.../statement/core/statement/type/ddl/table/CreateTableStatement.java | 4 ++--
.../backend/connector/jdbc/datasource/JDBCBackendDataSourceTest.java | 2 +-
.../connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java | 2 +-
9 files changed, 13 insertions(+), 14 deletions(-)
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/query/calculator/AbstractStreamingTableInventoryCalculator.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/query/calculator/AbstractStreamingTableInventoryCalculator.java
index f20f74ea11d..4cefbfb1922 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/query/calculator/AbstractStreamingTableInventoryCalculator.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/inventory/query/calculator/AbstractStreamingTableInventoryCalculator.java
@@ -51,7 +51,7 @@ public abstract class
AbstractStreamingTableInventoryCalculator<S> extends Abstr
* It's not thread-safe, it should be executed in only one thread at the
same time.
*/
@RequiredArgsConstructor
- private final class ResultIterable implements Iterable<S> {
+ private class ResultIterable implements Iterable<S> {
private final TableInventoryCalculateParameter param;
@@ -62,7 +62,7 @@ public abstract class
AbstractStreamingTableInventoryCalculator<S> extends Abstr
}
@RequiredArgsConstructor
- private final class ResultIterator implements Iterator<S> {
+ private class ResultIterator implements Iterator<S> {
private final AtomicBoolean currentChunkCalculated = new
AtomicBoolean();
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/task/runner/TransmissionTasksRunner.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/task/runner/TransmissionTasksRunner.java
index 8335d52fa64..836fcdebf78 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/task/runner/TransmissionTasksRunner.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/task/runner/TransmissionTasksRunner.java
@@ -128,7 +128,7 @@ public final class TransmissionTasksRunner implements
PipelineTasksRunner {
incrementalTasks.forEach(PipelineTask::stop);
}
- private final class InventoryTaskExecuteCallback implements
ExecuteCallback {
+ private class InventoryTaskExecuteCallback implements ExecuteCallback {
@Override
public void onSuccess() {
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/PipelineDistributedBarrier.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/PipelineDistributedBarrier.java
index bd20f27e6c4..4d1938f82e7 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/PipelineDistributedBarrier.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/util/PipelineDistributedBarrier.java
@@ -158,8 +158,7 @@ public final class PipelineDistributedBarrier {
private final CountDownLatch countDownLatch;
}
- @RequiredArgsConstructor
- private final class PersistRepositoryLazyInitializer extends
LazyInitializer<ClusterPersistRepository> {
+ private class PersistRepositoryLazyInitializer extends
LazyInitializer<ClusterPersistRepository> {
@Override
protected ClusterPersistRepository initialize() {
diff --git
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/client/MySQLBinlogClient.java
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/client/MySQLBinlogClient.java
index 4215ba34d17..2db6ee0c6e8 100644
---
a/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/client/MySQLBinlogClient.java
+++
b/kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/incremental/client/MySQLBinlogClient.java
@@ -290,7 +290,7 @@ public final class MySQLBinlogClient {
return Optional.of(future);
}
- private final class MySQLCommandResponseHandler extends
ChannelInboundHandlerAdapter {
+ private class MySQLCommandResponseHandler extends
ChannelInboundHandlerAdapter {
@Override
public void channelRead(final ChannelHandlerContext ctx, final Object
msg) {
@@ -308,7 +308,7 @@ public final class MySQLBinlogClient {
}
}
- private final class MySQLBinlogEventHandler extends
ChannelInboundHandlerAdapter {
+ private class MySQLBinlogEventHandler extends ChannelInboundHandlerAdapter
{
private final AtomicReference<MySQLBaseBinlogEvent> lastBinlogEvent;
diff --git
a/kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/CDCJob.java
b/kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/CDCJob.java
index c5c850fb096..e6d0206e29c 100644
---
a/kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/CDCJob.java
+++
b/kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/CDCJob.java
@@ -233,7 +233,7 @@ public final class CDCJob implements PipelineJob {
}
@RequiredArgsConstructor
- private final class CDCExecuteCallback implements ExecuteCallback {
+ private class CDCExecuteCallback implements ExecuteCallback {
private final String identifier;
diff --git
a/kernel/data-pipeline/scenario/consistency-check/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java
b/kernel/data-pipeline/scenario/consistency-check/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java
index b45a54b5b55..c4cd49140b8 100644
---
a/kernel/data-pipeline/scenario/consistency-check/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java
+++
b/kernel/data-pipeline/scenario/consistency-check/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java
@@ -101,7 +101,7 @@ public final class ConsistencyCheckTasksRunner implements
PipelineTasksRunner {
checkExecutor.stop();
}
- private final class CheckPipelineLifecycleRunnable extends
AbstractPipelineLifecycleRunnable {
+ private class CheckPipelineLifecycleRunnable extends
AbstractPipelineLifecycleRunnable {
@SuppressWarnings("unchecked")
@Override
@@ -136,7 +136,7 @@ public final class ConsistencyCheckTasksRunner implements
PipelineTasksRunner {
}
}
- private final class CheckExecuteCallback implements ExecuteCallback {
+ private class CheckExecuteCallback implements ExecuteCallback {
@Override
public void onSuccess() {
diff --git
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/ddl/table/CreateTableStatement.java
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/ddl/table/CreateTableStatement.java
index 168751a3f74..8131312eb55 100644
---
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/ddl/table/CreateTableStatement.java
+++
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/statement/type/ddl/table/CreateTableStatement.java
@@ -113,7 +113,7 @@ public final class CreateTableStatement extends
DDLStatement {
return result;
}
- private final class CreateTableConstraintSQLStatementAttribute implements
ConstraintSQLStatementAttribute {
+ private class CreateTableConstraintSQLStatementAttribute implements
ConstraintSQLStatementAttribute {
@Override
public Collection<ConstraintSegment> getConstraints() {
@@ -125,7 +125,7 @@ public final class CreateTableStatement extends
DDLStatement {
}
}
- private final class CreateTableIndexSQLStatementAttribute implements
IndexSQLStatementAttribute {
+ private class CreateTableIndexSQLStatementAttribute implements
IndexSQLStatementAttribute {
@Override
public Collection<IndexSegment> getIndexes() {
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/JDBCBackendDataSourceTest.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/JDBCBackendDataSourceTest.java
index 2e1bdf7a3fd..13826d8f425 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/JDBCBackendDataSourceTest.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/JDBCBackendDataSourceTest.java
@@ -139,7 +139,7 @@ class JDBCBackendDataSourceTest {
}
@RequiredArgsConstructor
- private final class CallableTask implements Callable<List<Connection>> {
+ private class CallableTask implements Callable<List<Connection>> {
private final JDBCBackendDataSource jdbcBackendDataSource;
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java
index ed4b3fc6b0b..169be7ca523 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java
@@ -97,7 +97,7 @@ public final class CallTimeRecordDataSource implements
DataSource, AutoCloseable
public void close() {
}
- private final class CallTimeRecordConnection implements Connection {
+ private class CallTimeRecordConnection implements Connection {
@Override
public Statement createStatement() {
