This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 369f54af46a Fix codes format (#37169)
369f54af46a is described below
commit 369f54af46a0b49e1af120077e6aaf2932dbd58e
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Nov 23 17:37:01 2025 +0800
Fix codes format (#37169)
---
.../core/metadata/data/loader/type/IndexMetaDataLoader.java | 6 +++---
.../connector/core/metadata/database/enums/QuoteCharacter.java | 2 +-
.../database/protocol/firebird/constant/FirebirdArchType.java | 6 +-----
.../row/column/value/string/MySQLJsonValueDecoderTest.java | 1 +
..._query_for_CipherColumn__ShardingSphere_5.3.0_Deep_Dive.en.md | 2 +-
.../encrypt/rewrite/condition/EncryptConditionEngine.java | 6 +++---
.../org/apache/shardingsphere/shadow/rule/ShadowTableRule.java | 2 +-
.../shardingsphere/sharding/auditor/ShardingSQLAuditorTest.java | 2 +-
.../segment/dml/column/InsertColumnsSegmentBinderTest.java | 1 +
.../segment/dml/from/type/DeleteMultiTableSegmentBinderTest.java | 1 +
.../config/swapper/mode/YamlModeConfigurationSwapperTest.java | 5 +++--
.../infra/executor/sql/process/ProcessRegistry.java | 2 +-
.../infra/expr/espresso/EspressoInlineExpressionParser.java | 6 +++---
.../state/circuit/connection/CircuitBreakerConnection.java | 3 +--
.../state/circuit/metadata/CircuitBreakerDatabaseMetaData.java | 2 +-
.../driver/state/circuit/resultset/CircuitBreakerResultSet.java | 7 +++----
.../state/circuit/resultset/CircuitBreakerResultSetMetaData.java | 2 +-
.../consistencycheck/task/ConsistencyCheckTasksRunner.java | 3 ++-
.../consistencycheck/task/ConsistencyCheckTasksRunnerTest.java | 9 +++++++--
.../apache/shardingsphere/transaction/ConnectionTransaction.java | 2 +-
.../xa/narayana/manager/DataSourceXAResourceRecoveryHelper.java | 2 +-
.../persist/metadata/DatabaseMetaDataPersistFacadeTest.java | 3 +--
.../node/rule/tuple/fixture/node/YamlNodeRuleConfiguration.java | 2 +-
.../repository/cluster/zookeeper/ZookeeperRepositoryTest.java | 1 +
.../doris/visitor/statement/type/DorisDALStatementVisitor.java | 4 ++++
.../mysql/visitor/statement/type/MySQLDALStatementVisitor.java | 4 ++++
.../oracle/visitor/statement/type/OracleDMLStatementVisitor.java | 2 ++
.../postgresql/visitor/statement/PostgreSQLStatementVisitor.java | 3 +++
.../visitor/statement/type/PostgreSQLDMLStatementVisitor.java | 2 ++
.../sqlserver/visitor/statement/SQLServerStatementVisitor.java | 4 ++++
.../visitor/statement/type/SQLServerDCLStatementVisitor.java | 3 +++
.../core/segment/dml/item/AggregationProjectionSegment.java | 2 +-
.../statement/core/value/literal/impl/StringLiteralValue.java | 2 +-
.../jdbc/datasource/fixture/CallTimeRecordDataSource.java | 2 +-
.../pipeline/scenario/migration/api/MigrationJobAPITest.java | 1 +
.../org/apache/shardingsphere/test/it/spi/SPIMatchedCheckIT.java | 2 +-
36 files changed, 68 insertions(+), 41 deletions(-)
diff --git
a/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/data/loader/type/IndexMetaDataLoader.java
b/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/data/loader/type/IndexMetaDataLoader.java
index b690499f0e6..7173fb00289 100644
---
a/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/data/loader/type/IndexMetaDataLoader.java
+++
b/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/data/loader/type/IndexMetaDataLoader.java
@@ -58,12 +58,12 @@ public final class IndexMetaDataLoader {
if (null == indexName) {
continue;
}
- if (!result.containsKey(indexName)) {
+ if (result.containsKey(indexName)) {
+
result.get(indexName).getColumns().add(resultSet.getString("COLUMN_NAME"));
+ } else {
IndexMetaData indexMetaData = new IndexMetaData(indexName,
new LinkedList<>(Collections.singleton(resultSet.getString("COLUMN_NAME"))));
indexMetaData.setUnique(!resultSet.getBoolean("NON_UNIQUE"));
result.put(indexName, indexMetaData);
- } else {
-
result.get(indexName).getColumns().add(resultSet.getString("COLUMN_NAME"));
}
}
} catch (final SQLException ex) {
diff --git
a/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/enums/QuoteCharacter.java
b/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/enums/QuoteCharacter.java
index 411043e28bd..a25962c7631 100644
---
a/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/enums/QuoteCharacter.java
+++
b/database/connector/core/src/main/java/org/apache/shardingsphere/database/connector/core/metadata/database/enums/QuoteCharacter.java
@@ -104,7 +104,7 @@ public enum QuoteCharacter {
* @return unwrapped text
*/
public static String unwrapText(final String text) {
- return QuoteCharacter.getQuoteCharacter(text).unwrap(text);
+ return getQuoteCharacter(text).unwrap(text);
}
/**
diff --git
a/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/constant/FirebirdArchType.java
b/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/constant/FirebirdArchType.java
index 73f812385e8..33d2992e84d 100644
---
a/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/constant/FirebirdArchType.java
+++
b/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/constant/FirebirdArchType.java
@@ -82,11 +82,7 @@ public enum FirebirdArchType {
} else if (SystemUtils.IS_OS_AIX) {
ARCHITECTURE = ARCH_RT;
} else if (SystemUtils.IS_OS_LINUX) {
- if (!SystemUtils.OS_ARCH.toLowerCase().contains("loong")) {
- ARCHITECTURE = ARCH_LINUX;
- } else {
- ARCHITECTURE = ARCH_LINUX_LOONG;
- }
+ ARCHITECTURE = SystemUtils.OS_ARCH.toLowerCase().contains("loong")
? ARCH_LINUX_LOONG : ARCH_LINUX;
} else if (SystemUtils.IS_OS_FREE_BSD) {
ARCHITECTURE = ARCH_FREEBSD;
} else if (SystemUtils.IS_OS_NET_BSD) {
diff --git
a/database/protocol/dialect/mysql/src/test/java/org/apache/shardingsphere/database/protocol/mysql/packet/binlog/row/column/value/string/MySQLJsonValueDecoderTest.java
b/database/protocol/dialect/mysql/src/test/java/org/apache/shardingsphere/database/protocol/mysql/packet/binlog/row/column/value/string/MySQLJsonValueDecoderTest.java
index 02021333b39..ed7cb8e949c 100644
---
a/database/protocol/dialect/mysql/src/test/java/org/apache/shardingsphere/database/protocol/mysql/packet/binlog/row/column/value/string/MySQLJsonValueDecoderTest.java
+++
b/database/protocol/dialect/mysql/src/test/java/org/apache/shardingsphere/database/protocol/mysql/packet/binlog/row/column/value/string/MySQLJsonValueDecoderTest.java
@@ -323,6 +323,7 @@ class MySQLJsonValueDecoderTest {
}
}
+ @SuppressWarnings("unchecked")
private void writeValueToByteBuf(final JsonEntry jsonEntry, final ByteBuf
byteBuf, final boolean isSmall) {
switch (jsonEntry.getType()) {
case JsonValueTypes.SMALL_JSON_OBJECT:
diff --git
a/docs/blog/content/material/2022_12_28_Fuzzy_query_for_CipherColumn__ShardingSphere_5.3.0_Deep_Dive.en.md
b/docs/blog/content/material/2022_12_28_Fuzzy_query_for_CipherColumn__ShardingSphere_5.3.0_Deep_Dive.en.md
index b467682fe58..f257f195ea8 100644
---
a/docs/blog/content/material/2022_12_28_Fuzzy_query_for_CipherColumn__ShardingSphere_5.3.0_Deep_Dive.en.md
+++
b/docs/blog/content/material/2022_12_28_Fuzzy_query_for_CipherColumn__ShardingSphere_5.3.0_Deep_Dive.en.md
@@ -165,7 +165,7 @@ public final class CharDigestLikeEncryptAlgorithm
implements LikeEncryptAlgorith
@Override
public boolean processLine(final String line) {
- if (line.startsWith("#") || 0 == line.length()) {
+ if (line.startsWith("#") || line.isEmpty()) {
return true;
} else {
builder.append(line);
diff --git
a/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java
b/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java
index 82a93ef1a46..53d3ae03e58 100644
---
a/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java
+++
b/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java
@@ -197,10 +197,10 @@ public final class EncryptConditionEngine {
private static Collection<EncryptCondition> createInEncryptCondition(final
String tableName, final InExpression inExpression, final ExpressionSegment
inRightValue) {
ColumnSegment columnSegment;
- if (!(inExpression.getLeft() instanceof ColumnSegment)) {
- return Collections.emptyList();
- } else {
+ if (inExpression.getLeft() instanceof ColumnSegment) {
columnSegment = (ColumnSegment) inExpression.getLeft();
+ } else {
+ return Collections.emptyList();
}
List<ExpressionSegment> expressionSegments = new LinkedList<>();
for (ExpressionSegment each : inExpression.getExpressionList()) {
diff --git
a/features/shadow/core/src/main/java/org/apache/shardingsphere/shadow/rule/ShadowTableRule.java
b/features/shadow/core/src/main/java/org/apache/shardingsphere/shadow/rule/ShadowTableRule.java
index 7520f2a6062..c4e4e50c7d9 100644
---
a/features/shadow/core/src/main/java/org/apache/shardingsphere/shadow/rule/ShadowTableRule.java
+++
b/features/shadow/core/src/main/java/org/apache/shardingsphere/shadow/rule/ShadowTableRule.java
@@ -44,7 +44,7 @@ public final class ShadowTableRule {
private final Map<ShadowOperationType,
Collection<ShadowAlgorithmNameRule>> columnShadowAlgorithmNames;
public ShadowTableRule(final String tableName, final Collection<String>
logicDataSourceNames, final Collection<String> shadowAlgorithmNames, final
Map<String, ShadowAlgorithm> shadowAlgorithms) {
- this.name = tableName;
+ name = tableName;
this.logicDataSourceNames = logicDataSourceNames;
hintShadowAlgorithmNames =
getHintShadowAlgorithmNames(shadowAlgorithmNames, shadowAlgorithms);
columnShadowAlgorithmNames =
getColumnShadowAlgorithmRules(shadowAlgorithmNames, shadowAlgorithms);
diff --git
a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/auditor/ShardingSQLAuditorTest.java
b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/auditor/ShardingSQLAuditorTest.java
index 2fcbbe6863c..7e47da30297 100644
---
a/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/auditor/ShardingSQLAuditorTest.java
+++
b/features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/auditor/ShardingSQLAuditorTest.java
@@ -68,7 +68,7 @@ class ShardingSQLAuditorTest {
private RuleMetaData globalRuleMetaData;
@Mock
- private ShardingSphereDatabase database =
mock(ShardingSphereDatabase.class);
+ private ShardingSphereDatabase database;
@Mock(answer = Answers.RETURNS_DEEP_STUBS)
private ShardingRule rule;
diff --git
a/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/column/InsertColumnsSegmentBinderTest.java
b/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/column/InsertColumnsSegmentBinderTest.java
index e020c63b0da..a84dd2d8aa9 100644
---
a/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/column/InsertColumnsSegmentBinderTest.java
+++
b/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/column/InsertColumnsSegmentBinderTest.java
@@ -46,6 +46,7 @@ import static org.mockito.Mockito.when;
@StaticMockSettings(ColumnSegmentBinder.class)
class InsertColumnsSegmentBinderTest {
+ @SuppressWarnings("unchecked")
@Test
void assertBind() {
ColumnSegment firstColumn = new ColumnSegment(0, 1, new
IdentifierValue("order_id"));
diff --git
a/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/from/type/DeleteMultiTableSegmentBinderTest.java
b/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/from/type/DeleteMultiTableSegmentBinderTest.java
index e2eb6bd5ddd..bb6d9ef4465 100644
---
a/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/from/type/DeleteMultiTableSegmentBinderTest.java
+++
b/infra/binder/core/src/test/java/org/apache/shardingsphere/infra/binder/engine/segment/dml/from/type/DeleteMultiTableSegmentBinderTest.java
@@ -44,6 +44,7 @@ import static org.mockito.Mockito.when;
@StaticMockSettings(TableSegmentBinder.class)
class DeleteMultiTableSegmentBinderTest {
+ @SuppressWarnings("unchecked")
@Test
void assertBind() {
DeleteMultiTableSegment segment = new DeleteMultiTableSegment();
diff --git
a/infra/common/src/test/java/org/apache/shardingsphere/infra/yaml/config/swapper/mode/YamlModeConfigurationSwapperTest.java
b/infra/common/src/test/java/org/apache/shardingsphere/infra/yaml/config/swapper/mode/YamlModeConfigurationSwapperTest.java
index 2848d62cd08..62993c4c82f 100644
---
a/infra/common/src/test/java/org/apache/shardingsphere/infra/yaml/config/swapper/mode/YamlModeConfigurationSwapperTest.java
+++
b/infra/common/src/test/java/org/apache/shardingsphere/infra/yaml/config/swapper/mode/YamlModeConfigurationSwapperTest.java
@@ -49,7 +49,7 @@ class YamlModeConfigurationSwapperTest {
YamlPersistRepositoryConfiguration yamlRepoConfig = new
YamlPersistRepositoryConfiguration();
yamlRepoConfig.setType(TEST_TYPE);
try (MockedStatic<TypedSPILoader> mockedLoader =
mockStatic(TypedSPILoader.class)) {
- YamlPersistRepositoryConfigurationSwapper mockSwapper =
mock(YamlPersistRepositoryConfigurationSwapper.class);
+ YamlPersistRepositoryConfigurationSwapper<?> mockSwapper =
mock(YamlPersistRepositoryConfigurationSwapper.class);
when(mockSwapper.swapToYamlConfiguration(any())).thenReturn(yamlRepoConfig);
when(mockSwapper.getType()).thenReturn(TEST_TYPE);
mockedLoader.when(() ->
TypedSPILoader.getService(YamlPersistRepositoryConfigurationSwapper.class,
TEST_TYPE)).thenReturn(mockSwapper);
@@ -68,11 +68,12 @@ class YamlModeConfigurationSwapperTest {
assertThat(actual.getType(), is(TEST_TYPE));
}
+ @SuppressWarnings("unchecked")
@Test
void assertSwapToObjectWithNotNullRepository() {
PersistRepositoryConfiguration mockRepoConfig =
mock(PersistRepositoryConfiguration.class);
try (MockedStatic<TypedSPILoader> mockedLoader =
mockStatic(TypedSPILoader.class)) {
- YamlPersistRepositoryConfigurationSwapper mockSwapper =
mock(YamlPersistRepositoryConfigurationSwapper.class);
+
YamlPersistRepositoryConfigurationSwapper<PersistRepositoryConfiguration>
mockSwapper = mock(YamlPersistRepositoryConfigurationSwapper.class);
when(mockSwapper.swapToObject(any())).thenReturn(mockRepoConfig);
when(mockSwapper.getType()).thenReturn(TEST_TYPE);
mockedLoader.when(() ->
TypedSPILoader.getService(YamlPersistRepositoryConfigurationSwapper.class,
TEST_TYPE)).thenReturn(mockSwapper);
diff --git
a/infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/ProcessRegistry.java
b/infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/ProcessRegistry.java
index 9fe26050478..45d797e99ab 100644
---
a/infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/ProcessRegistry.java
+++
b/infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/ProcessRegistry.java
@@ -110,7 +110,7 @@ public final class ProcessRegistry {
* @throws SQLException SQL exception
*/
public void kill(final String processId) throws SQLException {
- Process process = ProcessRegistry.getInstance().get(processId);
+ Process process = getInstance().get(processId);
if (null != process) {
process.kill();
}
diff --git
a/infra/expr/type/espresso/src/main/java/org/apache/shardingsphere/infra/expr/espresso/EspressoInlineExpressionParser.java
b/infra/expr/type/espresso/src/main/java/org/apache/shardingsphere/infra/expr/espresso/EspressoInlineExpressionParser.java
index a68def8f992..c574a66ce30 100644
---
a/infra/expr/type/espresso/src/main/java/org/apache/shardingsphere/infra/expr/espresso/EspressoInlineExpressionParser.java
+++
b/infra/expr/type/espresso/src/main/java/org/apache/shardingsphere/infra/expr/espresso/EspressoInlineExpressionParser.java
@@ -111,10 +111,10 @@ public final class EspressoInlineExpressionParser
implements InlineExpressionPar
private List<String> flatten(final List<ReflectValue> segments) {
List<String> result = new ArrayList<>();
for (ReflectValue each : segments) {
- if (!each.isString()) {
- result.addAll(assemblyCartesianSegments(each));
- } else {
+ if (each.isString()) {
result.add(each.as(String.class));
+ } else {
+ result.addAll(assemblyCartesianSegments(each));
}
}
return result;
diff --git
a/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/connection/CircuitBreakerConnection.java
b/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/connection/CircuitBreakerConnection.java
index 0dad66ec20c..850e0a19570 100644
---
a/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/connection/CircuitBreakerConnection.java
+++
b/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/connection/CircuitBreakerConnection.java
@@ -24,7 +24,6 @@ import
org.apache.shardingsphere.driver.state.circuit.statement.CircuitBreakerSt
import java.sql.Array;
import java.sql.Clob;
-import java.sql.Connection;
import java.sql.DatabaseMetaData;
import java.sql.PreparedStatement;
import java.sql.SQLException;
@@ -67,7 +66,7 @@ public final class CircuitBreakerConnection extends
AbstractUnsupportedOperation
@Override
public int getTransactionIsolation() {
- return Connection.TRANSACTION_NONE;
+ return TRANSACTION_NONE;
}
@Override
diff --git
a/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/metadata/CircuitBreakerDatabaseMetaData.java
b/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/metadata/CircuitBreakerDatabaseMetaData.java
index f18e68f5c6b..db2bcb2628d 100644
---
a/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/metadata/CircuitBreakerDatabaseMetaData.java
+++
b/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/metadata/CircuitBreakerDatabaseMetaData.java
@@ -845,7 +845,7 @@ public final class CircuitBreakerDatabaseMetaData
implements DatabaseMetaData {
@Override
public int getSQLStateType() {
- return DatabaseMetaData.sqlStateSQL;
+ return sqlStateSQL;
}
@Override
diff --git
a/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/resultset/CircuitBreakerResultSet.java
b/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/resultset/CircuitBreakerResultSet.java
index 679d6500103..2bb69790812 100644
---
a/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/resultset/CircuitBreakerResultSet.java
+++
b/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/resultset/CircuitBreakerResultSet.java
@@ -27,7 +27,6 @@ import java.sql.Array;
import java.sql.Blob;
import java.sql.Clob;
import java.sql.Date;
-import java.sql.ResultSet;
import java.sql.ResultSetMetaData;
import java.sql.SQLWarning;
import java.sql.SQLXML;
@@ -311,7 +310,7 @@ public final class CircuitBreakerResultSet extends
AbstractUnsupportedOperationR
@Override
public int getFetchDirection() {
- return ResultSet.FETCH_FORWARD;
+ return FETCH_FORWARD;
}
@Override
@@ -325,12 +324,12 @@ public final class CircuitBreakerResultSet extends
AbstractUnsupportedOperationR
@Override
public int getType() {
- return ResultSet.TYPE_FORWARD_ONLY;
+ return TYPE_FORWARD_ONLY;
}
@Override
public int getConcurrency() {
- return ResultSet.CONCUR_READ_ONLY;
+ return CONCUR_READ_ONLY;
}
@Override
diff --git
a/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/resultset/CircuitBreakerResultSetMetaData.java
b/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/resultset/CircuitBreakerResultSetMetaData.java
index 40a3a6bdd5c..efe3c022ecc 100644
---
a/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/resultset/CircuitBreakerResultSetMetaData.java
+++
b/jdbc/src/main/java/org/apache/shardingsphere/driver/state/circuit/resultset/CircuitBreakerResultSetMetaData.java
@@ -51,7 +51,7 @@ public final class CircuitBreakerResultSetMetaData implements
ResultSetMetaData
@Override
public int isNullable(final int column) {
- return ResultSetMetaData.columnNullable;
+ return columnNullable;
}
@Override
diff --git
a/kernel/data-pipeline/scenario/consistency-check/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java
b/kernel/data-pipeline/scenario/consistency-check/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java
index 4d7951d4b66..0e4fc7c1a2d 100644
---
a/kernel/data-pipeline/scenario/consistency-check/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java
+++
b/kernel/data-pipeline/scenario/consistency-check/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunner.java
@@ -103,10 +103,11 @@ public final class ConsistencyCheckTasksRunner implements
PipelineTasksRunner {
private final class CheckPipelineLifecycleRunnable extends
AbstractPipelineLifecycleRunnable {
+ @SuppressWarnings("unchecked")
@Override
protected void runBlocking() {
jobItemManager.persistProgress(jobItemContext);
- PipelineJobType jobType =
PipelineJobIdUtils.parseJobType(parentJobId);
+ PipelineJobType<PipelineJobConfiguration> jobType =
PipelineJobIdUtils.parseJobType(parentJobId);
PipelineJobConfiguration parentJobConfig = new
PipelineJobConfigurationManager(jobType.getOption()).getJobConfiguration(parentJobId);
try {
PipelineProcessConfiguration processConfig =
PipelineProcessConfigurationUtils.fillInDefaultValue(
diff --git
a/kernel/data-pipeline/scenario/consistency-check/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunnerTest.java
b/kernel/data-pipeline/scenario/consistency-check/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunnerTest.java
index 28373cf203b..77586e173d3 100644
---
a/kernel/data-pipeline/scenario/consistency-check/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunnerTest.java
+++
b/kernel/data-pipeline/scenario/consistency-check/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/task/ConsistencyCheckTasksRunnerTest.java
@@ -137,6 +137,7 @@ class ConsistencyCheckTasksRunnerTest {
verify(checkExecutor).stop();
}
+ @SuppressWarnings({"unchecked", "rawtypes"})
@Test
void assertRunBlockingPersistResultWhenNotStopping() throws
ReflectiveOperationException {
ConsistencyCheckJobItemContext jobItemContext = createJobItemContext();
@@ -164,7 +165,7 @@ class ConsistencyCheckTasksRunnerTest {
when(governanceFacade.getJobFacade()).thenReturn(jobFacade);
when(jobFacade.getCheck()).thenReturn(checkRepository);
try (
- MockedConstruction<PipelineJobConfigurationManager>
mockedConstruction = mockConstruction(PipelineJobConfigurationManager.class,
+ MockedConstruction<PipelineJobConfigurationManager> ignore =
mockConstruction(PipelineJobConfigurationManager.class,
(mock, context) ->
when(mock.getJobConfiguration(PARENT_JOB_ID)).thenReturn(parentJobConfig));
MockedStatic<PipelineProcessConfigurationUtils>
processConfigMocked = mockStatic(PipelineProcessConfigurationUtils.class)) {
processConfigMocked.when(() ->
PipelineProcessConfigurationUtils.fillInDefaultValue(processConfig)).thenReturn(processConfig);
@@ -177,6 +178,7 @@ class ConsistencyCheckTasksRunnerTest {
}
}
+ @SuppressWarnings({"unchecked", "rawtypes"})
@Test
void assertRunBlockingSkipPersistWhenStopping() throws
ReflectiveOperationException {
ConsistencyCheckJobItemContext jobItemContext = createJobItemContext();
@@ -201,7 +203,7 @@ class ConsistencyCheckTasksRunnerTest {
when(checker.check(jobItemContext.getJobConfig().getAlgorithmTypeName(),
jobItemContext.getJobConfig().getAlgorithmProps())).thenReturn(checkResult);
PipelineJobCheckGovernanceRepository checkRepository =
mock(PipelineJobCheckGovernanceRepository.class);
try (
- MockedConstruction<PipelineJobConfigurationManager>
mockedConstruction = mockConstruction(PipelineJobConfigurationManager.class,
+ MockedConstruction<PipelineJobConfigurationManager> ignored =
mockConstruction(PipelineJobConfigurationManager.class,
(mock, context) ->
when(mock.getJobConfiguration(PARENT_JOB_ID)).thenReturn(parentJobConfig));
MockedStatic<PipelineProcessConfigurationUtils>
processConfigMocked = mockStatic(PipelineProcessConfigurationUtils.class)) {
processConfigMocked.when(() ->
PipelineProcessConfigurationUtils.fillInDefaultValue(processConfig)).thenReturn(processConfig);
@@ -214,6 +216,7 @@ class ConsistencyCheckTasksRunnerTest {
}
}
+ @SuppressWarnings("unchecked")
@Test
void assertOnSuccessWhenStopping() throws ReflectiveOperationException {
ConsistencyCheckJobItemContext jobItemContext = createJobItemContext();
@@ -230,6 +233,7 @@ class ConsistencyCheckTasksRunnerTest {
verifyNoInteractions(jobItemManager);
}
+ @SuppressWarnings("unchecked")
@Test
void assertOnSuccessUpdateToFinished() throws ReflectiveOperationException
{
ConsistencyCheckJobItemContext jobItemContext = createJobItemContext();
@@ -255,6 +259,7 @@ class ConsistencyCheckTasksRunnerTest {
verify(jobManager).stop(CHECK_JOB_ID);
}
+ @SuppressWarnings("unchecked")
@Test
void assertOnSuccessUpdateToFailure() throws ReflectiveOperationException {
ConsistencyCheckJobItemContext jobItemContext = createJobItemContext();
diff --git
a/kernel/transaction/core/src/main/java/org/apache/shardingsphere/transaction/ConnectionTransaction.java
b/kernel/transaction/core/src/main/java/org/apache/shardingsphere/transaction/ConnectionTransaction.java
index d6a3663433b..3140c6aafe0 100644
---
a/kernel/transaction/core/src/main/java/org/apache/shardingsphere/transaction/ConnectionTransaction.java
+++
b/kernel/transaction/core/src/main/java/org/apache/shardingsphere/transaction/ConnectionTransaction.java
@@ -46,7 +46,7 @@ public final class ConnectionTransaction {
if (transactionContext.getTransactionManager().isPresent()) {
distributedTransactionManager =
(ShardingSphereDistributedTransactionManager)
transactionContext.getTransactionManager().get();
} else {
- distributedTransactionManager = TransactionType.LOCAL ==
this.transactionType ? null :
rule.getResource().getTransactionManager(rule.getDefaultType());
+ distributedTransactionManager = TransactionType.LOCAL ==
transactionType ? null :
rule.getResource().getTransactionManager(rule.getDefaultType());
}
}
diff --git
a/kernel/transaction/type/xa/provider/narayana/src/main/java/org/apache/shardingsphere/transaction/xa/narayana/manager/DataSourceXAResourceRecoveryHelper.java
b/kernel/transaction/type/xa/provider/narayana/src/main/java/org/apache/shardingsphere/transaction/xa/narayana/manager/DataSourceXAResourceRecoveryHelper.java
index 8d935cdc778..d40fb7de6ef 100644
---
a/kernel/transaction/type/xa/provider/narayana/src/main/java/org/apache/shardingsphere/transaction/xa/narayana/manager/DataSourceXAResourceRecoveryHelper.java
+++
b/kernel/transaction/type/xa/provider/narayana/src/main/java/org/apache/shardingsphere/transaction/xa/narayana/manager/DataSourceXAResourceRecoveryHelper.java
@@ -103,7 +103,7 @@ public final class DataSourceXAResourceRecoveryHelper
implements XAResourceRecov
try {
return getDelegate().recover(flag);
} finally {
- if (flag == XAResource.TMENDRSCAN) {
+ if (flag == TMENDRSCAN) {
disconnect();
}
}
diff --git
a/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/persist/metadata/DatabaseMetaDataPersistFacadeTest.java
b/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/persist/metadata/DatabaseMetaDataPersistFacadeTest.java
index 35005a575b4..939087c0ecb 100644
---
a/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/persist/metadata/DatabaseMetaDataPersistFacadeTest.java
+++
b/mode/core/src/test/java/org/apache/shardingsphere/mode/metadata/persist/metadata/DatabaseMetaDataPersistFacadeTest.java
@@ -22,7 +22,6 @@ import
org.apache.shardingsphere.infra.metadata.database.ShardingSphereDatabase;
import
org.apache.shardingsphere.infra.metadata.database.schema.manager.GenericSchemaManager;
import
org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereSchema;
import
org.apache.shardingsphere.mode.metadata.persist.metadata.service.SchemaMetaDataPersistService;
-import
org.apache.shardingsphere.mode.metadata.persist.metadata.service.TableMetaDataPersistEnabledService;
import
org.apache.shardingsphere.mode.persist.service.TableMetaDataPersistService;
import
org.apache.shardingsphere.test.infra.framework.extension.mock.AutoMockExtension;
import
org.apache.shardingsphere.test.infra.framework.extension.mock.StaticMockSettings;
@@ -51,7 +50,7 @@ class DatabaseMetaDataPersistFacadeTest {
private SchemaMetaDataPersistService schemaMetaDataService;
@Mock
- private TableMetaDataPersistService tableMetaDataService =
mock(TableMetaDataPersistEnabledService.class);
+ private TableMetaDataPersistService tableMetaDataService;
@BeforeEach
void setUp() throws ReflectiveOperationException {
diff --git
a/mode/node/src/test/java/org/apache/shardingsphere/mode/node/rule/tuple/fixture/node/YamlNodeRuleConfiguration.java
b/mode/node/src/test/java/org/apache/shardingsphere/mode/node/rule/tuple/fixture/node/YamlNodeRuleConfiguration.java
index 32560a4015e..7dc3cb61b5f 100644
---
a/mode/node/src/test/java/org/apache/shardingsphere/mode/node/rule/tuple/fixture/node/YamlNodeRuleConfiguration.java
+++
b/mode/node/src/test/java/org/apache/shardingsphere/mode/node/rule/tuple/fixture/node/YamlNodeRuleConfiguration.java
@@ -32,7 +32,7 @@ import java.util.HashMap;
import java.util.LinkedList;
import java.util.Map;
-@RuleNodeTupleEntity(value = "node")
+@RuleNodeTupleEntity("node")
@Getter
@Setter
public final class YamlNodeRuleConfiguration implements YamlRuleConfiguration {
diff --git
a/mode/type/cluster/repository/provider/zookeeper/src/test/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/ZookeeperRepositoryTest.java
b/mode/type/cluster/repository/provider/zookeeper/src/test/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/ZookeeperRepositoryTest.java
index 035f2d32e67..9a2a68e9009 100644
---
a/mode/type/cluster/repository/provider/zookeeper/src/test/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/ZookeeperRepositoryTest.java
+++
b/mode/type/cluster/repository/provider/zookeeper/src/test/java/org/apache/shardingsphere/mode/repository/cluster/zookeeper/ZookeeperRepositoryTest.java
@@ -123,6 +123,7 @@ class ZookeeperRepositoryTest {
when(client.blockUntilConnected(anyInt(),
eq(TimeUnit.MILLISECONDS))).thenReturn(true);
}
+ @SuppressWarnings("unchecked")
private void mockBuilder() {
when(client.checkExists()).thenReturn(existsBuilder);
when(client.create()).thenReturn(createBuilder);
diff --git
a/parser/sql/engine/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/engine/doris/visitor/statement/type/DorisDALStatementVisitor.java
b/parser/sql/engine/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/engine/doris/visitor/statement/type/DorisDALStatementVisitor.java
index 9f586bccc64..776d14ab068 100644
---
a/parser/sql/engine/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/engine/doris/visitor/statement/type/DorisDALStatementVisitor.java
+++
b/parser/sql/engine/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/engine/doris/visitor/statement/type/DorisDALStatementVisitor.java
@@ -381,6 +381,7 @@ public final class DorisDALStatementVisitor extends
DorisStatementVisitor implem
return new AnalyzeTableStatement(getDatabaseType(),
((CollectionValue<SimpleTableSegment>) visit(ctx.tableList())).getValue());
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitCacheIndex(final CacheIndexContext ctx) {
IdentifierValue name = null == ctx.DEFAULT() ? (IdentifierValue)
visit(ctx.identifier()) : new IdentifierValue(ctx.DEFAULT().getText());
@@ -417,6 +418,7 @@ public final class DorisDALStatementVisitor extends
DorisStatementVisitor implem
return new PartitionSegment(ctx.getStart().getStartIndex(),
ctx.getStop().getStopIndex(), (IdentifierValue) visit(ctx.identifier()));
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitChecksumTable(final ChecksumTableContext ctx) {
return new MySQLChecksumTableStatement(getDatabaseType(),
((CollectionValue<SimpleTableSegment>) visit(ctx.tableList())).getValue());
@@ -442,6 +444,7 @@ public final class DorisDALStatementVisitor extends
DorisStatementVisitor implem
return new MySQLLoadIndexInfoStatement(getDatabaseType(),
ctx.loadTableIndexList().stream().map(each -> (LoadTableIndexSegment)
visit(each)).collect(Collectors.toList()));
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitLoadTableIndexList(final LoadTableIndexListContext
ctx) {
LoadTableIndexSegment result = new
LoadTableIndexSegment(ctx.getStart().getStartIndex(),
ctx.getStop().getStopIndex(), (SimpleTableSegment) visit(ctx.tableName()));
@@ -883,6 +886,7 @@ public final class DorisDALStatementVisitor extends
DorisStatementVisitor implem
return new MySQLSetResourceGroupStatement(getDatabaseType(),
((IdentifierValue) visit(ctx.groupName())).getValue());
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitCheckTable(final CheckTableContext ctx) {
return new MySQLCheckTableStatement(getDatabaseType(),
((CollectionValue<SimpleTableSegment>) visit(ctx.tableList())).getValue());
diff --git
a/parser/sql/engine/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/engine/mysql/visitor/statement/type/MySQLDALStatementVisitor.java
b/parser/sql/engine/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/engine/mysql/visitor/statement/type/MySQLDALStatementVisitor.java
index 9d415852fda..80ae89db8c9 100644
---
a/parser/sql/engine/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/engine/mysql/visitor/statement/type/MySQLDALStatementVisitor.java
+++
b/parser/sql/engine/dialect/mysql/src/main/java/org/apache/shardingsphere/sql/parser/engine/mysql/visitor/statement/type/MySQLDALStatementVisitor.java
@@ -379,6 +379,7 @@ public final class MySQLDALStatementVisitor extends
MySQLStatementVisitor implem
return new AnalyzeTableStatement(getDatabaseType(),
((CollectionValue<SimpleTableSegment>) visit(ctx.tableList())).getValue());
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitCacheIndex(final CacheIndexContext ctx) {
IdentifierValue name = null == ctx.DEFAULT() ? (IdentifierValue)
visit(ctx.identifier()) : new IdentifierValue(ctx.DEFAULT().getText());
@@ -415,6 +416,7 @@ public final class MySQLDALStatementVisitor extends
MySQLStatementVisitor implem
return new PartitionSegment(ctx.getStart().getStartIndex(),
ctx.getStop().getStopIndex(), (IdentifierValue) visit(ctx.identifier()));
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitChecksumTable(final ChecksumTableContext ctx) {
return new MySQLChecksumTableStatement(getDatabaseType(),
((CollectionValue<SimpleTableSegment>) visit(ctx.tableList())).getValue());
@@ -453,6 +455,7 @@ public final class MySQLDALStatementVisitor extends
MySQLStatementVisitor implem
return new MySQLLoadIndexInfoStatement(getDatabaseType(),
ctx.loadTableIndexList().stream().map(each -> (LoadTableIndexSegment)
visit(each)).collect(Collectors.toList()));
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitLoadTableIndexList(final LoadTableIndexListContext
ctx) {
LoadTableIndexSegment result = new
LoadTableIndexSegment(ctx.getStart().getStartIndex(),
ctx.getStop().getStopIndex(), (SimpleTableSegment) visit(ctx.tableName()));
@@ -892,6 +895,7 @@ public final class MySQLDALStatementVisitor extends
MySQLStatementVisitor implem
return new MySQLSetResourceGroupStatement(getDatabaseType(),
((IdentifierValue) visit(ctx.groupName())).getValue());
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitCheckTable(final CheckTableContext ctx) {
return new MySQLCheckTableStatement(getDatabaseType(),
((CollectionValue<SimpleTableSegment>) visit(ctx.tableList())).getValue());
diff --git
a/parser/sql/engine/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/engine/oracle/visitor/statement/type/OracleDMLStatementVisitor.java
b/parser/sql/engine/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/engine/oracle/visitor/statement/type/OracleDMLStatementVisitor.java
index a434a219e7f..93cde511a6e 100644
---
a/parser/sql/engine/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/engine/oracle/visitor/statement/type/OracleDMLStatementVisitor.java
+++
b/parser/sql/engine/dialect/oracle/src/main/java/org/apache/shardingsphere/sql/parser/engine/oracle/visitor/statement/type/OracleDMLStatementVisitor.java
@@ -479,6 +479,7 @@ public final class OracleDMLStatementVisitor extends
OracleStatementVisitor impl
return result;
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitPivotClause(final PivotClauseContext ctx) {
Collection<ColumnSegment> pivotInColumns = new LinkedList<>();
@@ -493,6 +494,7 @@ public final class OracleDMLStatementVisitor extends
OracleStatementVisitor impl
return new PivotSegment(ctx.getStart().getStartIndex(),
ctx.getStop().getStopIndex(), ((CollectionValue<ColumnSegment>)
visit(ctx.pivotForClause().columnNames())).getValue(), pivotInColumns);
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitUnpivotClause(final UnpivotClauseContext ctx) {
Collection<ColumnSegment> unpivotInColumns = new LinkedList<>();
diff --git
a/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/PostgreSQLStatementVisitor.java
b/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/PostgreSQLStatementVisitor.java
index 4b5f92cd12e..7ef2e8bbf9e 100644
---
a/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/PostgreSQLStatementVisitor.java
+++
b/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/PostgreSQLStatementVisitor.java
@@ -730,6 +730,7 @@ public abstract class PostgreSQLStatementVisitor extends
PostgreSQLStatementPars
return result;
}
+ @SuppressWarnings({"rawtypes", "unchecked"})
@Override
public ASTNode visitQualifiedNameList(final QualifiedNameListContext ctx) {
CollectionValue<SimpleTableSegment> result = new CollectionValue<>();
@@ -761,6 +762,7 @@ public abstract class PostgreSQLStatementVisitor extends
PostgreSQLStatementPars
return new SimpleTableSegment(new
TableNameSegment(ctx.colId().start.getStartIndex(),
ctx.colId().stop.getStopIndex(), new IdentifierValue(ctx.colId().getText())));
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitInsertRest(final InsertRestContext ctx) {
InsertStatement result = new InsertStatement(databaseType);
@@ -782,6 +784,7 @@ public abstract class PostgreSQLStatementVisitor extends
PostgreSQLStatementPars
return result;
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitInsertColumnList(final InsertColumnListContext ctx) {
CollectionValue<ColumnSegment> result = new CollectionValue<>();
diff --git
a/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/type/PostgreSQLDMLStatementVisitor.java
b/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/type/PostgreSQLDMLStatementVisitor.java
index 47173628784..6aca2eb1cef 100644
---
a/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/type/PostgreSQLDMLStatementVisitor.java
+++
b/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/type/PostgreSQLDMLStatementVisitor.java
@@ -95,6 +95,7 @@ public final class PostgreSQLDMLStatementVisitor extends
PostgreSQLStatementVisi
return visit(ctx.copyWithTableBinary());
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitCopyWithTableOrQuery(final CopyWithTableOrQueryContext
ctx) {
return new PostgreSQLCopyStatement(getDatabaseType(), null ==
ctx.qualifiedName() ? null : (SimpleTableSegment) visit(ctx.qualifiedName()),
@@ -116,6 +117,7 @@ public final class PostgreSQLDMLStatementVisitor extends
PostgreSQLStatementVisi
return result;
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitCopyWithTableOrQueryBinaryCsv(final
CopyWithTableOrQueryBinaryCsvContext ctx) {
return new PostgreSQLCopyStatement(getDatabaseType(), null ==
ctx.qualifiedName() ? null : (SimpleTableSegment) visit(ctx.qualifiedName()),
diff --git
a/parser/sql/engine/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/engine/sqlserver/visitor/statement/SQLServerStatementVisitor.java
b/parser/sql/engine/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/engine/sqlserver/visitor/statement/SQLServerStatementVisitor.java
index 2521877b0d9..4de43827be3 100644
---
a/parser/sql/engine/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/engine/sqlserver/visitor/statement/SQLServerStatementVisitor.java
+++
b/parser/sql/engine/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/engine/sqlserver/visitor/statement/SQLServerStatementVisitor.java
@@ -1248,6 +1248,7 @@ public abstract class SQLServerStatementVisitor extends
SQLServerStatementBaseVi
return result;
}
+ @SuppressWarnings("unchecked")
private Collection<CommonTableExpressionSegment>
getCommonTableExpressionSegmentsUsingCteClauseSet(final CteClauseSetContext
ctx) {
Collection<CommonTableExpressionSegment> result = new LinkedList<>();
for (CteClauseContext each : ctx.cteClause()) {
@@ -1571,6 +1572,7 @@ public abstract class SQLServerStatementVisitor extends
SQLServerStatementBaseVi
return result;
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitOutputClause(final OutputClauseContext ctx) {
OutputSegment result = new OutputSegment(ctx.start.getStartIndex(),
ctx.stop.getStopIndex());
@@ -1998,6 +2000,7 @@ public abstract class SQLServerStatementVisitor extends
SQLServerStatementBaseVi
return result;
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitPivotClause(final PivotClauseContext ctx) {
String pivotType = null == ctx.PIVOT() ? "UNPIVOT" : "PIVOT";
@@ -2099,6 +2102,7 @@ public abstract class SQLServerStatementVisitor extends
SQLServerStatementBaseVi
return visit(ctx.aggregationClause());
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitCreateTableAsSelectClause(final
CreateTableAsSelectClauseContext ctx) {
CreateTableStatement result = new CreateTableStatement(databaseType);
diff --git
a/parser/sql/engine/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/engine/sqlserver/visitor/statement/type/SQLServerDCLStatementVisitor.java
b/parser/sql/engine/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/engine/sqlserver/visitor/statement/type/SQLServerDCLStatementVisitor.java
index 6e3af427904..e0cfa4875fc 100644
---
a/parser/sql/engine/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/engine/sqlserver/visitor/statement/type/SQLServerDCLStatementVisitor.java
+++
b/parser/sql/engine/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/engine/sqlserver/visitor/statement/type/SQLServerDCLStatementVisitor.java
@@ -81,6 +81,7 @@ public final class SQLServerDCLStatementVisitor extends
SQLServerStatementVisito
super(databaseType);
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitGrant(final GrantContext ctx) {
SQLServerGrantStatement result = new
SQLServerGrantStatement(getDatabaseType());
@@ -98,6 +99,7 @@ public final class SQLServerDCLStatementVisitor extends
SQLServerStatementVisito
return result;
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitRevoke(final RevokeContext ctx) {
SQLServerRevokeStatement result = new
SQLServerRevokeStatement(getDatabaseType());
@@ -183,6 +185,7 @@ public final class SQLServerDCLStatementVisitor extends
SQLServerStatementVisito
return new AlterUserStatement(getDatabaseType(), (UserSegment)
visit(ctx.userName()));
}
+ @SuppressWarnings("unchecked")
@Override
public ASTNode visitDeny(final DenyContext ctx) {
SQLServerDenyUserStatement result = new
SQLServerDenyUserStatement(getDatabaseType());
diff --git
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/item/AggregationProjectionSegment.java
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/item/AggregationProjectionSegment.java
index 667a5ef89db..61e8ee3f3b4 100644
---
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/item/AggregationProjectionSegment.java
+++
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/segment/dml/item/AggregationProjectionSegment.java
@@ -55,7 +55,7 @@ public class AggregationProjectionSegment implements
ProjectionSegment, AliasAva
this.stopIndex = stopIndex;
this.type = type;
this.expression = expression;
- this.separator = null;
+ separator = null;
}
public AggregationProjectionSegment(final int startIndex, final int
stopIndex, final AggregationType type, final String expression, final String
separator) {
diff --git
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/value/literal/impl/StringLiteralValue.java
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/value/literal/impl/StringLiteralValue.java
index ac7db76be22..a6b98f9e661 100644
---
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/value/literal/impl/StringLiteralValue.java
+++
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/value/literal/impl/StringLiteralValue.java
@@ -39,6 +39,6 @@ public final class StringLiteralValue implements
LiteralValue<String> {
for (StringLiteralValue each : stringLiteralValues) {
result.append(each.getValue());
}
- this.value = result.toString();
+ value = result.toString();
}
}
diff --git
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java
index 54323ac1b0a..6db4b6e00f4 100644
---
a/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java
+++
b/proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/connector/jdbc/datasource/fixture/CallTimeRecordDataSource.java
@@ -224,7 +224,7 @@ public final class CallTimeRecordDataSource implements
DataSource, AutoCloseable
@Override
public int getTransactionIsolation() {
- return Connection.TRANSACTION_NONE;
+ return TRANSACTION_NONE;
}
@Override
diff --git
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/MigrationJobAPITest.java
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/MigrationJobAPITest.java
index ac760942004..139d4f2b181 100644
---
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/MigrationJobAPITest.java
+++
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/data/pipeline/scenario/migration/api/MigrationJobAPITest.java
@@ -187,6 +187,7 @@ class MigrationJobAPITest {
assertThat(jobProgressMap.size(), is(1));
}
+ @SuppressWarnings("unchecked")
@Test
void assertDataConsistencyCheck() {
MigrationJobConfiguration jobConfig =
JobConfigurationBuilder.createJobConfiguration();
diff --git
a/test/it/spi/src/test/java/org/apache/shardingsphere/test/it/spi/SPIMatchedCheckIT.java
b/test/it/spi/src/test/java/org/apache/shardingsphere/test/it/spi/SPIMatchedCheckIT.java
index ca3ca1b7414..8d4ab88780c 100644
---
a/test/it/spi/src/test/java/org/apache/shardingsphere/test/it/spi/SPIMatchedCheckIT.java
+++
b/test/it/spi/src/test/java/org/apache/shardingsphere/test/it/spi/SPIMatchedCheckIT.java
@@ -67,7 +67,7 @@ class SPIMatchedCheckIT {
}
private Map<Path, Collection<String>> listAndParseSPIs(final URI
servicesURI) throws IOException {
- if (servicesURI.getScheme().equals("jar")) {
+ if ("jar".equals(servicesURI.getScheme())) {
try (FileSystem fileSystem =
FileSystems.newFileSystem(servicesURI, Collections.emptyMap())) {
return
parseSPIImplNames(listSPIDefinePaths(fileSystem.getPath(SERVICES_PATH)));
}
