This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new ec204cb3d51 Remove useless param of EncryptGeneratorFixtureBuilder
(#37130)
ec204cb3d51 is described below
commit ec204cb3d5146ec642a9b86161aa12a48e11cdac
Author: Liang Zhang <[email protected]>
AuthorDate: Mon Nov 17 22:47:46 2025 +0800
Remove useless param of EncryptGeneratorFixtureBuilder (#37130)
---
.../firebird/packet/command/query/blob/FirebirdBlobRegistry.java | 6 +++++-
.../token/generator/fixture/EncryptGeneratorFixtureBuilder.java | 3 +--
.../generator/insert/EncryptInsertCipherNameTokenGeneratorTest.java | 2 +-
.../insert/EncryptInsertDefaultColumnsTokenGeneratorTest.java | 2 +-
4 files changed, 8 insertions(+), 5 deletions(-)
diff --git
a/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/blob/FirebirdBlobRegistry.java
b/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/blob/FirebirdBlobRegistry.java
index 329826e6c44..752eb104cfe 100644
---
a/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/blob/FirebirdBlobRegistry.java
+++
b/database/protocol/dialect/firebird/src/main/java/org/apache/shardingsphere/database/protocol/firebird/packet/command/query/blob/FirebirdBlobRegistry.java
@@ -19,14 +19,18 @@ package
org.apache.shardingsphere.database.protocol.firebird.packet.command.quer
import io.netty.buffer.ByteBuf;
import io.netty.buffer.ByteBufAllocator;
-import java.nio.charset.Charset;
+import lombok.AccessLevel;
import lombok.Getter;
+import lombok.NoArgsConstructor;
import lombok.Setter;
import
org.apache.shardingsphere.database.protocol.firebird.payload.FirebirdPacketPayload;
+import java.nio.charset.Charset;
+
/**
* Registry for the BLOB segment.
*/
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
public final class FirebirdBlobRegistry {
@Getter
diff --git
a/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/fixture/EncryptGeneratorFixtureBuilder.java
b/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/fixture/EncryptGeneratorFixtureBuilder.java
index 8562f9bb51c..510bbd54db9 100644
---
a/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/fixture/EncryptGeneratorFixtureBuilder.java
+++
b/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/fixture/EncryptGeneratorFixtureBuilder.java
@@ -211,11 +211,10 @@ public final class EncryptGeneratorFixtureBuilder {
/**
* Create insert select statement context.
*
- * @param params parameters
* @param containsInsertColumns contains insert columns
* @return created insert select statement context
*/
- public static InsertStatementContext
createInsertSelectStatementContext(final List<Object> params, final boolean
containsInsertColumns) {
+ public static InsertStatementContext
createInsertSelectStatementContext(final boolean containsInsertColumns) {
ShardingSphereDatabase database = mock(ShardingSphereDatabase.class,
RETURNS_DEEP_STUBS);
when(database.getName()).thenReturn("foo_db");
ShardingSphereSchema schema = mock(ShardingSphereSchema.class);
diff --git
a/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/insert/EncryptInsertCipherNameTokenGeneratorTest.java
b/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/insert/EncryptInsertCipherNameTokenGeneratorTest.java
index bfff5d1de76..940ef569b01 100644
---
a/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/insert/EncryptInsertCipherNameTokenGeneratorTest.java
+++
b/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/insert/EncryptInsertCipherNameTokenGeneratorTest.java
@@ -58,6 +58,6 @@ class EncryptInsertCipherNameTokenGeneratorTest {
@Test
void
assertGenerateSQLTokensWhenInsertColumnsUseDifferentEncryptorWithSelectProjection()
{
- assertThrows(UnsupportedSQLOperationException.class, () ->
generator.generateSQLTokens(EncryptGeneratorFixtureBuilder.createInsertSelectStatementContext(Collections.emptyList(),
true)));
+ assertThrows(UnsupportedSQLOperationException.class, () ->
generator.generateSQLTokens(EncryptGeneratorFixtureBuilder.createInsertSelectStatementContext(true)));
}
}
diff --git
a/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/insert/EncryptInsertDefaultColumnsTokenGeneratorTest.java
b/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/insert/EncryptInsertDefaultColumnsTokenGeneratorTest.java
index 774903a37f8..dc9ebd8df19 100644
---
a/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/insert/EncryptInsertDefaultColumnsTokenGeneratorTest.java
+++
b/features/encrypt/core/src/test/java/org/apache/shardingsphere/encrypt/rewrite/token/generator/insert/EncryptInsertDefaultColumnsTokenGeneratorTest.java
@@ -60,6 +60,6 @@ class EncryptInsertDefaultColumnsTokenGeneratorTest {
@Test
void
assertGenerateSQLTokensWhenInsertColumnsUseDifferentEncryptorWithSelectProjection()
{
generator.setPreviousSQLTokens(EncryptGeneratorFixtureBuilder.getPreviousSQLTokens());
- assertThrows(UnsupportedSQLOperationException.class, () ->
generator.generateSQLToken(EncryptGeneratorFixtureBuilder.createInsertSelectStatementContext(Collections.emptyList(),
false)));
+ assertThrows(UnsupportedSQLOperationException.class, () ->
generator.generateSQLToken(EncryptGeneratorFixtureBuilder.createInsertSelectStatementContext(false)));
}
}
