This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new c144dbe8c9c Add test coverage for TemporaryConfigurationPropertyKey
and TemporaryConfigurationProperties (#36922)
c144dbe8c9c is described below
commit c144dbe8c9c51ec992b39f8613c968fd6b26b797
Author: Liang Zhang <[email protected]>
AuthorDate: Wed Oct 22 20:45:55 2025 +0800
Add test coverage for TemporaryConfigurationPropertyKey and
TemporaryConfigurationProperties (#36922)
- Create TemporaryConfigurationPropertyKeyTest to validate enum key names
and mappings
- Create TemporaryConfigurationPropertiesTest to test property value
retrieval and defaults
- Follow existing test patterns from ConfigurationPropertyKeyTest and
ConfigurationPropertiesTest
- Cover all enum values: PROXY_META_DATA_COLLECTOR_ENABLED,
SYSTEM_SCHEMA_METADATA_ASSEMBLY_ENABLED, PROXY_META_DATA_COLLECTOR_CRON
- Test both custom properties and default value scenarios
- Apply Spotless formatting for code consistency
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude <[email protected]>
---
.../TemporaryConfigurationPropertiesTest.java | 55 ++++++++++++++++++++++
.../TemporaryConfigurationPropertyKeyTest.java | 37 +++++++++++++++
2 files changed, 92 insertions(+)
diff --git
a/infra/common/src/test/java/org/apache/shardingsphere/infra/config/props/temporary/TemporaryConfigurationPropertiesTest.java
b/infra/common/src/test/java/org/apache/shardingsphere/infra/config/props/temporary/TemporaryConfigurationPropertiesTest.java
new file mode 100644
index 00000000000..f4d50d16457
--- /dev/null
+++
b/infra/common/src/test/java/org/apache/shardingsphere/infra/config/props/temporary/TemporaryConfigurationPropertiesTest.java
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.config.props.temporary;
+
+import org.apache.shardingsphere.infra.util.props.PropertiesBuilder;
+import org.apache.shardingsphere.infra.util.props.PropertiesBuilder.Property;
+import org.junit.jupiter.api.Test;
+
+import java.util.Properties;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+class TemporaryConfigurationPropertiesTest {
+
+ @Test
+ void assertGetValue() {
+ TemporaryConfigurationProperties actual = new
TemporaryConfigurationProperties(createProperties());
+ assertTrue((Boolean)
actual.getValue(TemporaryConfigurationPropertyKey.PROXY_META_DATA_COLLECTOR_ENABLED));
+ assertFalse((Boolean)
actual.getValue(TemporaryConfigurationPropertyKey.SYSTEM_SCHEMA_METADATA_ASSEMBLY_ENABLED));
+
assertThat(actual.getValue(TemporaryConfigurationPropertyKey.PROXY_META_DATA_COLLECTOR_CRON),
is("0 0/5 * * * ?"));
+ }
+
+ private Properties createProperties() {
+ return PropertiesBuilder.build(
+ new
Property(TemporaryConfigurationPropertyKey.PROXY_META_DATA_COLLECTOR_ENABLED.getKey(),
Boolean.TRUE.toString()),
+ new
Property(TemporaryConfigurationPropertyKey.SYSTEM_SCHEMA_METADATA_ASSEMBLY_ENABLED.getKey(),
Boolean.FALSE.toString()),
+ new
Property(TemporaryConfigurationPropertyKey.PROXY_META_DATA_COLLECTOR_CRON.getKey(),
"0 0/5 * * * ?"));
+ }
+
+ @Test
+ void assertGetDefaultValue() {
+ TemporaryConfigurationProperties actual = new
TemporaryConfigurationProperties(new Properties());
+ assertFalse((Boolean)
actual.getValue(TemporaryConfigurationPropertyKey.PROXY_META_DATA_COLLECTOR_ENABLED));
+ assertTrue((Boolean)
actual.getValue(TemporaryConfigurationPropertyKey.SYSTEM_SCHEMA_METADATA_ASSEMBLY_ENABLED));
+
assertThat(actual.getValue(TemporaryConfigurationPropertyKey.PROXY_META_DATA_COLLECTOR_CRON),
is("0 0/1 * * * ?"));
+ }
+}
diff --git
a/infra/common/src/test/java/org/apache/shardingsphere/infra/config/props/temporary/TemporaryConfigurationPropertyKeyTest.java
b/infra/common/src/test/java/org/apache/shardingsphere/infra/config/props/temporary/TemporaryConfigurationPropertyKeyTest.java
new file mode 100644
index 00000000000..e0acd42ab4d
--- /dev/null
+++
b/infra/common/src/test/java/org/apache/shardingsphere/infra/config/props/temporary/TemporaryConfigurationPropertyKeyTest.java
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.config.props.temporary;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collection;
+
+import static org.hamcrest.CoreMatchers.is;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+class TemporaryConfigurationPropertyKeyTest {
+
+ @Test
+ void assertKeyNames() {
+ Collection<String> keyNames =
TemporaryConfigurationPropertyKey.getKeyNames();
+ assertThat(keyNames.size(),
is(TemporaryConfigurationPropertyKey.values().length));
+ keyNames.forEach(each ->
assertNotNull(TemporaryConfigurationPropertyKey.valueOf(each)));
+ keyNames.forEach(each -> assertThat(each.toLowerCase().replace("_",
"-"), is(TemporaryConfigurationPropertyKey.valueOf(each).getKey())));
+ }
+}
