This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push: new 232c671ff67 Remove useless cache on DatabaseTypeRegistry (#35191) 232c671ff67 is described below commit 232c671ff678f66b4d1960cffe33135a657b13c1 Author: Liang Zhang <zhangli...@apache.org> AuthorDate: Mon Apr 14 00:24:16 2025 +0800 Remove useless cache on DatabaseTypeRegistry (#35191) --- .../infra/database/core/type/DatabaseTypeRegistry.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/infra/database/core/src/main/java/org/apache/shardingsphere/infra/database/core/type/DatabaseTypeRegistry.java b/infra/database/core/src/main/java/org/apache/shardingsphere/infra/database/core/type/DatabaseTypeRegistry.java index 01b7d8b5dbc..af79f0077e2 100644 --- a/infra/database/core/src/main/java/org/apache/shardingsphere/infra/database/core/type/DatabaseTypeRegistry.java +++ b/infra/database/core/src/main/java/org/apache/shardingsphere/infra/database/core/type/DatabaseTypeRegistry.java @@ -23,8 +23,6 @@ import org.apache.shardingsphere.infra.database.core.spi.DatabaseTypedSPILoader; import org.apache.shardingsphere.infra.spi.ShardingSphereServiceLoader; import java.util.Collection; -import java.util.Map; -import java.util.concurrent.ConcurrentHashMap; import java.util.stream.Collectors; /** @@ -32,8 +30,6 @@ import java.util.stream.Collectors; */ public final class DatabaseTypeRegistry { - private static final Map<DatabaseType, DialectDatabaseMetaData> REGISTERED_META_DATA = new ConcurrentHashMap<>(); - private final DatabaseType databaseType; @Getter @@ -41,10 +37,7 @@ public final class DatabaseTypeRegistry { public DatabaseTypeRegistry(final DatabaseType databaseType) { this.databaseType = databaseType; - if (!REGISTERED_META_DATA.containsKey(databaseType)) { - REGISTERED_META_DATA.put(databaseType, DatabaseTypedSPILoader.getService(DialectDatabaseMetaData.class, databaseType)); - } - dialectDatabaseMetaData = REGISTERED_META_DATA.get(databaseType); + dialectDatabaseMetaData = DatabaseTypedSPILoader.getService(DialectDatabaseMetaData.class, databaseType); } /**