strongduanmu commented on code in PR #35022:
URL: https://github.com/apache/shardingsphere/pull/35022#discussion_r2000538335
##########
infra/database/type/opengauss/src/main/java/org/apache/shardingsphere/infra/database/opengauss/metadata/data/loader/OpenGaussMetaDataLoader.java:
##########
@@ -70,7 +72,10 @@ public final class OpenGaussMetaDataLoader implements
DialectMetaDataLoader {
@Override
public Collection<SchemaMetaData> load(final MetaDataLoaderMaterial
material) throws SQLException {
try (Connection connection = material.getDataSource().getConnection())
{
- Collection<String> schemaNames =
SchemaMetaDataLoader.loadSchemaNames(connection,
TypedSPILoader.getService(DatabaseType.class, "openGauss"));
+ DatabaseType databaseType =
TypedSPILoader.getService(DatabaseType.class, "openGauss");
Review Comment:
What does this code mean?
##########
infra/database/type/opengauss/src/main/java/org/apache/shardingsphere/infra/database/opengauss/metadata/data/loader/OpenGaussMetaDataLoader.java:
##########
@@ -70,7 +72,10 @@ public final class OpenGaussMetaDataLoader implements
DialectMetaDataLoader {
@Override
public Collection<SchemaMetaData> load(final MetaDataLoaderMaterial
material) throws SQLException {
try (Connection connection = material.getDataSource().getConnection())
{
- Collection<String> schemaNames =
SchemaMetaDataLoader.loadSchemaNames(connection,
TypedSPILoader.getService(DatabaseType.class, "openGauss"));
+ DatabaseType databaseType =
TypedSPILoader.getService(DatabaseType.class, "openGauss");
+ DialectDatabaseMetaData dialectDatabaseMetaData = new
DatabaseTypeRegistry(databaseType).getDialectDatabaseMetaData();
+ dialectDatabaseMetaData.getSchema(connection);
Review Comment:
This method is called, but the return value is not processed. What is the
purpose of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
