(shardingsphere) branch master updated: Refactor ComputeNodeLabelChangedHandler (#34937)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 9715c29fc20 Refactor ComputeNodeLabelChangedHandler (#34937)
9715c29fc20 is described below

commit 9715c29fc208b31bacb79e187811825e5fac7d3d
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Sat Mar 8 06:53:21 2025 +0800

    Refactor ComputeNodeLabelChangedHandler (#34937)
---
 .../handler/global/node/ComputeNodeLabelChangedHandler.java         | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git 
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/node/ComputeNodeLabelChangedHandler.java
 
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/node/ComputeNodeLabelChangedHandler.java
index 698929704ef..465d892df46 100644
--- 
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/node/ComputeNodeLabelChangedHandler.java
+++ 
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/node/ComputeNodeLabelChangedHandler.java
@@ -18,7 +18,6 @@
 package 
org.apache.shardingsphere.mode.manager.cluster.dispatch.handler.global.node;
 
 import com.google.common.base.Strings;
-import org.apache.shardingsphere.infra.instance.ComputeNodeInstanceContext;
 import org.apache.shardingsphere.infra.util.yaml.YamlEngine;
 import org.apache.shardingsphere.mode.event.DataChangedEvent;
 import org.apache.shardingsphere.mode.event.DataChangedEvent.Type;
@@ -54,8 +53,7 @@ public final class ComputeNodeLabelChangedHandler implements 
GlobalDataChangedEv
     
     @SuppressWarnings("unchecked")
     private void handle(final ContextManager contextManager, final 
DataChangedEvent event, final String instanceId) {
-        ComputeNodeInstanceContext computeNodeInstanceContext = 
contextManager.getComputeNodeInstanceContext();
-        // TODO labels may be empty
-        computeNodeInstanceContext.updateLabels(instanceId, 
Strings.isNullOrEmpty(event.getValue()) ? new ArrayList<>() : 
YamlEngine.unmarshal(event.getValue(), Collection.class));
+        contextManager.getComputeNodeInstanceContext().updateLabels(
+                instanceId, Strings.isNullOrEmpty(event.getValue()) ? new 
ArrayList<>() : YamlEngine.unmarshal(event.getValue(), Collection.class));
     }
 }