(shardingsphere) branch master updated: Support SQL parsing of Oracle comparison operators containing spaces (#34716)

[duanzhengqiang]

This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new acc16fc705e Support SQL parsing of Oracle comparison operators 
containing spaces (#34716)
acc16fc705e is described below

commit acc16fc705e3102ff32d931d9508b94250c60af1
Author: ZhangCheng <chengzh...@apache.org>
AuthorDate: Wed Feb 19 15:26:54 2025 +0800

    Support SQL parsing of Oracle comparison operators containing spaces 
(#34716)
    
    * Support SQL parsing of Oracle comparison operators containing spaces
    
    * Support SQL parsing of Oracle comparison operators containing spaces
---
 .../src/main/antlr4/imports/oracle/BaseRule.g4     |  2 +-
 .../parser/src/main/resources/case/dml/select.xml  | 38 ++++++++++++++++++++++
 .../main/resources/sql/supported/dml/select.xml    |  1 +
 3 files changed, 40 insertions(+), 1 deletion(-)

diff --git 
a/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4 
b/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4
index f262515ebf3..83bb043915b 100644
--- a/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4
+++ b/parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4
@@ -694,7 +694,7 @@ booleanPrimary
     ;
 
 comparisonOperator
-    : EQ_ | GTE_ | GT_ | LTE_ | LT_ | NEQ_
+    : EQ_ | GTE_ | GT_ | LTE_ | LT_ | NEQ_ | (GT_ | LT_) EQ_
     ;
 
 predicate
diff --git a/test/it/parser/src/main/resources/case/dml/select.xml 
b/test/it/parser/src/main/resources/case/dml/select.xml
index cd88b0f8e77..5ce9ca406aa 100644
--- a/test/it/parser/src/main/resources/case/dml/select.xml
+++ b/test/it/parser/src/main/resources/case/dml/select.xml
@@ -10068,4 +10068,42 @@
             </expr>
         </where>
     </select>
+    
+    <select sql-case-id="select_with_comparison_with_space">
+        <projections distinct-row="false" start-index="7" stop-index="7">
+            <shorthand-projection start-index="7" stop-index="7"/>
+        </projections>
+        <from start-delimiter="" end-delimiter="" start-index="14" 
stop-index="17">
+            <simple-table name="test" start-delimiter="" end-delimiter="" 
start-index="14" stop-index="17"/>
+        </from>
+        <where start-index="19" stop-index="48">
+            <expr start-index="25" stop-index="48">
+                <binary-operation-expression start-index="25" stop-index="48">
+                    <left start-index="25" stop-index="32">
+                        <binary-operation-expression start-index="25" 
stop-index="32">
+                            <left start-index="25" stop-index="26">
+                                <column name="id" start-delimiter="" 
end-delimiter="" start-index="25" stop-index="26"/>
+                            </left>
+                            <operator>&gt;=</operator>
+                            <right start-index="32" stop-index="32">
+                                <literal-expression value="1" start-index="32" 
stop-index="32"/>
+                            </right>
+                        </binary-operation-expression>
+                    </left>
+                    <operator>or</operator>
+                    <right start-index="37" stop-index="48">
+                        <binary-operation-expression start-index="37" 
stop-index="48">
+                            <left start-index="37" stop-index="40">
+                                <column name="name" start-delimiter="" 
end-delimiter="" start-index="37" stop-index="40"/>
+                            </left>
+                            <operator>&lt;=</operator>
+                            <right start-index="48" stop-index="48">
+                                <literal-expression value="2" start-index="48" 
stop-index="48"/>
+                            </right>
+                        </binary-operation-expression>
+                    </right>
+                </binary-operation-expression>
+            </expr>
+        </where>
+    </select>
 </sql-parser-test-cases>
diff --git a/test/it/parser/src/main/resources/sql/supported/dml/select.xml 
b/test/it/parser/src/main/resources/sql/supported/dml/select.xml
index 128b2f10c2f..a0bdd86fc17 100644
--- a/test/it/parser/src/main/resources/sql/supported/dml/select.xml
+++ b/test/it/parser/src/main/resources/sql/supported/dml/select.xml
@@ -315,4 +315,5 @@
     <sql-case id="select_with_multi_literals" value="SELECT 'x' 'x' 'x'" 
db-types="MySQL"/>
     <sql-case id="select_with_mixed_single_double_quoted_literals" 
value="SELECT 'x' &quot;x&quot; 'x' FROM t_order WHERE status LIKE 
&quot;%&quot; '123' &quot;%&quot;" db-types="MySQL"/>
     <sql-case id="select_is_not_nan" value="SELECT COUNT(*) FROM employees 
WHERE commission_pct IS NOT NAN" db-types="Oracle"/>
+    <sql-case id="select_with_comparison_with_space" value="select * from test 
where id &gt; = 1 or name &lt;   = 2" db-types="Oracle"/>
 </sql-cases>