This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push: new 0df8ef6e2f6 Refactor ViewMetaDataNodePathParser (#34675) 0df8ef6e2f6 is described below commit 0df8ef6e2f6e7f4ca644f8a0ce167933bc8a9ee8 Author: Liang Zhang <zhangli...@apache.org> AuthorDate: Sat Feb 15 15:54:08 2025 +0800 Refactor ViewMetaDataNodePathParser (#34675) --- .../mode/node/path/metadata/ViewMetaDataNodePathParser.java | 2 +- .../dispatch/handler/database/metadata/MetaDataChangedHandler.java | 4 ++-- .../dispatch/handler/database/metadata/type/ViewChangedHandler.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/ViewMetaDataNodePathParser.java b/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/ViewMetaDataNodePathParser.java index 897a7898607..7a10333b1ac 100644 --- a/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/ViewMetaDataNodePathParser.java +++ b/mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/metadata/ViewMetaDataNodePathParser.java @@ -63,7 +63,7 @@ public final class ViewMetaDataNodePathParser { * * @return view version node path parser */ - public static VersionNodePathParser getVersionParser() { + public static VersionNodePathParser getVersion() { return VERSION_PARSER; } } diff --git a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/MetaDataChangedHandler.java b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/MetaDataChangedHandler.java index 8f294201965..e84c92b3f24 100644 --- a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/MetaDataChangedHandler.java +++ b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/MetaDataChangedHandler.java @@ -106,11 +106,11 @@ public final class MetaDataChangedHandler { } private boolean isViewMetaDataChanged(final String key) { - return ViewMetaDataNodePathParser.getVersionParser().isActiveVersionPath(key) || ViewMetaDataNodePathParser.isViewPath(key); + return ViewMetaDataNodePathParser.getVersion().isActiveVersionPath(key) || ViewMetaDataNodePathParser.isViewPath(key); } private void handleViewChanged(final String databaseName, final String schemaName, final DataChangedEvent event) { - if ((Type.ADDED == event.getType() || Type.UPDATED == event.getType()) && ViewMetaDataNodePathParser.getVersionParser().isActiveVersionPath(event.getKey())) { + if ((Type.ADDED == event.getType() || Type.UPDATED == event.getType()) && ViewMetaDataNodePathParser.getVersion().isActiveVersionPath(event.getKey())) { viewChangedHandler.handleCreatedOrAltered(databaseName, schemaName, event); } else if (Type.DELETED == event.getType() && ViewMetaDataNodePathParser.isViewPath(event.getKey())) { viewChangedHandler.handleDropped(databaseName, schemaName, event); diff --git a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/type/ViewChangedHandler.java b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/type/ViewChangedHandler.java index b9e1ebf1064..f36fee33f6b 100644 --- a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/type/ViewChangedHandler.java +++ b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/database/metadata/type/ViewChangedHandler.java @@ -47,7 +47,7 @@ public final class ViewChangedHandler { */ public void handleCreatedOrAltered(final String databaseName, final String schemaName, final DataChangedEvent event) { String viewName = - ViewMetaDataNodePathParser.getVersionParser().findIdentifierByActiveVersionPath(event.getKey(), 3).orElseThrow(() -> new IllegalStateException("View name not found.")); + ViewMetaDataNodePathParser.getVersion().findIdentifierByActiveVersionPath(event.getKey(), 3).orElseThrow(() -> new IllegalStateException("View name not found.")); ActiveVersionChecker.checkActiveVersion(contextManager, event); ShardingSphereView view = contextManager.getPersistServiceFacade().getMetaDataPersistFacade().getDatabaseMetaDataFacade().getView().load(databaseName, schemaName, viewName); contextManager.getMetaDataContextManager().getDatabaseMetaDataManager().alterView(databaseName, schemaName, view);