This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 11df6c0e057 Refactor StatisticsRefreshEngine (#34553)
11df6c0e057 is described below

commit 11df6c0e057eb0fbc6a80f61abf67a7d35b1d22c
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Sat Feb 1 23:48:20 2025 +0800

    Refactor StatisticsRefreshEngine (#34553)
    
    * Refactor StorageUnitManager
    
    * Refactor StatisticsRefreshEngine
---
 .../metadata/refresher/statistics/StatisticsRefreshEngine.java | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/statistics/StatisticsRefreshEngine.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/statistics/StatisticsRefreshEngine.java
index 7c267901e38..90705424427 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/statistics/StatisticsRefreshEngine.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/statistics/StatisticsRefreshEngine.java
@@ -17,6 +17,7 @@
 
 package org.apache.shardingsphere.mode.metadata.refresher.statistics;
 
+import lombok.RequiredArgsConstructor;
 import lombok.extern.slf4j.Slf4j;
 import 
org.apache.shardingsphere.infra.config.props.temporary.TemporaryConfigurationPropertyKey;
 import 
org.apache.shardingsphere.infra.executor.kernel.thread.ExecutorThreadFactoryBuilder;
@@ -50,6 +51,7 @@ import java.util.stream.Collectors;
 /**
  * Statistics refresh engine.
  */
+@RequiredArgsConstructor
 @Slf4j
 public final class StatisticsRefreshEngine {
     
@@ -57,13 +59,6 @@ public final class StatisticsRefreshEngine {
     
     private final ContextManager contextManager;
     
-    private final LockContext lockContext;
-    
-    public StatisticsRefreshEngine(final ContextManager contextManager) {
-        this.contextManager = contextManager;
-        lockContext = 
contextManager.getComputeNodeInstanceContext().getLockContext();
-    }
-    
     /**
      * Async refresh.
      */
@@ -89,6 +84,7 @@ public final class StatisticsRefreshEngine {
     }
     
     private void collectAndRefresh() {
+        LockContext lockContext = 
contextManager.getComputeNodeInstanceContext().getLockContext();
         GlobalLockDefinition lockDefinition = new GlobalLockDefinition(new 
StatisticsLock());
         if (lockContext.tryLock(lockDefinition, 5000L)) {
             try {

Reply via email to