This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 857d54b8f9e Refactor MetaDataManagerPersistService.alterSchema() 
(#34524)
857d54b8f9e is described below

commit 857d54b8f9e4507be97418363a2d8bf568e9269e
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Mon Jan 27 23:41:03 2025 +0800

    Refactor MetaDataManagerPersistService.alterSchema() (#34524)
    
    * Refactor MetaDataManagerPersistService.alterSchema()
    
    * Refactor MetaDataManagerPersistService.alterSchema()
---
 .../metadata/federation/type/AlterViewFederationMetaDataRefresher.java | 2 +-
 .../federation/type/CreateViewFederationMetaDataRefresher.java         | 2 +-
 .../metadata/federation/type/DropViewFederationMetaDataRefresher.java  | 2 +-
 .../pushdown/type/index/AlterIndexPushDownMetaDataRefresher.java       | 3 +--
 .../pushdown/type/index/CreateIndexPushDownMetaDataRefresher.java      | 2 +-
 .../pushdown/type/index/DropIndexPushDownMetaDataRefresher.java        | 2 +-
 .../pushdown/type/table/AlterTablePushDownMetaDataRefresher.java       | 3 +--
 .../pushdown/type/table/RenameTablePushDownMetaDataRefresher.java      | 2 +-
 .../pushdown/type/view/AlterViewPushDownMetaDataRefresher.java         | 3 +--
 .../pushdown/type/view/CreateViewPushDownMetaDataRefresher.java        | 2 +-
 .../metadata/pushdown/type/view/DropViewPushDownMetaDataRefresher.java | 2 +-
 .../mode/persist/service/MetaDataManagerPersistService.java            | 3 +--
 .../cluster/persist/service/ClusterMetaDataManagerPersistService.java  | 2 +-
 .../persist/service/ClusterMetaDataManagerPersistServiceTest.java      | 2 +-
 .../persist/service/StandaloneMetaDataManagerPersistService.java       | 2 +-
 .../persist/service/StandaloneMetaDataManagerPersistServiceTest.java   | 2 +-
 16 files changed, 16 insertions(+), 20 deletions(-)

diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java
index 33f23d4a679..3a94ad2700a 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java
@@ -48,7 +48,7 @@ public final class AlterViewFederationMetaDataRefresher 
implements FederationMet
             droppedViews.add(viewName);
         }
         sqlStatement.getViewDefinition().ifPresent(optional -> 
alteredViews.add(new ShardingSphereView(viewName, optional)));
-        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, null, Collections.emptyList(), alteredViews, 
Collections.emptyList(), droppedViews);
+        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, Collections.emptyList(), alteredViews, Collections.emptyList(), 
droppedViews);
     }
     
     @Override
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/CreateViewFederationMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/CreateViewFederationMetaDataRefresher.java
index 769f3a06164..bc01b703836 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/CreateViewFederationMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/CreateViewFederationMetaDataRefresher.java
@@ -34,7 +34,7 @@ public final class CreateViewFederationMetaDataRefresher 
implements FederationMe
     @Override
     public void refresh(final MetaDataManagerPersistService 
metaDataManagerPersistService, final ShardingSphereDatabase database, final 
String schemaName, final CreateViewStatement sqlStatement) {
         String viewName = 
TableRefreshUtils.getTableName(sqlStatement.getView().getTableName().getIdentifier(),
 sqlStatement.getDatabaseType());
-        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, null,
+        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName,
                 Collections.emptyList(), Collections.singleton(new 
ShardingSphereView(viewName, sqlStatement.getViewDefinition())), 
Collections.emptyList(), Collections.emptyList());
     }
     
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/DropViewFederationMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/DropViewFederationMetaDataRefresher.java
index e9c0b8dc449..ba1dae4fac9 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/DropViewFederationMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/DropViewFederationMetaDataRefresher.java
@@ -34,7 +34,7 @@ public final class DropViewFederationMetaDataRefresher 
implements FederationMeta
     @Override
     public void refresh(final MetaDataManagerPersistService 
metaDataManagerPersistService, final ShardingSphereDatabase database, final 
String schemaName, final DropViewStatement sqlStatement) {
         Collection<String> droppedViews = 
sqlStatement.getViews().stream().map(each -> 
each.getTableName().getIdentifier().getValue()).collect(Collectors.toList());
-        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, null, Collections.emptyList(), Collections.emptyList(), 
Collections.emptyList(), droppedViews);
+        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, Collections.emptyList(), Collections.emptyList(), 
Collections.emptyList(), droppedViews);
     }
     
     @Override
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/AlterIndexPushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/AlterIndexPushDownMetaDataRefresher.java
index 51e2c8d26a5..d846f4de881 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/AlterIndexPushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/AlterIndexPushDownMetaDataRefresher.java
@@ -61,8 +61,7 @@ public final class AlterIndexPushDownMetaDataRefresher 
implements PushDownMetaDa
         newTable.removeIndex(indexName);
         String renameIndexName = 
renameIndex.get().getIndexName().getIdentifier().getValue();
         newTable.putIndex(new ShardingSphereIndex(renameIndexName, new 
LinkedList<>(), false));
-        metaDataManagerPersistService.alterSchema(database.getName(), 
actualSchemaName, null,
-                Collections.singleton(newTable), Collections.emptyList(), 
Collections.emptyList(), Collections.emptyList());
+        metaDataManagerPersistService.alterSchema(database.getName(), 
actualSchemaName, Collections.singleton(newTable), Collections.emptyList(), 
Collections.emptyList(), Collections.emptyList());
     }
     
     private Optional<String> findLogicTableName(final ShardingSphereSchema 
schema, final String indexName) {
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/CreateIndexPushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/CreateIndexPushDownMetaDataRefresher.java
index 67727f9c1b7..1f25ec77d2c 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/CreateIndexPushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/CreateIndexPushDownMetaDataRefresher.java
@@ -53,7 +53,7 @@ public final class CreateIndexPushDownMetaDataRefresher 
implements PushDownMetaD
         ShardingSphereTable table = schema.getTable(tableName);
         ShardingSphereTable newTable = new 
ShardingSphereTable(table.getName(), table.getAllColumns(), 
table.getAllIndexes(), table.getAllConstraints(), table.getType());
         newTable.putIndex(new ShardingSphereIndex(indexName, new 
LinkedList<>(), false));
-        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, null, Collections.singleton(newTable), Collections.emptyList(), 
Collections.emptyList(), Collections.emptyList());
+        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, Collections.singleton(newTable), Collections.emptyList(), 
Collections.emptyList(), Collections.emptyList());
     }
     
     @Override
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/DropIndexPushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/DropIndexPushDownMetaDataRefresher.java
index eeb19580a73..30cb1982e1b 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/DropIndexPushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/index/DropIndexPushDownMetaDataRefresher.java
@@ -57,7 +57,7 @@ public final class DropIndexPushDownMetaDataRefresher 
implements PushDownMetaDat
             ShardingSphereTable table = schema.getTable(logicTableName.get());
             ShardingSphereTable newTable = new 
ShardingSphereTable(table.getName(), table.getAllColumns(), 
table.getAllIndexes(), table.getAllConstraints(), table.getType());
             
newTable.removeIndex(each.getIndexName().getIdentifier().getValue());
-            metaDataManagerPersistService.alterSchema(database.getName(), 
actualSchemaName, null,
+            metaDataManagerPersistService.alterSchema(database.getName(), 
actualSchemaName,
                     Collections.singleton(newTable), Collections.emptyList(), 
Collections.emptyList(), Collections.emptyList());
         }
     }
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/table/AlterTablePushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/table/AlterTablePushDownMetaDataRefresher.java
index 5232ea1f46b..2027161fc3c 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/table/AlterTablePushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/table/AlterTablePushDownMetaDataRefresher.java
@@ -56,8 +56,7 @@ public final class AlterTablePushDownMetaDataRefresher 
implements PushDownMetaDa
         } else {
             alteredTables.add(getTable(database, logicDataSourceNames, 
schemaName, tableName, props));
         }
-        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, logicDataSourceNames.isEmpty() ? null : 
logicDataSourceNames.iterator().next(),
-                alteredTables, Collections.emptyList(), droppedTables, 
Collections.emptyList());
+        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, alteredTables, Collections.emptyList(), droppedTables, 
Collections.emptyList());
     }
     
     private ShardingSphereTable getTable(final ShardingSphereDatabase 
database, final Collection<String> logicDataSourceNames, final String 
schemaName,
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/table/RenameTablePushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/table/RenameTablePushDownMetaDataRefresher.java
index 9c0ba1f5677..7babbd9530e 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/table/RenameTablePushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/table/RenameTablePushDownMetaDataRefresher.java
@@ -50,7 +50,7 @@ public final class RenameTablePushDownMetaDataRefresher 
implements PushDownMetaD
         for (RenameTableDefinitionSegment each : 
sqlStatement.getRenameTables()) {
             ShardingSphereTable alteredTable = getTable(
                     database, logicDataSourceNames, schemaName, 
TableRefreshUtils.getTableName(each.getRenameTable().getTableName().getIdentifier(),
 databaseType), props);
-            metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, logicDataSourceNames.isEmpty() ? null : 
logicDataSourceNames.iterator().next(),
+            metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName,
                     Collections.singleton(alteredTable), 
Collections.emptyList(), 
Collections.singleton(each.getTable().getTableName().getIdentifier().getValue()),
 Collections.emptyList());
         }
     }
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
index 310029f548b..fd1dd1b5abc 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/AlterViewPushDownMetaDataRefresher.java
@@ -69,8 +69,7 @@ public final class AlterViewPushDownMetaDataRefresher 
implements PushDownMetaDat
             alteredTables.add(schema.getTable(viewName));
             alteredViews.add(schema.getView(viewName));
         }
-        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName,
-                logicDataSourceNames.isEmpty() ? null : 
logicDataSourceNames.iterator().next(), alteredTables, alteredViews, 
droppedTables, droppedViews);
+        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, alteredTables, alteredViews, droppedTables, droppedViews);
     }
     
     private ShardingSphereSchema getSchema(final ShardingSphereDatabase 
database, final Collection<String> logicDataSourceNames,
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
index 989d2c64130..eee33b07c14 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/CreateViewPushDownMetaDataRefresher.java
@@ -57,7 +57,7 @@ public final class CreateViewPushDownMetaDataRefresher 
implements PushDownMetaDa
         Map<String, ShardingSphereSchema> schemas = 
GenericSchemaBuilder.build(Collections.singletonList(viewName), 
database.getProtocolType(), material);
         Optional<ShardingSphereTable> actualTableMetaData = 
Optional.ofNullable(schemas.get(schemaName)).map(optional -> 
optional.getTable(viewName));
         Preconditions.checkState(actualTableMetaData.isPresent(), "Load actual 
view metadata '%s' failed.", viewName);
-        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, logicDataSourceNames.isEmpty() ? null : 
logicDataSourceNames.iterator().next(),
+        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName,
                 Collections.singleton(actualTableMetaData.get()), 
Collections.singleton(new ShardingSphereView(viewName, 
sqlStatement.getViewDefinition())),
                 Collections.emptyList(), Collections.emptyList());
     }
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/DropViewPushDownMetaDataRefresher.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/DropViewPushDownMetaDataRefresher.java
index 1e2c74d6395..358c87af0e5 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/DropViewPushDownMetaDataRefresher.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/pushdown/type/view/DropViewPushDownMetaDataRefresher.java
@@ -44,7 +44,7 @@ public final class DropViewPushDownMetaDataRefresher 
implements PushDownMetaData
             droppedTables.add(viewName);
             droppedViews.add(viewName);
         }
-        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, null, Collections.emptyList(), Collections.emptyList(), 
droppedTables, droppedViews);
+        metaDataManagerPersistService.alterSchema(database.getName(), 
schemaName, Collections.emptyList(), Collections.emptyList(), droppedTables, 
droppedViews);
     }
     
     @Override
diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/persist/service/MetaDataManagerPersistService.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/persist/service/MetaDataManagerPersistService.java
index b5ee1cc48c7..85f33b8fc9a 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/persist/service/MetaDataManagerPersistService.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/persist/service/MetaDataManagerPersistService.java
@@ -60,13 +60,12 @@ public interface MetaDataManagerPersistService {
      *
      * @param databaseName database name
      * @param schemaName schema name
-     * @param logicDataSourceName logic data source name
      * @param alteredTables altered tables
      * @param alteredViews altered views
      * @param droppedTables dropped tables
      * @param droppedViews dropped views
      */
-    void alterSchema(String databaseName, String schemaName, String 
logicDataSourceName,
+    void alterSchema(String databaseName, String schemaName,
                      Collection<ShardingSphereTable> alteredTables, 
Collection<ShardingSphereView> alteredViews, Collection<String> droppedTables, 
Collection<String> droppedViews);
     
     /**
diff --git 
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistService.java
 
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistService.java
index 9c141e59ed4..aaa27205e5b 100644
--- 
a/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistService.java
+++ 
b/mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistService.java
@@ -88,7 +88,7 @@ public final class ClusterMetaDataManagerPersistService 
implements MetaDataManag
     }
     
     @Override
-    public void alterSchema(final String databaseName, final String 
schemaName, final String logicDataSourceName,
+    public void alterSchema(final String databaseName, final String schemaName,
                             final Collection<ShardingSphereTable> 
alteredTables, final Collection<ShardingSphereView> alteredViews,
                             final Collection<String> droppedTables, final 
Collection<String> droppedViews) {
         DatabaseMetaDataPersistFacade databaseMetaDataFacade = 
metaDataPersistService.getDatabaseMetaDataFacade();
diff --git 
a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java
 
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java
index 172e056b4d1..01172837b7d 100644
--- 
a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java
+++ 
b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java
@@ -93,7 +93,7 @@ class ClusterMetaDataManagerPersistServiceTest {
     
     @Test
     void assertAlterSchema() {
-        metaDataManagerPersistService.alterSchema("foo_db", "foo_schema", 
"foo_ds", Collections.emptyList(), Collections.emptyList(), 
Collections.emptyList(), Collections.emptyList());
+        metaDataManagerPersistService.alterSchema("foo_db", "foo_schema", 
Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), 
Collections.emptyList());
         
verify(metaDataPersistService.getDatabaseMetaDataFacade().getTable()).persist("foo_db",
 "foo_schema", Collections.emptyList());
         
verify(metaDataPersistService.getDatabaseMetaDataFacade().getView()).persist("foo_db",
 "foo_schema", Collections.emptyList());
     }
diff --git 
a/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java
 
b/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java
index 97d1c3ef338..fcb825cc6e6 100644
--- 
a/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java
+++ 
b/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java
@@ -90,7 +90,7 @@ public final class StandaloneMetaDataManagerPersistService 
implements MetaDataMa
     }
     
     @Override
-    public void alterSchema(final String databaseName, final String 
schemaName, final String logicDataSourceName,
+    public void alterSchema(final String databaseName, final String schemaName,
                             final Collection<ShardingSphereTable> 
alteredTables, final Collection<ShardingSphereView> alteredViews,
                             final Collection<String> droppedTables, final 
Collection<String> droppedViews) {
         DatabaseMetaDataPersistFacade databaseMetaDataFacade = 
metaDataPersistService.getDatabaseMetaDataFacade();
diff --git 
a/mode/type/standalone/core/src/test/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistServiceTest.java
 
b/mode/type/standalone/core/src/test/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistServiceTest.java
index 5290541fc91..e296bdf9235 100644
--- 
a/mode/type/standalone/core/src/test/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistServiceTest.java
+++ 
b/mode/type/standalone/core/src/test/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistServiceTest.java
@@ -101,7 +101,7 @@ class StandaloneMetaDataManagerPersistServiceTest {
     void assertAlterSchema() {
         DatabaseMetaDataPersistFacade databaseMetaDataFacade = 
mock(DatabaseMetaDataPersistFacade.class, RETURNS_DEEP_STUBS);
         
when(metaDataPersistService.getDatabaseMetaDataFacade()).thenReturn(databaseMetaDataFacade);
-        metaDataManagerPersistService.alterSchema("foo_db", "foo_schema", 
"foo_ds", Collections.emptyList(), Collections.emptyList(), 
Collections.emptyList(), Collections.emptyList());
+        metaDataManagerPersistService.alterSchema("foo_db", "foo_schema", 
Collections.emptyList(), Collections.emptyList(), Collections.emptyList(), 
Collections.emptyList());
         verify(databaseMetaDataFacade.getTable()).persist("foo_db", 
"foo_schema", new LinkedList<>());
     }
     

Reply via email to