This is an automated email from the ASF dual-hosted git repository. zhangliang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push: new 944fd323d97 Fix AlterViewFederationMetaDataRefresher (#34512) 944fd323d97 is described below commit 944fd323d97b7bed234ff5d0cb9c440c0b624605 Author: Liang Zhang <zhangli...@apache.org> AuthorDate: Sun Jan 26 14:58:36 2025 +0800 Fix AlterViewFederationMetaDataRefresher (#34512) * Fix AlterViewFederationMetaDataRefresher * Fix AlterViewFederationMetaDataRefresher --- .../federation/type/AlterViewFederationMetaDataRefresher.java | 2 +- .../service/StandaloneMetaDataManagerPersistService.java | 10 ++++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java index 238922b8aa3..33f23d4a679 100644 --- a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java +++ b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/refresher/metadata/federation/type/AlterViewFederationMetaDataRefresher.java @@ -48,7 +48,7 @@ public final class AlterViewFederationMetaDataRefresher implements FederationMet droppedViews.add(viewName); } sqlStatement.getViewDefinition().ifPresent(optional -> alteredViews.add(new ShardingSphereView(viewName, optional))); - metaDataManagerPersistService.alterSchema(database.getName(), schemaName, null, Collections.emptyList(), alteredViews, droppedViews, Collections.emptyList()); + metaDataManagerPersistService.alterSchema(database.getName(), schemaName, null, Collections.emptyList(), alteredViews, Collections.emptyList(), droppedViews); } @Override diff --git a/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java b/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java index aa1aff94e3d..5cd70dcfcc8 100644 --- a/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java +++ b/mode/type/standalone/core/src/main/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistService.java @@ -39,6 +39,7 @@ import org.apache.shardingsphere.mode.metadata.manager.RuleItemChangedBuilder; import org.apache.shardingsphere.mode.metadata.manager.SwitchingResource; import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistService; import org.apache.shardingsphere.mode.metadata.persist.config.database.DataSourceUnitPersistService; +import org.apache.shardingsphere.mode.metadata.persist.metadata.DatabaseMetaDataPersistFacade; import org.apache.shardingsphere.mode.metadata.refresher.metadata.util.TableRefreshUtils; import org.apache.shardingsphere.mode.persist.service.MetaDataManagerPersistService; import org.apache.shardingsphere.mode.spi.rule.item.RuleChangedItem; @@ -96,10 +97,11 @@ public final class StandaloneMetaDataManagerPersistService implements MetaDataMa public void alterSchema(final String databaseName, final String schemaName, final String logicDataSourceName, final Collection<ShardingSphereTable> alteredTables, final Collection<ShardingSphereView> alteredViews, final Collection<String> droppedTables, final Collection<String> droppedViews) { - metaDataPersistService.getDatabaseMetaDataFacade().getTable().persist(databaseName, schemaName, alteredTables); - metaDataPersistService.getDatabaseMetaDataFacade().getView().persist(databaseName, schemaName, alteredViews); - droppedTables.forEach(each -> metaDataPersistService.getDatabaseMetaDataFacade().getTable().drop(databaseName, schemaName, each)); - droppedViews.forEach(each -> metaDataPersistService.getDatabaseMetaDataFacade().getView().delete(databaseName, schemaName, each)); + DatabaseMetaDataPersistFacade databaseMetaDataFacade = metaDataPersistService.getDatabaseMetaDataFacade(); + databaseMetaDataFacade.getTable().persist(databaseName, schemaName, alteredTables); + databaseMetaDataFacade.getView().persist(databaseName, schemaName, alteredViews); + droppedTables.forEach(each -> databaseMetaDataFacade.getTable().drop(databaseName, schemaName, each)); + droppedViews.forEach(each -> databaseMetaDataFacade.getView().delete(databaseName, schemaName, each)); ShardingSphereMetaData metaData = metaDataContextManager.getMetaDataContexts().getMetaData(); ShardingSphereDatabase database = metaData.getDatabase(databaseName); addDataNode(database, logicDataSourceName, schemaName, alteredTables, alteredViews);