This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new e5af00acc09 Remove useless codes on MetaDataContextsFactory (#34345)
e5af00acc09 is described below

commit e5af00acc096a393f6911807d7e9cb0c2d517723
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Mon Jan 13 20:49:39 2025 +0800

    Remove useless codes on MetaDataContextsFactory (#34345)
---
 .../apache/shardingsphere/mode/metadata/MetaDataContextsFactory.java | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactory.java
 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactory.java
index 3e0ab1a1a21..303dea3fa06 100644
--- 
a/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactory.java
+++ 
b/mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/MetaDataContextsFactory.java
@@ -82,7 +82,7 @@ public final class MetaDataContextsFactory {
         ConfigurationProperties props = new 
ConfigurationProperties(param.getProps());
         Map<String, ShardingSphereDatabase> databases = 
ExternalMetaDataFactory.create(param.getDatabaseConfigs(), props, 
instanceContext);
         MetaDataContexts result = newMetaDataContexts(persistService, param, 
globalRuleConfigs, databases, props);
-        persistDatabaseConfigurations(result, param, persistService, 
instanceContext);
+        persistDatabaseConfigurations(result, param, persistService);
         persistMetaData(result, persistService);
         return result;
     }
@@ -132,8 +132,7 @@ public final class MetaDataContextsFactory {
         }
     }
     
-    private static void persistDatabaseConfigurations(final MetaDataContexts 
metadataContexts,
-                                                      final 
ContextManagerBuilderParameter param, final MetaDataPersistService 
persistService, final ComputeNodeInstanceContext instanceContext) {
+    private static void persistDatabaseConfigurations(final MetaDataContexts 
metadataContexts, final ContextManagerBuilderParameter param, final 
MetaDataPersistService persistService) {
         Collection<RuleConfiguration> globalRuleConfigs = 
metadataContexts.getMetaData().getGlobalRuleMetaData().getConfigurations();
         persistService.persistGlobalRuleConfiguration(globalRuleConfigs, 
param.getProps());
         for (Entry<String, ? extends DatabaseConfiguration> entry : 
param.getDatabaseConfigs().entrySet()) {

Reply via email to