This is an automated email from the ASF dual-hosted git repository.
chengzhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new d41a743349e Minor refactor for view statement (#34290)
d41a743349e is described below
commit d41a743349e636c3a34a74dc1c918a2053cb7bd3
Author: Zhengqiang Duan <duanzhengqi...@apache.org>
AuthorDate: Thu Jan 9 12:49:57 2025 +0800
Minor refactor for view statement (#34290)
---
.../doris/visitor/statement/type/DorisDDLStatementVisitor.java | 1 +
.../visitor/statement/type/OpenGaussDDLStatementVisitor.java | 1 +
.../visitor/statement/type/PostgreSQLDDLStatementVisitor.java | 1 +
.../presto/visitor/statement/type/PrestoDDLStatementVisitor.java | 1 +
.../visitor/statement/type/SQLServerDDLStatementVisitor.java | 1 +
.../sql/parser/statement/doris/ddl/DorisDropViewStatement.java | 6 ++++++
.../parser/statement/opengauss/ddl/OpenGaussDropViewStatement.java | 6 ++++++
.../statement/postgresql/ddl/PostgreSQLDropViewStatement.java | 6 ++++++
.../sql/parser/statement/presto/ddl/PrestoDropViewStatement.java | 6 ++++++
.../parser/statement/sqlserver/ddl/SQLServerDropViewStatement.java | 6 ++++++
10 files changed, 35 insertions(+)
diff --git
a/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/type/DorisDDLStatementVisitor.java
b/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/type/DorisDDLStatementVisitor.java
index 5acd3f672be..0813a7db2d2 100644
---
a/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/type/DorisDDLStatementVisitor.java
+++
b/parser/sql/dialect/doris/src/main/java/org/apache/shardingsphere/sql/parser/doris/visitor/statement/type/DorisDDLStatementVisitor.java
@@ -226,6 +226,7 @@ public final class DorisDDLStatementVisitor extends
DorisStatementVisitor implem
@Override
public ASTNode visitDropView(final DropViewContext ctx) {
DorisDropViewStatement result = new DorisDropViewStatement();
+ result.setIfExists(null != ctx.ifExists());
result.getViews().addAll(((CollectionValue<SimpleTableSegment>)
visit(ctx.viewNames())).getValue());
return result;
}
diff --git
a/parser/sql/dialect/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/opengauss/visitor/statement/type/OpenGaussDDLStatementVisitor.java
b/parser/sql/dialect/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/opengauss/visitor/statement/type/OpenGaussDDLStatementVisitor.java
index cfba7147d0d..3c42b14e69a 100644
---
a/parser/sql/dialect/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/opengauss/visitor/statement/type/OpenGaussDDLStatementVisitor.java
+++
b/parser/sql/dialect/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/opengauss/visitor/statement/type/OpenGaussDDLStatementVisitor.java
@@ -666,6 +666,7 @@ public final class OpenGaussDDLStatementVisitor extends
OpenGaussStatementVisito
@Override
public ASTNode visitDropView(final DropViewContext ctx) {
OpenGaussDropViewStatement result = new OpenGaussDropViewStatement();
+ result.setIfExists(null != ctx.ifExists());
result.getViews().addAll(((CollectionValue<SimpleTableSegment>)
visit(ctx.qualifiedNameList())).getValue());
return result;
}
diff --git
a/parser/sql/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java
b/parser/sql/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java
index dcc1477fbe0..056389cc9e0 100644
---
a/parser/sql/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java
+++
b/parser/sql/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java
@@ -811,6 +811,7 @@ public final class PostgreSQLDDLStatementVisitor extends
PostgreSQLStatementVisi
@Override
public ASTNode visitDropView(final DropViewContext ctx) {
PostgreSQLDropViewStatement result = new PostgreSQLDropViewStatement();
+ result.setIfExists(null != ctx.ifExists());
result.getViews().addAll(((CollectionValue<SimpleTableSegment>)
visit(ctx.qualifiedNameList())).getValue());
return result;
}
diff --git
a/parser/sql/dialect/presto/src/main/java/org/apache/shardingsphere/sql/parser/presto/visitor/statement/type/PrestoDDLStatementVisitor.java
b/parser/sql/dialect/presto/src/main/java/org/apache/shardingsphere/sql/parser/presto/visitor/statement/type/PrestoDDLStatementVisitor.java
index f18720967b9..12bdecd4720 100644
---
a/parser/sql/dialect/presto/src/main/java/org/apache/shardingsphere/sql/parser/presto/visitor/statement/type/PrestoDDLStatementVisitor.java
+++
b/parser/sql/dialect/presto/src/main/java/org/apache/shardingsphere/sql/parser/presto/visitor/statement/type/PrestoDDLStatementVisitor.java
@@ -67,6 +67,7 @@ public final class PrestoDDLStatementVisitor extends
PrestoStatementVisitor impl
@Override
public ASTNode visitDropView(final DropViewContext ctx) {
PrestoDropViewStatement result = new PrestoDropViewStatement();
+ result.setIfExists(null != ctx.ifExists());
result.getViews().addAll(((CollectionValue<SimpleTableSegment>)
visit(ctx.viewNames())).getValue());
return result;
}
diff --git
a/parser/sql/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/statement/type/SQLServerDDLStatementVisitor.java
b/parser/sql/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/statement/type/SQLServerDDLStatementVisitor.java
index f6f6c4e494c..91c0f2008ba 100644
---
a/parser/sql/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/statement/type/SQLServerDDLStatementVisitor.java
+++
b/parser/sql/dialect/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/sqlserver/visitor/statement/type/SQLServerDDLStatementVisitor.java
@@ -490,6 +490,7 @@ public final class SQLServerDDLStatementVisitor extends
SQLServerStatementVisito
@Override
public ASTNode visitDropView(final DropViewContext ctx) {
SQLServerDropViewStatement result = new SQLServerDropViewStatement();
+ result.setIfExists(null != ctx.ifExists());
for (ViewNameContext each : ctx.viewName()) {
result.getViews().add((SimpleTableSegment) visit(each));
}
diff --git
a/parser/sql/statement/type/doris/src/main/java/org/apache/shardingsphere/sql/parser/statement/doris/ddl/DorisDropViewStatement.java
b/parser/sql/statement/type/doris/src/main/java/org/apache/shardingsphere/sql/parser/statement/doris/ddl/DorisDropViewStatement.java
index c951a641cc6..eb02918ff4e 100644
---
a/parser/sql/statement/type/doris/src/main/java/org/apache/shardingsphere/sql/parser/statement/doris/ddl/DorisDropViewStatement.java
+++
b/parser/sql/statement/type/doris/src/main/java/org/apache/shardingsphere/sql/parser/statement/doris/ddl/DorisDropViewStatement.java
@@ -17,11 +17,17 @@
package org.apache.shardingsphere.sql.parser.statement.doris.ddl;
+import lombok.Getter;
+import lombok.Setter;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropViewStatement;
import org.apache.shardingsphere.sql.parser.statement.doris.DorisStatement;
/**
* Doris drop view statement.
*/
+@Getter
+@Setter
public final class DorisDropViewStatement extends DropViewStatement implements
DorisStatement {
+
+ private boolean ifExists;
}
diff --git
a/parser/sql/statement/type/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/statement/opengauss/ddl/OpenGaussDropViewStatement.java
b/parser/sql/statement/type/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/statement/opengauss/ddl/OpenGaussDropViewStatement.java
index 2db288eda0c..fd051c10345 100644
---
a/parser/sql/statement/type/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/statement/opengauss/ddl/OpenGaussDropViewStatement.java
+++
b/parser/sql/statement/type/opengauss/src/main/java/org/apache/shardingsphere/sql/parser/statement/opengauss/ddl/OpenGaussDropViewStatement.java
@@ -17,11 +17,17 @@
package org.apache.shardingsphere.sql.parser.statement.opengauss.ddl;
+import lombok.Getter;
+import lombok.Setter;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropViewStatement;
import
org.apache.shardingsphere.sql.parser.statement.opengauss.OpenGaussStatement;
/**
* OpenGauss drop view statement.
*/
+@Getter
+@Setter
public final class OpenGaussDropViewStatement extends DropViewStatement
implements OpenGaussStatement {
+
+ private boolean ifExists;
}
diff --git
a/parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/ddl/PostgreSQLDropViewStatement.java
b/parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/ddl/PostgreSQLDropViewStatement.java
index 13b88e4adc4..e07ec8832d9 100644
---
a/parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/ddl/PostgreSQLDropViewStatement.java
+++
b/parser/sql/statement/type/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/statement/postgresql/ddl/PostgreSQLDropViewStatement.java
@@ -17,11 +17,17 @@
package org.apache.shardingsphere.sql.parser.statement.postgresql.ddl;
+import lombok.Getter;
+import lombok.Setter;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropViewStatement;
import
org.apache.shardingsphere.sql.parser.statement.postgresql.PostgreSQLStatement;
/**
* PostgreSQL drop view statement.
*/
+@Getter
+@Setter
public final class PostgreSQLDropViewStatement extends DropViewStatement
implements PostgreSQLStatement {
+
+ private boolean ifExists;
}
diff --git
a/parser/sql/statement/type/presto/src/main/java/org/apache/shardingsphere/sql/parser/statement/presto/ddl/PrestoDropViewStatement.java
b/parser/sql/statement/type/presto/src/main/java/org/apache/shardingsphere/sql/parser/statement/presto/ddl/PrestoDropViewStatement.java
index 6dabe553f09..8b01274218f 100644
---
a/parser/sql/statement/type/presto/src/main/java/org/apache/shardingsphere/sql/parser/statement/presto/ddl/PrestoDropViewStatement.java
+++
b/parser/sql/statement/type/presto/src/main/java/org/apache/shardingsphere/sql/parser/statement/presto/ddl/PrestoDropViewStatement.java
@@ -17,11 +17,17 @@
package org.apache.shardingsphere.sql.parser.statement.presto.ddl;
+import lombok.Getter;
+import lombok.Setter;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropViewStatement;
import org.apache.shardingsphere.sql.parser.statement.presto.PrestoStatement;
/**
* Presto drop view statement.
*/
+@Getter
+@Setter
public final class PrestoDropViewStatement extends DropViewStatement
implements PrestoStatement {
+
+ private boolean ifExists;
}
diff --git
a/parser/sql/statement/type/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/statement/sqlserver/ddl/SQLServerDropViewStatement.java
b/parser/sql/statement/type/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/statement/sqlserver/ddl/SQLServerDropViewStatement.java
index 7015270ef41..4f2b9555581 100644
---
a/parser/sql/statement/type/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/statement/sqlserver/ddl/SQLServerDropViewStatement.java
+++
b/parser/sql/statement/type/sqlserver/src/main/java/org/apache/shardingsphere/sql/parser/statement/sqlserver/ddl/SQLServerDropViewStatement.java
@@ -17,11 +17,17 @@
package org.apache.shardingsphere.sql.parser.statement.sqlserver.ddl;
+import lombok.Getter;
+import lombok.Setter;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.ddl.DropViewStatement;
import
org.apache.shardingsphere.sql.parser.statement.sqlserver.SQLServerStatement;
/**
* SQLServer drop view statement.
*/
+@Getter
+@Setter
public final class SQLServerDropViewStatement extends DropViewStatement
implements SQLServerStatement {
+
+ private boolean ifExists;
}
