omkar-shitole opened a new pull request, #34227:
URL: https://github.com/apache/shardingsphere/pull/34227
Fixes #32280
Changes proposed in this pull request:
- Added flow for `whereSegment ` in `onConflictKeyColumnSegment ` which
was missing and required. The current flow is more intent on the `on_duplicate`
of MySQL than `on_conflict ` in Postgres which has been added in Postgres after
Postgres 9.
- While using ON CONFLICT with INSERT INTO statement in Postgres it was
throwing an exception (no value specified for parameter) as it was not able to
set the flow for where statement present in the `optOnConflict` rule which was
eventually failing to read parameter markers expressions and assignments
present in `whereSegment`
- This fix resolves the error and ensures the successful execution of the
`INSERT INTO` statement. The flow for ON DUPLICATE has not been removed or
altered for now, as It may be useful for certain conditions of older versions
of Postgres (and can be deprecated in future if no use case is observed for
long)
---
Before committing this PR, I'm sure that I have checked the following
options:
- [X] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [X] I have self-reviewed the commit code.
- [X] I have (or in comment I request) added corresponding labels for the
pull request.
- [X] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [X] I have added corresponding unit tests for my changes.
- [X] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
