terrymanu commented on code in PR #34169:
URL: https://github.com/apache/shardingsphere/pull/34169#discussion_r1897982421
##########
parser/distsql/statement/src/main/java/org/apache/shardingsphere/distsql/statement/ral/updatable/UnlockClusterStatement.java:
##########
@@ -19,9 +19,16 @@
import lombok.RequiredArgsConstructor;
+import java.util.Optional;
/**
* Unlock cluster statement.
*/
@RequiredArgsConstructor
public final class UnlockClusterStatement extends UpdatableRALStatement {
+
+ private final String timeout;
Review Comment:
How about use long to handle timeout attribute?
##########
parser/distsql/statement/src/main/java/org/apache/shardingsphere/distsql/statement/ral/updatable/UnlockClusterStatement.java:
##########
@@ -19,9 +19,16 @@
import lombok.RequiredArgsConstructor;
+import java.util.Optional;
/**
* Unlock cluster statement.
*/
@RequiredArgsConstructor
public final class UnlockClusterStatement extends UpdatableRALStatement {
+
+ private final String timeout;
Review Comment:
Please use `timeoutMills` instead of `timeout`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
