This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 522218c2fe9 Refactor StringLiteralValue (#33759)
522218c2fe9 is described below
commit 522218c2fe9562c9f16fb1913c551abea03a5a15
Author: Liang Zhang <[email protected]>
AuthorDate: Thu Nov 21 18:50:12 2024 +0800
Refactor StringLiteralValue (#33759)
---
.../parser/core/kernel/KernelDistSQLStatementVisitor.java | 4 ++--
.../statement/core/value/literal/impl/StringLiteralValue.java | 11 -----------
2 files changed, 2 insertions(+), 13 deletions(-)
diff --git
a/parser/distsql/engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/kernel/KernelDistSQLStatementVisitor.java
b/parser/distsql/engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/kernel/KernelDistSQLStatementVisitor.java
index f242c4b0100..43791b5ecc2 100644
---
a/parser/distsql/engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/kernel/KernelDistSQLStatementVisitor.java
+++
b/parser/distsql/engine/src/main/java/org/apache/shardingsphere/distsql/parser/core/kernel/KernelDistSQLStatementVisitor.java
@@ -18,6 +18,7 @@
package org.apache.shardingsphere.distsql.parser.core.kernel;
import org.antlr.v4.runtime.tree.ParseTree;
+import org.apache.groovy.parser.antlr4.util.StringUtils;
import
org.apache.shardingsphere.distsql.parser.autogen.KernelDistSQLStatementBaseVisitor;
import
org.apache.shardingsphere.distsql.parser.autogen.KernelDistSQLStatementParser.AlgorithmDefinitionContext;
import
org.apache.shardingsphere.distsql.parser.autogen.KernelDistSQLStatementParser.AlterComputeNodeContext;
@@ -100,7 +101,6 @@ import org.apache.shardingsphere.sql.parser.api.ASTNode;
import org.apache.shardingsphere.sql.parser.api.visitor.SQLVisitor;
import
org.apache.shardingsphere.sql.parser.statement.core.segment.generic.DatabaseSegment;
import
org.apache.shardingsphere.sql.parser.statement.core.value.identifier.IdentifierValue;
-import
org.apache.shardingsphere.sql.parser.statement.core.value.literal.impl.StringLiteralValue;
import java.util.Collection;
import java.util.Collections;
@@ -149,7 +149,7 @@ public final class KernelDistSQLStatementVisitor extends
KernelDistSQLStatementB
}
private String getPassword(final PasswordContext ctx) {
- return null == ctx ? null :
StringLiteralValue.getStandardEscapesStringLiteralValue(ctx.getText()).getValue();
+ return null == ctx ? null :
StringUtils.replaceStandardEscapes(ctx.getText());
}
@Override
diff --git
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/value/literal/impl/StringLiteralValue.java
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/value/literal/impl/StringLiteralValue.java
index 4a8b9427ad2..3e39355fc1e 100644
---
a/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/value/literal/impl/StringLiteralValue.java
+++
b/parser/sql/statement/core/src/main/java/org/apache/shardingsphere/sql/parser/statement/core/value/literal/impl/StringLiteralValue.java
@@ -18,7 +18,6 @@
package org.apache.shardingsphere.sql.parser.statement.core.value.literal.impl;
import lombok.Getter;
-import org.apache.groovy.parser.antlr4.util.StringUtils;
import
org.apache.shardingsphere.sql.parser.statement.core.value.literal.LiteralValue;
/**
@@ -32,14 +31,4 @@ public final class StringLiteralValue implements
LiteralValue<String> {
public StringLiteralValue(final String value) {
this.value = value.substring(1, value.length() - 1);
}
-
- /**
- * Get special escape sequences string.
- *
- * @param value string text
- * @return String literal value
- */
- public static StringLiteralValue
getStandardEscapesStringLiteralValue(final String value) {
- return new
StringLiteralValue(StringUtils.replaceStandardEscapes(value));
- }
}