This is an automated email from the ASF dual-hosted git repository.

duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 731ff75e01f Adjust params sequence of 
SQLStatementContextFactory.newInstance() (#32039)
731ff75e01f is described below

commit 731ff75e01fb2e1baaa2e44f1898a32032c2d54e
Author: Liang Zhang <[email protected]>
AuthorDate: Mon Jul 8 19:32:09 2024 +0800

    Adjust params sequence of SQLStatementContextFactory.newInstance() (#32039)
---
 .../apache/shardingsphere/infra/binder/SQLBindEngine.java    |  2 +-
 .../binder/context/statement/SQLStatementContextFactory.java | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/SQLBindEngine.java
 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/SQLBindEngine.java
index a053f4d94cd..39513f75f24 100644
--- 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/SQLBindEngine.java
+++ 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/SQLBindEngine.java
@@ -60,7 +60,7 @@ public final class SQLBindEngine {
      * @return SQL statement context
      */
     public SQLStatementContext bind(final SQLStatement sqlStatement, final 
List<Object> params) {
-        return SQLStatementContextFactory.newInstance(metaData, params, 
bind(sqlStatement), currentDatabaseName);
+        return SQLStatementContextFactory.newInstance(metaData, 
bind(sqlStatement), params, currentDatabaseName);
     }
     
     private SQLStatement bind(final SQLStatement statement) {
diff --git 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/statement/SQLStatementContextFactory.java
 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/statement/SQLStatementContextFactory.java
index 5100a814bee..79cc3f79c8d 100644
--- 
a/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/statement/SQLStatementContextFactory.java
+++ 
b/infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/context/statement/SQLStatementContextFactory.java
@@ -126,17 +126,17 @@ public final class SQLStatementContextFactory {
      * Create SQL statement context.
      *
      * @param metaData metadata
-     * @param params SQL parameters
      * @param sqlStatement SQL statement
+     * @param params SQL parameters
      * @param currentDatabaseName current database name
      * @return SQL statement context
      */
-    public static SQLStatementContext newInstance(final ShardingSphereMetaData 
metaData, final List<Object> params, final SQLStatement sqlStatement, final 
String currentDatabaseName) {
+    public static SQLStatementContext newInstance(final ShardingSphereMetaData 
metaData, final SQLStatement sqlStatement, final List<Object> params, final 
String currentDatabaseName) {
         if (sqlStatement instanceof DMLStatement) {
-            return getDMLStatementContext(metaData, params, (DMLStatement) 
sqlStatement, currentDatabaseName);
+            return getDMLStatementContext(metaData, (DMLStatement) 
sqlStatement, params, currentDatabaseName);
         }
         if (sqlStatement instanceof DDLStatement) {
-            return getDDLStatementContext(metaData, params, (DDLStatement) 
sqlStatement, currentDatabaseName);
+            return getDDLStatementContext(metaData, (DDLStatement) 
sqlStatement, params, currentDatabaseName);
         }
         if (sqlStatement instanceof DCLStatement) {
             return getDCLStatementContext((DCLStatement) sqlStatement, 
currentDatabaseName);
@@ -147,7 +147,7 @@ public final class SQLStatementContextFactory {
         return new UnknownSQLStatementContext(sqlStatement);
     }
     
-    private static SQLStatementContext getDMLStatementContext(final 
ShardingSphereMetaData metaData, final List<Object> params, final DMLStatement 
sqlStatement, final String currentDatabaseName) {
+    private static SQLStatementContext getDMLStatementContext(final 
ShardingSphereMetaData metaData, final DMLStatement sqlStatement, final 
List<Object> params, final String currentDatabaseName) {
         if (sqlStatement instanceof SelectStatement) {
             return new SelectStatementContext(metaData, params, 
(SelectStatement) sqlStatement, currentDatabaseName, Collections.emptyList());
         }
@@ -181,7 +181,7 @@ public final class SQLStatementContextFactory {
         throw new UnsupportedSQLOperationException(String.format("Unsupported 
SQL statement `%s`", sqlStatement.getClass().getSimpleName()));
     }
     
-    private static SQLStatementContext getDDLStatementContext(final 
ShardingSphereMetaData metaData, final List<Object> params, final DDLStatement 
sqlStatement, final String currentDatabaseName) {
+    private static SQLStatementContext getDDLStatementContext(final 
ShardingSphereMetaData metaData, final DDLStatement sqlStatement, final 
List<Object> params, final String currentDatabaseName) {
         if (sqlStatement instanceof CreateSchemaStatement) {
             return new CreateSchemaStatementContext((CreateSchemaStatement) 
sqlStatement);
         }

Reply via email to