linghengqian commented on code in PR #30379:
URL: https://github.com/apache/shardingsphere/pull/30379#discussion_r1510295989
##########
infra/util/src/test/java/org/apache/shardingsphere/infra/util/directory/ClasspathResourceDirectoryReaderTest.java:
##########
@@ -45,13 +45,13 @@ void assertReadTest() {
assertThat(resourceNameList.size(), is(5));
final String separator = File.separator;
assertThat(resourceNameList, hasItems("yaml" + separator +
"accepted-class.yaml", "yaml" + separator + "customized-obj.yaml", "yaml" +
separator + "empty-config.yaml",
- "yaml" + separator + "shortcuts-fixture.yaml",
"yaml/fixture/fixture.yaml"));
+ "yaml" + separator + "shortcuts-fixture.yaml", "yaml" +
separator + "fixture" + separator + "fixture.yaml"));
}
@Test
void assertReadNestedTest() {
List<String> resourceNameList =
ClasspathResourceDirectoryReader.read("yaml/fixture").collect(Collectors.toList());
assertThat(resourceNameList.size(), is(1));
- assertThat(resourceNameList, hasItems("yaml/fixture/fixture.yaml"));
+ assertThat(resourceNameList, hasItems("yaml/fixture" + File.separator
+ "fixture.yaml"));
Review Comment:
- @iamhucong Hi, I was wondering if getting a URL like
`yaml/fixture\\fixture.yaml` on Windows 11 is the expected behavior expected by
#30361 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
