This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 50ff0fd69a2 Refactor AgentPluginEnable.isPluginEnabled() (#30259)
50ff0fd69a2 is described below
commit 50ff0fd69a214df6ba4ab54babb51bd0a0df0170
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Feb 23 20:10:20 2024 +0800
Refactor AgentPluginEnable.isPluginEnabled() (#30259)
* Code format for ExecuteErrorsCountAdvice
* Refactor AgentPluginEnable.isPluginEnabled()
* Refactor AgentPluginEnable.isPluginEnabled()
---
.../apache/shardingsphere/agent/api/plugin/AgentPluginEnable.java | 7 ++++---
.../shardingsphere/agent/plugin/core/context/PluginContext.java | 2 +-
.../plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdvice.java | 4 ++--
.../metrics/core/advice/proxy/ExecuteErrorsCountAdviceTest.java | 2 +-
4 files changed, 8 insertions(+), 7 deletions(-)
diff --git
a/agent/api/src/main/java/org/apache/shardingsphere/agent/api/plugin/AgentPluginEnable.java
b/agent/api/src/main/java/org/apache/shardingsphere/agent/api/plugin/AgentPluginEnable.java
index 8c790ab9b0e..fa71cfba546 100644
---
a/agent/api/src/main/java/org/apache/shardingsphere/agent/api/plugin/AgentPluginEnable.java
+++
b/agent/api/src/main/java/org/apache/shardingsphere/agent/api/plugin/AgentPluginEnable.java
@@ -17,6 +17,9 @@
package org.apache.shardingsphere.agent.api.plugin;
+/**
+ * Agent plugin enable.
+ */
public interface AgentPluginEnable {
/**
@@ -24,7 +27,5 @@ public interface AgentPluginEnable {
*
* @return true or false
*/
- default boolean isPluginEnabled() {
- return true;
- }
+ boolean isPluginEnabled();
}
diff --git
a/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/context/PluginContext.java
b/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/context/PluginContext.java
index 1649eecf5ba..afc3a364399 100644
---
a/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/context/PluginContext.java
+++
b/agent/plugins/core/src/main/java/org/apache/shardingsphere/agent/plugin/core/context/PluginContext.java
@@ -67,7 +67,7 @@ public final class PluginContext {
/**
* Get context manager.
*
- * @return ContextManager
+ * @return context manager
*/
public Optional<ContextManager> getContextManager() {
if (isEnhancedForProxy) {
diff --git
a/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdvice.java
b/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdvice.java
index 9c0c0b674bc..64a21d65919 100644
---
a/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdvice.java
+++
b/agent/plugins/metrics/core/src/main/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdvice.java
@@ -32,8 +32,8 @@ import java.util.Collections;
*/
public final class ExecuteErrorsCountAdvice extends
AbstractInstanceMethodAdvice {
- private final MetricConfiguration config = new
MetricConfiguration("proxy_execute_errors_total",
- MetricCollectorType.COUNTER, "Total execute errors of
ShardingSphere-Proxy", Collections.emptyList(), Collections.emptyMap());
+ private final MetricConfiguration config = new MetricConfiguration(
+ "proxy_execute_errors_total", MetricCollectorType.COUNTER, "Total
execute errors of ShardingSphere-Proxy", Collections.emptyList(),
Collections.emptyMap());
@Override
public void afterMethod(final TargetAdviceObject target, final Method
method, final Object[] args, final Object result, final String pluginType) {
diff --git
a/agent/plugins/metrics/core/src/test/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdviceTest.java
b/agent/plugins/metrics/core/src/test/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdviceTest.java
index 33d4d9c05a8..df3c8fa24b5 100644
---
a/agent/plugins/metrics/core/src/test/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdviceTest.java
+++
b/agent/plugins/metrics/core/src/test/java/org/apache/shardingsphere/agent/plugin/metrics/core/advice/proxy/ExecuteErrorsCountAdviceTest.java
@@ -34,7 +34,7 @@ import static org.mockito.Mockito.mock;
class ExecuteErrorsCountAdviceTest {
- private final MetricConfiguration config = new
MetricConfiguration("proxy_execute_errors_total", MetricCollectorType.COUNTER,
null, Collections.emptyList(), Collections.emptyMap());
+ private final MetricConfiguration config = new
MetricConfiguration("proxy_execute_errors_total", MetricCollectorType.COUNTER,
null, Collections.emptyList());
@AfterEach
void reset() {
