This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new f0d43f80653 Use @RequiredArgsConstructor instead of
@AllArgsConstructor (#30171)
f0d43f80653 is described below
commit f0d43f80653db5759466f2ace1486181bac4fcde
Author: Liang Zhang <[email protected]>
AuthorDate: Sun Feb 18 15:53:41 2024 +0800
Use @RequiredArgsConstructor instead of @AllArgsConstructor (#30171)
---
.../shardingsphere/encrypt/spi/EncryptAlgorithmMetaData.java | 2 --
.../pipeline/opengauss/ingest/wal/decode/MppdbDecodingPlugin.java | 7 +++----
.../postgresql/ingest/wal/decode/PostgreSQLLogSequenceNumber.java | 4 ++--
.../postgresql/ingest/wal/decode/PostgreSQLTimestampUtils.java | 4 ++--
.../proxy/backend/distsql/export/ExportedStorageNode.java | 6 +++---
.../proxy/backend/distsql/export/ExportedStorageNodes.java | 6 +++---
.../shardingsphere/test/natived/jdbc/commons/entity/Address.java | 2 +-
.../shardingsphere/test/natived/jdbc/commons/entity/Order.java | 2 +-
.../shardingsphere/test/natived/jdbc/commons/entity/OrderItem.java | 2 +-
9 files changed, 16 insertions(+), 19 deletions(-)
diff --git
a/features/encrypt/api/src/main/java/org/apache/shardingsphere/encrypt/spi/EncryptAlgorithmMetaData.java
b/features/encrypt/api/src/main/java/org/apache/shardingsphere/encrypt/spi/EncryptAlgorithmMetaData.java
index ea725ed0ec1..cff0d7a4d1f 100644
---
a/features/encrypt/api/src/main/java/org/apache/shardingsphere/encrypt/spi/EncryptAlgorithmMetaData.java
+++
b/features/encrypt/api/src/main/java/org/apache/shardingsphere/encrypt/spi/EncryptAlgorithmMetaData.java
@@ -18,13 +18,11 @@
package org.apache.shardingsphere.encrypt.spi;
import lombok.Getter;
-import lombok.RequiredArgsConstructor;
import lombok.Setter;
/**
* Encrypt algorithm meta data.
*/
-@RequiredArgsConstructor
@Getter
public final class EncryptAlgorithmMetaData {
diff --git
a/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/decode/MppdbDecodingPlugin.java
b/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/decode/MppdbDecodingPlugin.java
index 3ca13888fea..3e77111bf78 100644
---
a/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/decode/MppdbDecodingPlugin.java
+++
b/kernel/data-pipeline/dialect/opengauss/src/main/java/org/apache/shardingsphere/data/pipeline/opengauss/ingest/wal/decode/MppdbDecodingPlugin.java
@@ -18,7 +18,7 @@
package org.apache.shardingsphere.data.pipeline.opengauss.ingest.wal.decode;
import com.google.common.base.Preconditions;
-import lombok.AllArgsConstructor;
+import lombok.RequiredArgsConstructor;
import
org.apache.shardingsphere.data.pipeline.core.constant.PipelineSQLOperationType;
import org.apache.shardingsphere.data.pipeline.core.exception.IngestException;
import
org.apache.shardingsphere.data.pipeline.postgresql.ingest.wal.decode.BaseLogSequenceNumber;
@@ -48,7 +48,7 @@ import java.util.List;
/**
* Mppdb decoding plugin in openGauss.
*/
-@AllArgsConstructor
+@RequiredArgsConstructor
public final class MppdbDecodingPlugin implements DecodingPlugin {
private final BaseTimestampUtils timestampUtils;
@@ -56,8 +56,7 @@ public final class MppdbDecodingPlugin implements
DecodingPlugin {
private final boolean decodeWithTX;
public MppdbDecodingPlugin(final BaseTimestampUtils timestampUtils) {
- this.timestampUtils = timestampUtils;
- decodeWithTX = false;
+ this(timestampUtils, false);
}
@Override
diff --git
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/PostgreSQLLogSequenceNumber.java
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/PostgreSQLLogSequenceNumber.java
index 9d7bf20b257..2b15f5d09da 100644
---
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/PostgreSQLLogSequenceNumber.java
+++
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/PostgreSQLLogSequenceNumber.java
@@ -17,14 +17,14 @@
package org.apache.shardingsphere.data.pipeline.postgresql.ingest.wal.decode;
-import lombok.AllArgsConstructor;
+import lombok.RequiredArgsConstructor;
import lombok.ToString;
import org.postgresql.replication.LogSequenceNumber;
/**
* PostgreSQL sequence.
*/
-@AllArgsConstructor
+@RequiredArgsConstructor
@ToString
public final class PostgreSQLLogSequenceNumber implements
BaseLogSequenceNumber {
diff --git
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/PostgreSQLTimestampUtils.java
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/PostgreSQLTimestampUtils.java
index f7e112634c2..d13394fbb99 100644
---
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/PostgreSQLTimestampUtils.java
+++
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/PostgreSQLTimestampUtils.java
@@ -17,7 +17,7 @@
package org.apache.shardingsphere.data.pipeline.postgresql.ingest.wal.decode;
-import lombok.AllArgsConstructor;
+import lombok.RequiredArgsConstructor;
import org.postgresql.jdbc.TimestampUtils;
import java.sql.SQLException;
@@ -28,7 +28,7 @@ import java.util.Calendar;
/**
* Timestamp utility class of PostgreSQL.
*/
-@AllArgsConstructor
+@RequiredArgsConstructor
public final class PostgreSQLTimestampUtils implements BaseTimestampUtils {
private final TimestampUtils timestampUtils;
diff --git
a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/distsql/export/ExportedStorageNode.java
b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/distsql/export/ExportedStorageNode.java
index 8bfe13b710a..c8d9f1c2628 100644
---
a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/distsql/export/ExportedStorageNode.java
+++
b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/distsql/export/ExportedStorageNode.java
@@ -25,11 +25,11 @@ import lombok.Setter;
/**
* Exported storage node.
*/
+@AllArgsConstructor
+@NoArgsConstructor
@Getter
@Setter
-@NoArgsConstructor
-@AllArgsConstructor
-public class ExportedStorageNode {
+public final class ExportedStorageNode {
private String ip;
diff --git
a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/distsql/export/ExportedStorageNodes.java
b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/distsql/export/ExportedStorageNodes.java
index 5f1c6647cd9..495b9d10b0b 100644
---
a/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/distsql/export/ExportedStorageNodes.java
+++
b/proxy/backend/core/src/main/java/org/apache/shardingsphere/proxy/backend/distsql/export/ExportedStorageNodes.java
@@ -29,11 +29,11 @@ import java.util.Map;
/**
* Exported storage nodes.
*/
+@AllArgsConstructor
+@NoArgsConstructor
@Getter
@Setter
-@NoArgsConstructor
-@AllArgsConstructor
-public class ExportedStorageNodes {
+public final class ExportedStorageNodes {
@JsonProperty("storage_nodes")
private Map<String, Collection<ExportedStorageNode>> storageNodes;
diff --git
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/Address.java
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/Address.java
index 768bd864766..a9d8b7f09c2 100644
---
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/Address.java
+++
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/Address.java
@@ -23,9 +23,9 @@ import lombok.NoArgsConstructor;
import java.io.Serializable;
-@Data
@AllArgsConstructor
@NoArgsConstructor
+@Data
public class Address implements Serializable {
private static final long serialVersionUID = 4743102234543827855L;
diff --git
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/Order.java
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/Order.java
index 57e091e13a2..ceab93a5b44 100644
---
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/Order.java
+++
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/Order.java
@@ -23,9 +23,9 @@ import lombok.NoArgsConstructor;
import java.io.Serializable;
-@Data
@AllArgsConstructor
@NoArgsConstructor
+@Data
public class Order implements Serializable {
private static final long serialVersionUID = 8306802022239174861L;
diff --git
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/OrderItem.java
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/OrderItem.java
index 711e76098ac..80488212080 100644
---
a/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/OrderItem.java
+++
b/test/native/src/test/java/org/apache/shardingsphere/test/natived/jdbc/commons/entity/OrderItem.java
@@ -23,9 +23,9 @@ import lombok.NoArgsConstructor;
import java.io.Serializable;
-@Data
@AllArgsConstructor
@NoArgsConstructor
+@Data
public class OrderItem implements Serializable {
private static final long serialVersionUID = 1332162822494069342L;
