azexcy commented on code in PR #29810:
URL: https://github.com/apache/shardingsphere/pull/29810#discussion_r1462701849
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/listener/PipelineContextManagerLifecycleListener.java:
##########
@@ -51,6 +61,22 @@ public void onInitialized(final String databaseName, final
ContextManager contex
PipelineContextManager.putContext(contextKey, new
PipelineContext(modeConfig, contextManager));
PipelineMetaDataNodeWatcher.getInstance(contextKey);
ElasticJobServiceLoader.registerTypedService(ElasticJobListener.class);
+ dispatchEnablePipelineJobStartEvent(contextKey);
+ }
+
+ private void dispatchEnablePipelineJobStartEvent(final PipelineContextKey
contextKey) {
Review Comment:
Add runtime exception cache, It's not thrown exception usually.
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/listener/PipelineContextManagerLifecycleListener.java:
##########
@@ -51,6 +61,22 @@ public void onInitialized(final String databaseName, final
ContextManager contex
PipelineContextManager.putContext(contextKey, new
PipelineContext(modeConfig, contextManager));
PipelineMetaDataNodeWatcher.getInstance(contextKey);
ElasticJobServiceLoader.registerTypedService(ElasticJobListener.class);
+ dispatchEnablePipelineJobStartEvent(contextKey);
+ }
+
+ private void dispatchEnablePipelineJobStartEvent(final PipelineContextKey
contextKey) {
Review Comment:
Add runtime exception catch, It's not thrown exception usually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
