Zhenye-Na commented on code in PR #28646: URL: https://github.com/apache/shardingsphere/pull/28646#discussion_r1349275240
########## infra/common/src/test/java/org/apache/shardingsphere/infra/metadata/database/ShardingSphereDatabaseTest.java: ########## @@ -31,51 +43,117 @@ import org.apache.shardingsphere.test.fixture.jdbc.MockedDataSource; import org.apache.shardingsphere.test.mock.AutoMockExtension; import org.apache.shardingsphere.test.mock.StaticMockSettings; +import org.apache.shardingsphere.infra.config.database.DatabaseConfiguration; +import org.apache.shardingsphere.infra.config.props.ConfigurationProperties; +import org.apache.shardingsphere.infra.database.core.type.DatabaseType; +import org.apache.shardingsphere.infra.database.core.type.DatabaseTypeRegistry; +import org.apache.shardingsphere.infra.metadata.database.resource.StorageResource; +import org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereSchema; + import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; import org.mockito.junit.jupiter.MockitoSettings; import org.mockito.quality.Strictness; +import javax.sql.DataSource; import java.sql.SQLException; import java.util.Collection; import java.util.Collections; import java.util.LinkedList; import java.util.Properties; - -import static org.hamcrest.CoreMatchers.is; -import static org.hamcrest.MatcherAssert.assertThat; -import static org.junit.jupiter.api.Assertions.assertFalse; -import static org.junit.jupiter.api.Assertions.assertNotNull; -import static org.junit.jupiter.api.Assertions.assertTrue; -import static org.mockito.Mockito.RETURNS_DEEP_STUBS; -import static org.mockito.Mockito.mock; +import java.util.HashMap; +import java.util.Map; @ExtendWith(AutoMockExtension.class) @StaticMockSettings(ShardingSphereDatabase.class) @MockitoSettings(strictness = Strictness.LENIENT) class ShardingSphereDatabaseTest { - + + @Test + void assertContainsSchema() { + DatabaseType databaseType = mock(DatabaseType.class); + RuleMetaData ruleMetaData = mock(RuleMetaData.class); + Map<String, ShardingSphereSchema> schemas = new HashMap<>(); + ShardingSphereSchema schema = mock(ShardingSphereSchema.class); + schemas.put("schema1", schema); + ShardingSphereDatabase database = new ShardingSphereDatabase("foo_db", databaseType, mock(ResourceMetaData.class), ruleMetaData, schemas); + assertTrue(database.containsSchema("schema1")); + assertFalse(database.containsSchema("non_existent_schema")); + } + + @Test + void assertGetSchema() { + DatabaseType databaseType = mock(DatabaseType.class); + RuleMetaData ruleMetaData = mock(RuleMetaData.class); + Map<String, ShardingSphereSchema> schemas = new HashMap<>(); + ShardingSphereSchema schema = mock(ShardingSphereSchema.class); + schemas.put("schema1", schema); + ShardingSphereDatabase database = new ShardingSphereDatabase("foo_db", databaseType, mock(ResourceMetaData.class), ruleMetaData, schemas); + assertEquals(schema, database.getSchema("schema1")); Review Comment: ack -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@shardingsphere.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org